From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/58996 Path: main.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: bug/patch: gnus-start.el gnus-convert-old-newsrc Date: Tue, 26 Oct 2004 19:18:50 +0200 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1098811162 12123 80.91.229.6 (26 Oct 2004 17:19:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 26 Oct 2004 17:19:22 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 26 19:19:15 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CMUyY-0000vv-00 for ; Tue, 26 Oct 2004 19:19:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CMV6G-0005SA-3w for ged-emacs-devel@m.gmane.org; Tue, 26 Oct 2004 13:27:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CMV65-0005Pw-KF for emacs-devel@gnu.org; Tue, 26 Oct 2004 13:27:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CMV64-0005PL-TI for emacs-devel@gnu.org; Tue, 26 Oct 2004 13:27:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CMV64-0005P3-OS for emacs-devel@gnu.org; Tue, 26 Oct 2004 13:27:00 -0400 Original-Received: from [134.60.1.1] (helo=mail-new.rz.uni-ulm.de) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CMUyG-0000wT-EF for emacs-devel@gnu.org; Tue, 26 Oct 2004 13:18:56 -0400 Original-Received: from lumberjack.physik.uni-ulm.de (lumberjack.physik.uni-ulm.de [134.60.10.173]) by mail.uni-ulm.de (8.13.1/8.13.1) with ESMTP id i9QHIoSf015965; Tue, 26 Oct 2004 19:18:51 +0200 (MEST) Original-Received: by lumberjack.physik.uni-ulm.de (Postfix, from userid 170) id AC7CE1817E; Tue, 26 Oct 2004 19:18:50 +0200 (CEST) Mail-Followup-To: quarl+dated+1099214237.460ccf@nospam.quarl.org, emacs-devel@gnu.org, ding@gnus.org Original-To: quarl+dated+1099214237.460ccf@nospam.quarl.org X-Face: .*T0'iU(sujq_j9\J>-d4fg; N/1++U#U$_5ii6k.=|"-n'?5O:Hyz&wi'-!I~,}7~GgT=0S /&-R5sbkNy5+Xo1y{Tw2KKxi@Xh"g@]Qc|.U<*]WDd)qvGowFDvfU1F]{EDho:7P0@|oOD=Bc{K4?> WP68K[Mx:}=`ZT'6g4'f+g?;`vri2!)xGy}3:=l'(/Cea0l4lo^H5#@/Z3ev In-Reply-To: (Karl Chen's message of "Tue, 26 Oct 2004 02:22:40 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-DCC-RollaNet-Metrics: gemini 1004; Body=3 Fuz1=3 Fuz2=3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28979 gmane.emacs.gnus.general:58996 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:58996 On Tue, Oct 26 2004, Karl Chen wrote: > `gnus-convert-old-newsrc' has a bug. This micropatch fixes it. > This is from Emacs CVS HEAD. [...] > (while (and converters (< fcv (caar converters)) > - (<= (caar converters) gnus-version)) > + (<= (caar converters) (gnus-continuum-version gnus-version))) This problem has already been fixed in the Gnus v5-10 branch, I think. The fix will be available in Emacs CVS within a couple of days. --8<---------------cut here---------------start------------->8--- --- gnus-start.el 21 Oct 2004 04:18:22 -0000 6.87.2.5 +++ gnus-start.el 24 Oct 2004 16:00:01 -0000 6.87.2.6 @@ -2225,7 +2225,8 @@ (defun gnus-convert-old-newsrc () "Convert old newsrc formats into the current format, if needed." (let ((fcv (and gnus-newsrc-file-version - (gnus-continuum-version gnus-newsrc-file-version)))) + (gnus-continuum-version gnus-newsrc-file-version))) + (gcv (gnus-continuum-version))) (when fcv ;; A newsrc file was loaded. (let (prompt-displayed @@ -2259,7 +2260,7 @@ ;; Perform converters to bring older version up to date. (when (and converters (< fcv (caar converters))) (while (and converters (< fcv (caar converters)) - (<= (caar converters) gnus-version)) + (<= (caar converters) gcv)) (let* ((converter-spec (pop converters)) (convert-to (nth 1 converter-spec)) (load-from (nth 2 converter-spec)) --8<---------------cut here---------------end--------------->8--- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/