Re: BUG: ngnus-0.10 can't send messages

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Tue, Jun 24 2008, Uwe Brauer wrote:

> Still I don't understand why it works in 0.6.

Because there was no call to `mail-extract-address-components' with a
non-nil argument ALL in No Gnus 0.6 in your setup.  Your defadvices
don't handle the ALL argument of `mail-extract-address-components'
correctly:

,----[ <f1> f mail-extract-address-components RET | XEmacs ]
| `mail-extract-address-components' is a compiled Lisp function
|   -- loaded from "mail-extr"
| (mail-extract-address-components ADDRESS &optional ALL)
| 
| Documentation:
| Given an RFC-822 address ADDRESS, extract full name and canonical address.
| Returns a list of the form (FULL-NAME CANONICAL-ADDRESS).
| If no name can be extracted, FULL-NAME will be nil.  Also see
| `mail-extr-ignore-single-names'.
| 
| If the optional argument ALL is non-nil, then ADDRESS can contain zero   <--
| or more recipients, separated by commas, and we return a list of         <--
| the form ((FULL-NAME CANONICAL-ADDRESS) ...) with one element for        <--
| each recipient.  If ALL is nil, then if ADDRESS contains more than       <--
| one recipients, all but the first is ignored.                            <--
| 
| [...]
`----

> (defadvice mail-extract-address-components (after capitalize-mc last activate)
>    "Fix capitalization of \"Mc\" names, e.g. \"Mcdonald\" -> \"McDonald\"."
>    (let ((full-name (car ad-return-value))

(mail-extract-address-components "Uwe Brauer <oub@mat.ucm.es>" t)
--> (("Uwe Brauer" "oub@mat.ucm.es"))

full-name
--> ("Uwe Brauer" "oub@mat.ucm.es")     [a list!]

(string-match "\\<Mc\\([^aeiou]\\)" ("Uwe Brauer" "oub@mat.ucm.es") ...)
==> ERROR.

I wonder why there was no indication in your backtrace that the
function is advised.  In Emacs 22, the backtrace would tell:

,----[ Backtrace with broken advise ]
| Debugger entered--Lisp error: (wrong-type-argument stringp
|    ("Uwe Brauer" "oub@mat.ucm.es"))
|   string-match("\\<Mc\\([^aeiou]\\)" ("Uwe Brauer" "oub@mat.ucm.es") 0)
|   (and full-name (string-match "\\<Mc\\([^aeiou]\\)" full-name start))
|   (while (and full-name (string-match "\\<Mc\\([^aeiou]\\)"
|    full-name start)) (aset full-name (match-beginning 1) (upcase
|    ...)) (setq start (match-end 0)))
|   (let ((full-name ...) (case-fold-search nil) (start 0)) (while
|   (and full-name ...) (aset full-name ... ...) (setq start ...)))
|   (let (ad-return-value) (setq ad-return-value
|    (ad-Orig-mail-extract-address-components address all)) (let
|    (... ... ...) (while ... ... ...)) ad-return-value)
|   mail-extract-address-components("Uwe Brauer <oub@mat.ucm.es>" t)
|   eval((mail-extract-address-components "Uwe Brauer <oub@mat.ucm.es>" t))
|   eval-last-sexp-1(t)
|   eval-last-sexp(t)
|   eval-print-last-sexp()
|   call-interactively(eval-print-last-sexp)
`----

> The most likely culprit seem to me the defadvice things. I will
> comment them out and see what happens, (still insisting that in 0.6 it
> works): ok now gnus-0.10 works. The question is, how could this
> defadvice function work again under 0.10???

Fix it to handle non-nil ALL correctly.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/