Editing References; Bug in ` message-generate-headers'? (was: About follup headers on usenet)

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Wed, Jan 16 2008, Dan Nicolaescu wrote:

> And this has the bad property that even if you do
> (setq message-hidden-headers nil)
>
> and then remove the "References" header, it will still get added to the
> message when the message is sent.
> Is this considered a good idea?

There was some discussion abut this:

,----
| Subject: Header im message buffer
| From: Oliver Scholz <alkibia...@gmx.de>
| Date: Mon, 19 Mar 2007 19:27:50 +0100
| Message-ID: <45fed62a$0$20297$9b4e6d93@newsspool3.arcor-online.net>
| Newsgroups: de.comm.software.gnus
`----

Andreas Seltenreich proposed a patch (see below), but I didn't have
time to test it.  Anyone?

,----[ http://thread.gmane.org/87ejnblqf5.fsf@gate450.dyndns.org ]
| From: Andreas Seltenreich <andreas+ding@gate450.dyndns.org>
| Subject: dysfunctional code in message-generate-headers
| To: ding@gnus.org
| Date: Mon, 26 Mar 2007 22:07:26 +0200
| Message-ID: <87ejnblqf5.fsf@gate450.dyndns.org>
| 
| Hi,
| 
| there's some discussion in de.comm.software.gnus about an unintuitive
| behavior of Message.  Currently, a "References" header that was
| inserted on buffer creation and deleted by the user is inserted again
| when the mail is being sent.  There's also an older bug report about
| this: <news:87lkok9nnw.fsf@jidanni.org>.
| 
| Looking at the code, it seems that message-generate-headers already
| has some provision to avoid repeated insertion.  However, the code
| doesn't cause any effect at the moment, as it only puts /non-optional/
| headers into message-inserted-headers, while the check to avoid
| repeated insertion only applies to /optional/ ones.
| 
| This looks like a bug to me, and actually putting optional headers
| into message-inserted-headers as in the attached patch results in the
| behavior desired in the bug reports.
| 
| I'd like to propose this patch for No Gnus for now, since it
| essentially enables an old feature for the first time.  WDYT?
`----

--8<---------------cut here---------------start------------->8---
--- message.el	15 Mar 2007 22:41:21 -0000	7.202
+++ message.el	26 Mar 2007 00:37:08 -0000
@@ -5580,6 +5580,7 @@
 		      (if formatter
 			  (funcall formatter header value)
 			(insert header-string ": " value))
+		      (push header-string message-inserted-headers)
 		      (goto-char (message-fill-field))
 		      ;; We check whether the value was ended by a
 		      ;; newline.  If not, we insert one.
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/