From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66146 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Editing References; Bug in ` message-generate-headers'? (was: About follup headers on usenet) Date: Wed, 16 Jan 2008 22:50:33 +0100 Message-ID: References: <87ir20439n.fsf@newsguy.com> <87bq7psqmk.fsf@newsguy.com> <200801160722.m0G7MfWs003628@sallyv1.ics.uci.edu> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1200520370 13552 80.91.229.12 (16 Jan 2008 21:52:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Jan 2008 21:52:50 +0000 (UTC) Cc: ding@gnus.org To: Dan Nicolaescu Original-X-From: ding-owner+M14638@lists.math.uh.edu Wed Jan 16 22:53:01 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1JFGBm-0005mV-0W for ding-account@gmane.org; Wed, 16 Jan 2008 22:52:50 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1JFGAZ-0001Ki-3Q; Wed, 16 Jan 2008 15:51:35 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1JFGAW-0001K7-Bi for ding@lists.math.uh.edu; Wed, 16 Jan 2008 15:51:32 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1JFGAP-0002O1-Fq for ding@lists.math.uh.edu; Wed, 16 Jan 2008 15:51:32 -0600 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1JFGAQ-0003ko-00 for ; Wed, 16 Jan 2008 22:51:26 +0100 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m0GLpM8v006503; Wed, 16 Jan 2008 22:51:22 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 9184712DE4; Wed, 16 Jan 2008 22:51:22 +0100 (CET) X-Face: :6KQZ[nyoS_edmB.%gw-=)BYth^|2+Y+^cu%I$FSx!&>-'om>3H7A|M&n(V7fIo3P.;yo.b yq4$p;ZaBtkv)\}biaiBQe"mD}iib1AA@99-fZ7i*bLhNRVC&0Wkxg9)SH?oWc@{ Mail-Followup-To: Dan Nicolaescu , ding@gnus.org In-Reply-To: <200801160722.m0G7MfWs003628@sallyv1.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 15 Jan 2008 23:22:40 -0800") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-DCC-INFN-TO-Metrics: poseidon 1233; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66146 Archived-At: On Wed, Jan 16 2008, Dan Nicolaescu wrote: > And this has the bad property that even if you do > (setq message-hidden-headers nil) > > and then remove the "References" header, it will still get added to the > message when the message is sent. > Is this considered a good idea? There was some discussion abut this: ,---- | Subject: Header im message buffer | From: Oliver Scholz | Date: Mon, 19 Mar 2007 19:27:50 +0100 | Message-ID: <45fed62a$0$20297$9b4e6d93@newsspool3.arcor-online.net> | Newsgroups: de.comm.software.gnus `---- Andreas Seltenreich proposed a patch (see below), but I didn't have time to test it. Anyone? ,----[ http://thread.gmane.org/87ejnblqf5.fsf@gate450.dyndns.org ] | From: Andreas Seltenreich | Subject: dysfunctional code in message-generate-headers | To: ding@gnus.org | Date: Mon, 26 Mar 2007 22:07:26 +0200 | Message-ID: <87ejnblqf5.fsf@gate450.dyndns.org> | | Hi, | | there's some discussion in de.comm.software.gnus about an unintuitive | behavior of Message. Currently, a "References" header that was | inserted on buffer creation and deleted by the user is inserted again | when the mail is being sent. There's also an older bug report about | this: . | | Looking at the code, it seems that message-generate-headers already | has some provision to avoid repeated insertion. However, the code | doesn't cause any effect at the moment, as it only puts /non-optional/ | headers into message-inserted-headers, while the check to avoid | repeated insertion only applies to /optional/ ones. | | This looks like a bug to me, and actually putting optional headers | into message-inserted-headers as in the attached patch results in the | behavior desired in the bug reports. | | I'd like to propose this patch for No Gnus for now, since it | essentially enables an old feature for the first time. WDYT? `---- --8<---------------cut here---------------start------------->8--- --- message.el 15 Mar 2007 22:41:21 -0000 7.202 +++ message.el 26 Mar 2007 00:37:08 -0000 @@ -5580,6 +5580,7 @@ (if formatter (funcall formatter header value) (insert header-string ": " value)) + (push header-string message-inserted-headers) (goto-char (message-fill-field)) ;; We check whether the value was ended by a ;; newline. If not, we insert one. --8<---------------cut here---------------end--------------->8--- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/