Re: smtpmail.el: set-buffer-file-coding-system takes too many args

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Wed, Jan 03 2007, David Z Maze wrote:

> I ran 'cvs update' after a long drought and suddenly couldn't send any
> mail!  I tracked this down to a change in smtpmail.el that sets the
> coding system on outgoing mail buffers; it calls
> set-buffer-file-coding-system with four arguments, but my Emacs ("GNU
> Emacs 21.4.1 (sparc-sun-solaris2.10, X toolkit) of 2005-05-31 on
> maytag.mit.edu") only takes three.
>
> To make things work I needed the following:
>
> --- smtpmail.el 27 Nov 2006 00:39:24 -0000      7.5
> +++ smtpmail.el 3 Jan 2007 15:25:57 -0000
> @@ -248,7 +248,7 @@
>           ;; buffer, otherwise any write-region invocations (e.g., in
>           ;; mail-do-fcc below) will annoy with asking for a suitable
>           ;; encoding.
> -         (set-buffer-file-coding-system smtpmail-code-conv-from nil t)
> +         (set-buffer-file-coding-system smtpmail-code-conv-from nil)
[...]
> Is the last arg necessary on some other Emacs?

If I understand Eli's comment correctly, it seems to be necessary (at
least for mail-do-fcc).

> Is there some Gnus compatability shim that'll work here?  Does its
> status in "contrib" affect things any?

The version in contrib/ is synced from Emacs CVS:

,----[ contrib/README ]
| sendmail.el
| smtpmail.el
| 
| 	Copies of the corresponding files from the Emacs lisp/mail/
| 	directory, to provide features (occasionally) needed by Gnus which
| 	may not be provided by the versions of these files in older Emacs
| 	distributions.
`----

IIRC, smtpmail.el is also included with XEmacs.  Simon, is
`smtpmail.el' (from Emacs CVS) supposed to work with XEmacs without
modifications?  If so `smtpmail.el' should probably not use the
NOMODIFY argument or provide some compatibility code.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/