From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63476 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: backporting bugfixes to the v5-10 branch Date: Mon, 17 Jul 2006 19:52:55 +0200 Organization: Dept. of Theoretical Physics, University of Ulm Message-ID: References: <87wtajwzjk.fsf@gate450.dyndns.org> Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1153243542 6097 80.91.229.2 (18 Jul 2006 17:25:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 18 Jul 2006 17:25:42 +0000 (UTC) Original-X-From: ding-owner+m12002@lists.math.uh.edu Tue Jul 18 19:25:38 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G2tJ9-0003pi-MX for ding-account@gmane.org; Tue, 18 Jul 2006 19:24:31 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1G2tIn-0005jA-00; Tue, 18 Jul 2006 12:24:09 -0500 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1G2XHr-0003YG-00 for ding@lists.math.uh.edu; Mon, 17 Jul 2006 12:53:43 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1G2XHl-0000hX-2v for ding@lists.math.uh.edu; Mon, 17 Jul 2006 12:53:43 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1G2XHi-000741-00 for ; Mon, 17 Jul 2006 19:53:34 +0200 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1G2XHX-0001Xc-Eh for ding@gnus.org; Mon, 17 Jul 2006 19:53:24 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de ([134.60.10.123]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Jul 2006 19:53:23 +0200 Original-Received: from Reiner.Steib by bridgekeeper.physik.uni-ulm.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Jul 2006 19:53:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org Original-Lines: 47 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: bridgekeeper.physik.uni-ulm.de X-Face: .*T0'iU(sujq_j9\J>-d4fg;N/1++U#U$_5ii6k.=|"-n'?5O:Hyz&wi'-!I~,}7~GgT=0S /&-R5sbkNy5+Xo1y{Tw2KKxi@Xh"g@]Qc|.U<*]WDd)qvGowFDvfU1F]{EDho:7P0@|oOD=Bc{K4?> WP68K[Mx:}=`ZT'6g4'f+g?;`vri2!)xGy}3:=l'(/Cea0l4lo^H5#@/Z3ev Mail-Copies-To: nobody User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:PP/N4VZN0mPa+2FtI13dNC01M3o= X-Spam-Score: -2.6 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:63476 Archived-At: On Wed, Jul 12 2006, Andreas Seltenreich wrote: > I just reviewed the v5-10 branch with respect to my recent bugfixes in > the trunk, and the following would be applicable to the stable branch, > too: > * nnweb.el (nnweb-google-parse-1): Update regexp for author and date. > (nnweb-google-search): Respect nnweb-max-hits as upper bound. > > * gnus-srvr.el (gnus-browse-unsubscribe-group): Don't subscribe > unsubscribed groups as if they were killed ones. It causes duplicate > entries in gnus-newsrc-alist. > > * mm-url.el (mm-url-insert-file-contents): Don't set Connection: Close. > > Any objections to backporting them? Feel free to backport to v5-10 if you consider the fixes stable enough. > I'm not sure what to do with the change to gnus-find-method-for-group: > > * gnus.el (gnus-find-method-for-group): On killed/unknown groups, try > looking up the method using GROUP's prefix before inventing a new one. > It is used on killed/unknown groups in various places where returning > an all-new method isn't expected by the caller. > > While I can reproduce all of the bugs listed in > on a stable Gnus, ... and the fix as well, I guess? > the fix depends on the macro gnus-group-server, which doesn't exists > on the v5-10 branch. Maybe just inling its code is more appropriate > than adding the macro to v5-10? I'd suggest to add the macro to v5-10 as well. It makes the code more readable and simplifies comparing the different branches. > I'm afraid the alternative to changing gnus-find-method-for-group > would be to locate all places where it could be called on killed > groups, and possibly fixing those. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/