Re: [patch] gnus-art.el handling for t-online addresses

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

On Sun, May 04 2003, Jhair Tocancipa Triana wrote:

> Gnus v.5.10.2 fails to recognize as valid[1] an e-mail address from
> T-Online, when pushing the button on it:
[ <Johannes.Brinkmeier-Moritz@t-online.de> ]
> Patch and proposed ChangeLog entry are attached.

Thanks.  Some comments and questions...

As it's name says, `gnus-button-mid-or-mail-heuristic' is a heuristic
function.  It's not intended to cover every special case.  BTW: In
your example the function returns 'ask, which isn't really wrong. :-)

| +    ;; Certain special cases...
| +    (30.0  . "^0[0-9]+-[0-9][0-9][0-9][0-9]@t-online\\.de$") 
| +    (30.0  . "^[A-Za-z]+[A-Za-z._-]\\{4,29\\}@t-online\\.de$") 
| +    (30.0  . "^[0-9]+\.[0-9]+\@compuserve"))

We can't use \\{4,29\\} because we still support Emacs 20 (and maybe
some XEmacs versions?) that don't support this.  See the ugly
re-formulations of {M,N} expressions.

But maybe, we don't have to be that careful and use
"^[A-Za-z]+[A-Za-z._-][A-Za-z._-][A-Za-z._-][A-Za-z._-]+@t-online\\.de$"
instead?

The current implementation is very close to Florian Weimer's Perl
script[1].  Why do think that it's better to put "Certain special
cases" into the list?

[ Cc'ing Florian (dunno if he's reading ding). ]

| -    ;; Certain special cases...
| -    (when (string-match
| -	   (concat
| -	    "^0[0-9]+-[0-9][0-9][0-9][0-9]@t-online\\.de$" "\\|"
| -	    "^[0-9]+\.[0-9]+\@compuserve")

Maybe we should make this customizable, too?

Bye, Reiner.

[1] <URL: http://www.enyo.de/fw/scripts/message-id-or-email.pl>
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/