From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/52215 Path: main.gmane.org!not-for-mail From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de> Newsgroups: gmane.emacs.gnus.general Subject: Re: [patch] gnus-art.el handling for t-online addresses Date: Sun, 04 May 2003 14:17:51 +0200 Organization: private Sender: ding-owner@lists.math.uh.edu Message-ID: References: Reply-To: reiner.steib@gmx.de NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1052051428 27060 80.91.224.249 (4 May 2003 12:30:28 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 4 May 2003 12:30:28 +0000 (UTC) Cc: Florian Weimer Original-X-From: ding-owner+M758@lists.math.uh.edu Sun May 04 14:30:26 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19CIdO-00072J-00 for ; Sun, 04 May 2003 14:30:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 19CIea-00050S-00; Sun, 04 May 2003 07:31:40 -0500 Original-Received: from sclp3.sclp.com ([64.157.176.121]) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 19CIeW-00050N-00 for ding@lists.math.uh.edu; Sun, 04 May 2003 07:31:36 -0500 Original-Received: (qmail 50346 invoked by alias); 4 May 2003 12:31:35 -0000 Original-Received: (qmail 50341 invoked from network); 4 May 2003 12:31:35 -0000 Original-Received: from main.gmane.org (80.91.224.249) by sclp3.sclp.com with SMTP; 4 May 2003 12:31:35 -0000 Original-Received: from root by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19CIdD-000720-00 for ; Sun, 04 May 2003 14:30:15 +0200 Mail-Followup-To: ding@gnus.org X-Injected-Via-Gmane: http://gmane.org/ Original-To: ding@gnus.org Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19CITJ-0006e7-00 for ; Sun, 04 May 2003 14:20:01 +0200 Original-Lines: 47 Original-X-Complaints-To: usenet@main.gmane.org X-Face: :6KQZ[nyoS_edmB.%gw-=)BYth^|2+Y+^cu%I$FSx!&>-'om>3H7A|M&n(V7fIo3P.;yo.b yq4$p;ZaBtkv)\}biaiBQe"mD}iib1AA@99-fZ7i*bLhNRVC&0Wkxg9)SH?oWc@{ Mail-Copies-To: nobody User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux) Cancel-Lock: sha1:IXg0/5wPhsZjNVuOfVxrjfn1gUo= Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:52215 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:52215 On Sun, May 04 2003, Jhair Tocancipa Triana wrote: > Gnus v.5.10.2 fails to recognize as valid[1] an e-mail address from > T-Online, when pushing the button on it: [ ] > Patch and proposed ChangeLog entry are attached. Thanks. Some comments and questions... As it's name says, `gnus-button-mid-or-mail-heuristic' is a heuristic function. It's not intended to cover every special case. BTW: In your example the function returns 'ask, which isn't really wrong. :-) | + ;; Certain special cases... | + (30.0 . "^0[0-9]+-[0-9][0-9][0-9][0-9]@t-online\\.de$") | + (30.0 . "^[A-Za-z]+[A-Za-z._-]\\{4,29\\}@t-online\\.de$") | + (30.0 . "^[0-9]+\.[0-9]+\@compuserve")) We can't use \\{4,29\\} because we still support Emacs 20 (and maybe some XEmacs versions?) that don't support this. See the ugly re-formulations of {M,N} expressions. But maybe, we don't have to be that careful and use "^[A-Za-z]+[A-Za-z._-][A-Za-z._-][A-Za-z._-][A-Za-z._-]+@t-online\\.de$" instead? The current implementation is very close to Florian Weimer's Perl script[1]. Why do think that it's better to put "Certain special cases" into the list? [ Cc'ing Florian (dunno if he's reading ding). ] | - ;; Certain special cases... | - (when (string-match | - (concat | - "^0[0-9]+-[0-9][0-9][0-9][0-9]@t-online\\.de$" "\\|" | - "^[0-9]+\.[0-9]+\@compuserve") Maybe we should make this customizable, too? Bye, Reiner. [1] -- ,,, (o o) ---ooO-(_)-Ooo--- PGP key available via WWW http://rsteib.home.pages.de/