* gnus-summary-from-or-to-or-newsgroups (was: Changes committed gnus/lisp (gnus-sum.el)) [not found] <E1FNvQ3-00022a-00@quimby.gnus.org> @ 2006-03-27 18:11 ` Reiner Steib 2006-04-04 20:47 ` gnus-summary-from-or-to-or-newsgroups Reiner Steib 0 siblings, 1 reply; 2+ messages in thread From: Reiner Steib @ 2006-03-27 18:11 UTC (permalink / raw) Cc: ding On Mon, Mar 27 2006, Karl Kleinpaste on ding-patches: > (gnus-summary-from-or-to-or-newsgroups): Improve newsgroups handling > for NNTP overviews which don't include Newsgroups. > --- gnus-sum.el:7.128 Wed Mar 22 08:12:55 2006 > +++ gnus-sum.el Mon Mar 27 19:22:18 2006 > @@ -3522,7 +3522,13 @@ > (inline > (gnus-summary-extract-address-component > (funcall gnus-decode-encoded-word-function to))))) > - ((setq newsgroups (cdr (assq 'Newsgroups extra-headers))) > + ((setq newsgroups > + (or > + (cdr (assq 'Newsgroups extra-headers)) > + (and > + (eq (car (gnus-find-method-for-group > + gnus-newsgroup-name)) 'nntp) > + (replace-in-string gnus-newsgroup-name "^.*:" "")))) > (concat gnus-summary-newsgroup-prefix newsgroups))))) > (inline (gnus-summary-extract-address-component gnus-tmp-from))))) Emacs doesn't have `replace-in-string', you should use `gnus-replace-in-string' if you must. But wouldn't `gnus-group-real-name' be better? I've installed this patch: 2006-03-27 Reiner Steib <Reiner.Steib@gmx.de> * gnus-sum.el (gnus-summary-from-or-to-or-newsgroups): Don't use XEmacs-only `replace-in-string'. Use `gnus-group-real-name' instead. --8<---------------cut here---------------start------------->8--- --- gnus-sum.el 27 Mar 2006 17:22:18 -0000 7.129 +++ gnus-sum.el 27 Mar 2006 18:09:52 -0000 @@ -3528,7 +3528,7 @@ (and (eq (car (gnus-find-method-for-group gnus-newsgroup-name)) 'nntp) - (replace-in-string gnus-newsgroup-name "^.*:" "")))) + (gnus-group-real-name gnus-newsgroup-name)))) (concat gnus-summary-newsgroup-prefix newsgroups))))) (inline (gnus-summary-extract-address-component gnus-tmp-from))))) --8<---------------cut here---------------end--------------->8--- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: gnus-summary-from-or-to-or-newsgroups 2006-03-27 18:11 ` gnus-summary-from-or-to-or-newsgroups (was: Changes committed gnus/lisp (gnus-sum.el)) Reiner Steib @ 2006-04-04 20:47 ` Reiner Steib 0 siblings, 0 replies; 2+ messages in thread From: Reiner Steib @ 2006-04-04 20:47 UTC (permalink / raw) Cc: ding On Mon, Mar 27 2006, Reiner Steib wrote: > On Mon, Mar 27 2006, Karl Kleinpaste on ding-patches: > >> (gnus-summary-from-or-to-or-newsgroups): Improve newsgroups handling >> for NNTP overviews which don't include Newsgroups. [...] > Emacs doesn't have `replace-in-string', you should use > `gnus-replace-in-string' if you must. But wouldn't > `gnus-group-real-name' be better? I've installed this patch: [...] Additionally, I think Gnus shouldn't display the Newsgroup line if `gnus-extra-headers' doesn't contain 'Newsgroups. --8<---------------cut here---------------start------------->8--- --- gnus-sum.el 27 Mar 2006 20:07:29 +0200 7.130 +++ gnus-sum.el 04 Apr 2006 22:34:34 +0200 @@ -3526,6 +3526,7 @@ (or (cdr (assq 'Newsgroups extra-headers)) (and + (memq 'Newsgroups gnus-extra-headers) (eq (car (gnus-find-method-for-group gnus-newsgroup-name)) 'nntp) (gnus-group-real-name gnus-newsgroup-name)))) --8<---------------cut here---------------end--------------->8--- (Installed.) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-04 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1FNvQ3-00022a-00@quimby.gnus.org>
2006-03-27 18:11 ` gnus-summary-from-or-to-or-newsgroups (was: Changes committed gnus/lisp (gnus-sum.el)) Reiner Steib
2006-04-04 20:47 ` gnus-summary-from-or-to-or-newsgroups Reiner Steib
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).