Re: default-enable-multibyte-characters in pgg-gpg

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Wed, Mar 29 2006, Daiki Ueno wrote:

>>>>>>	Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>> As your patch just reverts this patch, I'd guess that it will
>> reintroduce the problem the other patch tried to solve.
>
> Ah, I understand why this was necessary at that time.
>
> When the patch was introduced, pgg-gpg used synchronous code and sent
> a passphrase together with data on a temp buffer:  [...]

Yes, revision 6.17 (in Gnus CVS) had this code.

> So I think setting default-enable-multibyte-characters is no longer
> necessary because we switched to use asynchronous code and passphrases
> are sent separately.

Thank you for this explanation.  I think we should clarify this in
the ChangeLog as follows:

--8<---------------cut here---------------start------------->8---
2006-03-29  Daiki Ueno  <ueno@unixuser.org>

	* pgg-gpg.el (pgg-gpg-start-process): Don't bind
	default-enable-multibyte-characters.  This reverts the change from
	revision 6.17 which is no longer necessary because the passphrase
	is sent separately now.  GnuPG messages are unreadable under
	multibyte locales with default-enable-multibyte-characters set to
	nil.
--8<---------------cut here---------------end--------------->8---

For testing, I changed my pass-phrase to start with `ä' (#x8e4,
U+00E4, LATIN SMALL LETTER A DIAERESIS) which I can enter using
MultiKey-a [1].  When sending a signed message I get (both, with and
without default-enable-multibyte-characters):

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (error "Attempt to change byte length of a string")
  fillarray("\x8e4[...]" 0)
  pgg-gpg-status-BAD_PASSPHRASE(#<process pgg-gpg<2>> "BAD_PASSPHRASE E222255A3C6B854E")
  pgg-gpg-process-filter(#<process pgg-gpg<2>> "[GNUPG:] BAD_PASSPHRASE E222255A3C6B854E\n")
  accept-process-output(#<process pgg-gpg<2>> 1)
  pgg-gpg-wait-for-status(#<process pgg-gpg<2>> ("GOOD_PASSPHRASE"))
  pgg-gpg-sign-region(1 256 nil nil)
  funcall(pgg-gpg-sign-region 1 256 nil nil)
  apply(funcall pgg-gpg-sign-region (1 256 nil nil))
  pgg-invoke("sign-region" gpg 1 256 nil nil)
  pgg-sign-region(1 256)
  mml2015-pgg-sign((part (sign . "pgpmime") (tag-location . 1492) (contents . "[...]")))
  mml2015-sign((part (sign . "pgpmime") (tag-location . 1492) (contents . "[...]")))
  mml-generate-mime()
  message-encode-message-body()
  message-send-mail(nil)
  message-send-via-mail(nil)
  message-send(nil)
  message-send-and-exit(nil)
  call-interactively(message-send-and-exit)
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.

[1] xmodmap -e 'keysym  a = a A adiaeresis Adiaeresis'
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/