Attachments and security menu (was: Entering passphrase twice when sending PGP signed message)

[Reiner Steib <reinersteib+gmane@imap.cc>]

[ Following up to an old thread:
  http://thread.gmane.org/m365jukh3s.fsf%40defun.localdomain ]

On Sat, Oct 18 2003, Jesper Harder wrote:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> Jesper Harder <harder@myrealbox.com> writes:
>>
>>>     +---------------------------------+
>>>     | Sign                (C-c RET s) |
>>>     | Encrypt             (C-c RET c) |
>>>     | Sign Part           (C-c RET S) |
>>>     | Encrypt Part        (C-c RET C) |
>>>     | Encrypt/Sign Off  (C-c RET C-n) |
>>>     | Change Security Method     +-----------------------+
>>>     +----------------------------|  [x] PGP/MIME         |
>>>                                  |  [ ] Traditional PGP  |
>>>                                  |  [ ] S/MIME           |
>>>                                  +-----------------------+
>>
>> Beautiful.  Did you check it in?
>
> No.  I thought it would be better to wait for No Gnus to make user
> visible changes like that.

I have installed a new menu based on Jesper's suggestion:

	* mml-sec.el (mml-secure-method): New internal variable.
	(mml-secure-sign, mml-secure-encrypt, mml-secure-message-sign)
	(mml-secure-message-sign-encrypt, mml-secure-message-encrypt): New
	functions using mml-secure-method.

	* mml.el (mml-mode-map): Add key bindings for those functions.
	(mml-menu): Simplify security menu entries.
	(mml-attach-file, mml-attach-buffer, mml-attach-external): Goto
	end of message if point is the headers of the message.

	* message.el (message-in-body-p): New function.

As inserting parts inside message headers makes no sense, I've changed
those functions to go to the end of the message before inserting.
Inserting attachments at the end seems preferable to the top of the
message, because some broken MUAs are not able to deal with inline
parts following attachments.

I was quite unsure about the key bindings and some implementation
details.  Maybe we should also provide an interactive function and key
bindings to change the current method (mml-secure-method).

Comments?  Suggestions?  I don't use encryption/signing often; please
tell me if this change breaks something or if it is inconvenient.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/