* mml-smime.el: gnus-extract-address-components (was: Changes to emacs/lisp/gnus/mml-smime.el) [not found] <E1EASKK-0001qw-00@savannah.gnu.org> @ 2005-08-31 16:30 ` Reiner Steib 2005-08-31 16:51 ` Juanma Barranquero 2005-09-04 20:15 ` mml-smime.el: gnus-extract-address-components Reiner Steib 0 siblings, 2 replies; 3+ messages in thread From: Reiner Steib @ 2005-08-31 16:30 UTC (permalink / raw) Cc: Ding List On Wed, Aug 31 2005, Juanma Barranquero [ on emacs-diffs ]: > --- emacs/lisp/gnus/mml-smime.el:1.5 Sat Aug 6 19:51:42 2005 > +++ emacs/lisp/gnus/mml-smime.el Wed Aug 31 13:08:28 2005 > @@ -29,6 +29,8 @@ > > (eval-when-compile (require 'cl)) > > +(defvar gnus-extract-address-components) I guess this change is intended to fix byte-compiler warnings (Thanks for working on this, Juanma!). In this case, wouldn't it be better to make `mml-smime.el' work without Gnus? Couldn't we replace... (funcall gnus-extract-address-components ...) ... with this? (funcall (if (boundp 'gnus-extract-address-components) gnus-extract-address-components 'mail-extract-address-components) ...) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mml-smime.el: gnus-extract-address-components (was: Changes to emacs/lisp/gnus/mml-smime.el) 2005-08-31 16:30 ` mml-smime.el: gnus-extract-address-components (was: Changes to emacs/lisp/gnus/mml-smime.el) Reiner Steib @ 2005-08-31 16:51 ` Juanma Barranquero 2005-09-04 20:15 ` mml-smime.el: gnus-extract-address-components Reiner Steib 1 sibling, 0 replies; 3+ messages in thread From: Juanma Barranquero @ 2005-08-31 16:51 UTC (permalink / raw) On 8/31/05, Reiner Steib <reinersteib+gmane@imap.cc> wrote: > In this case, wouldn't it be better to make `mml-smime.el' work > without Gnus? Yes, probably. But I have tried not to change the workings of any module, just to silence the bytecompiler. At some places I've seen things which could perhaps be done differently, but in most cases this is up to the individual maintainers; perhaps (surely, in fact) they do know and were thinking of things I don't, like compatibility with other Emacsen, etc. -- /L/e/k/t/u ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mml-smime.el: gnus-extract-address-components 2005-08-31 16:30 ` mml-smime.el: gnus-extract-address-components (was: Changes to emacs/lisp/gnus/mml-smime.el) Reiner Steib 2005-08-31 16:51 ` Juanma Barranquero @ 2005-09-04 20:15 ` Reiner Steib 1 sibling, 0 replies; 3+ messages in thread From: Reiner Steib @ 2005-09-04 20:15 UTC (permalink / raw) Cc: Ding List On Wed, Aug 31 2005, Reiner Steib wrote: > In this case, wouldn't it be better to make `mml-smime.el' work > without Gnus? > > Couldn't we replace... > > (funcall gnus-extract-address-components ...) > > ... with this? > > (funcall (if (boundp 'gnus-extract-address-components) > gnus-extract-address-components > 'mail-extract-address-components) > ...) Nobody objected, so I installed it. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-09-04 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1EASKK-0001qw-00@savannah.gnu.org>
2005-08-31 16:30 ` mml-smime.el: gnus-extract-address-components (was: Changes to emacs/lisp/gnus/mml-smime.el) Reiner Steib
2005-08-31 16:51 ` Juanma Barranquero
2005-09-04 20:15 ` mml-smime.el: gnus-extract-address-components Reiner Steib
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).