Re: mm-coding-system-priorities

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

On Wed, Mar 24 2004, Miles Bader wrote:

> I'm using the gnus in the Emacs source tree, so maybe this problem has
> already been fixed:
>
> `mm-coding-system-priorities' seems to only work properly if the members
> are `canonical' character-set names instead of aliases, 

I have fixed this (before 5.10.1 was released):

,----
| 2003-04-13  Reiner Steib  <Reiner.Steib@gmx.de>
| 
| 	* mm-util.el (mm-sort-coding-systems-predicate): Convert elements
| 	of `mm-coding-system-priorities' to base coding system.
`----

> It seems to me that gnus ought to do this mapping itself, as many coding
> systems have aliases which are more widely used than their canonical emacs
> names.

I agree.

> Perhaps something like (untested):
>
> --- orig/lisp/gnus/mm-util.el
> +++ mod/lisp/gnus/mm-util.el
> @@ -507,8 +507,11 @@
>  	     ;; system that has one.
>  	     (let ((systems (find-coding-systems-region b e)))
>  	       (when mm-coding-system-priorities
> -		 (setq systems
> -		       (sort systems 'mm-sort-coding-systems-predicate)))
> +		 (let ((mm-coding-system-priorities 
> +			(mapcar #'coding-system-base
> +				mm-coding-system-priorities)))
> +		   (setq systems
> +			 (sort systems 'mm-sort-coding-systems-predicate))))
>  	       ;; Fixme: The `mime-charset' (`x-ctext') of `compound-text'
>  	       ;; is not in the IANA list.
>  	       (setq systems (delq 'compound-text systems))

I've done it in `mm-sort-coding-systems-predicate' (but I don't
remember exactly why I did it in this way).  If you think that your
solution is better, we may change it.

(defun mm-sort-coding-systems-predicate (a b)
  (let ((priorities
	 (mapcar (lambda (cs)
		   ;; Note: invalid entries are dropped silently
		   (and (coding-system-p cs)
			(coding-system-base cs)))
		 mm-coding-system-priorities)))
    (> (length (memq a priorities))
       (length (memq b priorities)))))

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/