Re: A lot of questions concerning `gnus-score-edit-file-at-point'

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

On Tue, Dec 30 2003, Karl Pflästerer wrote:

> On 29 Dec 2003, Reiner Steib <- 4.uce.03.r.s@nurfuerspam.de wrote:
[...]
>> But we can make the *Score Trace* buffer more readable with
>> `truncate-lines': We can use `abbreviate-file-name' on the full file
>> name and also print the file name (without directory and extension).
>> It could look like this:
>
>> ("@my-fqdn>$" 10000 nil r) [my-posts] ->  ~/News/score/topics/my-posts.SCORE
>
> What are »[my-posts]«?

"my-posts" is the name of the score file without directory and without
extension:

+			  (file-name-sans-extension
+			   (file-name-nondirectory file))

> [b] 
> (defun gnus-score-edit-file-at-point ()
[...]
> 	 (sep "[ \n\r\t]*")
> 	 (reg (cddr (assq 'newformat gnus-score-trace-format-alist)))
> 	(file (save-excursion
> 		;; only works in a Score Trace buffer
> 		(end-of-line)
> 		(if (and (re-search-backward reg (point-at-bol) t)
> 			 (re-search-forward  reg (point-at-eol) t))
> 		  (buffer-substring (point) (point-at-eol))
> 		  nil))))
[...]
> (defvar gnus-score-trace-format-alist
>   (list ;; name            format string     regexp    
>    (cons 'newformat (cons "%S [%s] -> %s\n" "-> +"))
>    (cons 'oldformat (cons "%S -> %3$s\n"    "-> +"))))

I don't understand the aim behind `gnus-score-trace-format-alist' in
your code.  If 'newformat (or 'oldformat) is hard-coded in the
relevant functions, I see no need for the variable.

We could use a variable to hold the delimiters (and maybe regexps?):

("@my-fqdn>$" 10000 nil r) [my-posts] ->  ~/News/score/topics/my-posts.SCORE
^^^^^^^^^^^^^^^^^^^^^^^^^^--^^^^^^^^_^^^^^----------------------------------
(a)                        |  (c)   | (e)             (f)
                          (b)      (d)

(a) the score rule
(b) opening delimiter for (c)
(c) abbreviated score file name (w/o directory and extension)
(d) closing delimiter for (c)
(e) separator (needed in `gnus-score-edit-file-at-point')
(f) full name of the score file

(b), (d) and (e) could be in the variable (alist).
`gnus-score-edit-file-at-point' and `gnus-score-find-trace' use this
variable.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/