Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
To: David Engster <deng@randomsample.de>
Cc: ding@gnus.org
Subject: Re: patch for nnimap.el: make sure mailbox is unselected before deletion
Date: Sun, 15 Jun 2008 18:15:17 +0200	[thread overview]
Message-ID: <v9lk167jze.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <kziqwekbds.fsf@kafka.physik3.gwdg.de> (David Engster's message of "Thu, 12 Jun 2008 15:53:35 +0200")

On Thu, Jun 12 2008, David Engster wrote:

> nnmairix sometimes triggers an error in nnimap when it deletes and
> immediately re-creates a group on the server and checks it for
> mail. nnimap seems to think the mailbox is still selected, leading to a
> "No mailbox selected" error in the imap back end [1]. The following
> patch makes sure the mailbox is unselected before deletion, which
> circumvents this error:
>
> --- nnimap.el   2008-06-10 11:20:33.000000000 +0200
> +++ nnimap-patched.el   2008-06-10 11:13:25.000000000 +0200
> @@ -1609,6 +1609,8 @@
>
>  (deffoo nnimap-request-delete-group (group force &optional server)
>    (when (nnimap-possibly-change-server server)
> +    (when (string= group (imap-current-mailbox nnimap-server-buffer))
> +      (imap-mailbox-unselect nnimap-server-buffer))
>      (with-current-buffer nnimap-server-buffer
>        (if force
>           (or (null (imap-mailbox-status group 'uidvalidity))

Looks correct, so I committed it.  Thanks.

(Next time, please provide a ChangeLog entry.)

> By the way, I tried to post this several times in the last few days via
> Gmane, but it never showed up, so I use mail now. Am I the only one
> having this problem?

I saw this problem as well in the past.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/



  reply	other threads:[~2008-06-15 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 13:53 David Engster
2008-06-15 16:15 ` Reiner Steib [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-12  7:45 David Engster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v9lk167jze.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=deng@randomsample.de \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).