From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67058 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: patch for nnimap.el: make sure mailbox is unselected before deletion Date: Sun, 15 Jun 2008 18:15:17 +0200 Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1213546710 19216 80.91.229.12 (15 Jun 2008 16:18:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Jun 2008 16:18:30 +0000 (UTC) Cc: ding@gnus.org To: David Engster Original-X-From: ding-owner+M15525@lists.math.uh.edu Sun Jun 15 18:19:14 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1K7uwg-0004wK-Er for ding-account@gmane.org; Sun, 15 Jun 2008 18:19:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1K7uuu-0007xD-5o; Sun, 15 Jun 2008 11:17:20 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1K7uus-0007wy-Ux for ding@lists.math.uh.edu; Sun, 15 Jun 2008 11:17:18 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1K7uum-0007Q5-Il for ding@lists.math.uh.edu; Sun, 15 Jun 2008 11:17:18 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1K7uv4-0000OW-00 for ; Sun, 15 Jun 2008 18:17:30 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m5FGH9XN010290; Sun, 15 Jun 2008 18:17:10 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id BDF5B1314B; Sun, 15 Jun 2008 18:17:09 +0200 (CEST) X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T;w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv,vbL^XF1nIp\:F=$Ei2o&mEe:%N~,:3]vtQ~s9u$9izmX$IF@VgGl7/,^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Followup-To: David Engster , ding@gnus.org In-Reply-To: (David Engster's message of "Thu, 12 Jun 2008 15:53:35 +0200") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2.50 (gnu/linux) X-DCC-dmv.com-Metrics: poseidon 1181; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67058 Archived-At: On Thu, Jun 12 2008, David Engster wrote: > nnmairix sometimes triggers an error in nnimap when it deletes and > immediately re-creates a group on the server and checks it for > mail. nnimap seems to think the mailbox is still selected, leading to a > "No mailbox selected" error in the imap back end [1]. The following > patch makes sure the mailbox is unselected before deletion, which > circumvents this error: > > --- nnimap.el 2008-06-10 11:20:33.000000000 +0200 > +++ nnimap-patched.el 2008-06-10 11:13:25.000000000 +0200 > @@ -1609,6 +1609,8 @@ > > (deffoo nnimap-request-delete-group (group force &optional server) > (when (nnimap-possibly-change-server server) > + (when (string= group (imap-current-mailbox nnimap-server-buffer)) > + (imap-mailbox-unselect nnimap-server-buffer)) > (with-current-buffer nnimap-server-buffer > (if force > (or (null (imap-mailbox-status group 'uidvalidity)) Looks correct, so I committed it. Thanks. (Next time, please provide a ChangeLog entry.) > By the way, I tried to post this several times in the last few days via > Gmane, but it never showed up, so I use mail now. Am I the only one > having this problem? I saw this problem as well in the past. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/