From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/62101 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: gnus-group-catchup-current-all fails: gnus-sequence-of-unread-articles Date: Mon, 27 Feb 2006 19:51:49 +0100 Organization: Dept. of Theoretical Physics, University of Ulm Message-ID: Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1141067957 8774 80.91.229.2 (27 Feb 2006 19:19:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Feb 2006 19:19:17 +0000 (UTC) Original-X-From: ding-owner+m10629@lists.math.uh.edu Mon Feb 27 20:19:15 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FDnth-0001Kp-HM for ding-account@gmane.org; Mon, 27 Feb 2006 20:19:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1FDntI-0003uK-00; Mon, 27 Feb 2006 13:18:40 -0600 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1FDnp4-0003uE-00 for ding@lists.math.uh.edu; Mon, 27 Feb 2006 13:14:18 -0600 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1FDnoy-0001yC-Gp for ding@lists.math.uh.edu; Mon, 27 Feb 2006 13:14:18 -0600 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1FDnow-000283-00 for ; Mon, 27 Feb 2006 20:14:10 +0100 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1FDnns-00080Q-Ct for ding@gnus.org; Mon, 27 Feb 2006 20:13:04 +0100 Original-Received: from bridgekeeper.physik.uni-ulm.de ([134.60.10.123]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 27 Feb 2006 20:13:04 +0100 Original-Received: from Reiner.Steib by bridgekeeper.physik.uni-ulm.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 27 Feb 2006 20:13:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org Original-Lines: 79 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: bridgekeeper.physik.uni-ulm.de X-Face: .*T0'iU(sujq_j9\J>-d4fg;N/1++U#U$_5ii6k.=|"-n'?5O:Hyz&wi'-!I~,}7~GgT=0S /&-R5sbkNy5+Xo1y{Tw2KKxi@Xh"g@]Qc|.U<*]WDd)qvGowFDvfU1F]{EDho:7P0@|oOD=Bc{K4?> WP68K[Mx:}=`ZT'6g4'f+g?;`vri2!)xGy}3:=l'(/Cea0l4lo^H5#@/Z3ev Mail-Copies-To: nobody User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:ffyXnrGxV2EFiXXPFGyVdRBZD5k= X-Spam-Score: -2.6 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:62101 Archived-At: Hi, in my Gnus test environment I tried to catchup all groups. It failed on the following group which doesn't exist anymore on the server (local group in leafnode): ,----[ `G E' ] | ;;; Editing the group info for `local.newsletters.test'. | ;; Type `C-c C-c' after you've finished editing. | | ("local.newsletters.test" 6 | ((1 . 292)) | nil) `---- ,----[ Debugger output with patch[1] ] | Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) | <(293 nil) | (cond ((< first last) (push ... unread)) ((= first last) (push first unread))) | (let* ((read ...) (active ...) (last ...) first nlast unread) | (gnus-message 1 "RS: group=%s\nRS: read=%s active=%s last=%s" | group read active last) (if (not read) (setq first ...) (if | ... ... ... ...)) (gnus-message 1 "RS: first=%s last=%s" first last) | (cond (... ...) (... ...)) (delq 0 (nreverse unread))) | gnus-sequence-of-unread-articles("local.newsletters.test") | gnus-group-catchup("local.newsletters.test" all) | gnus-group-catchup-current(nil all) | gnus-group-catchup-current-all(nil) | call-interactively(gnus-group-catchup-current-all) `---- The problem is that the code in `gnus-sequence-of-unread-articles' doesn't ensure that `first' and `last' are both numbers: ,----[ M-: (gnus-sequence-of-unread-articles "local.test") RET with [1] ] | gnus-sequence-of-unread-articles | RS: group=local.newsletters.test | RS: read=((1 . 292)) active=nil last=nil | RS: first=293 last=nil | Entering debugger... `---- What value should `gnus-sequence-of-unread-articles' return in such a situation? *time passes* After a little testing, I conclude that it should return `nil'. Fixed in CVS. Bye, Reiner. [1] --8<---------------cut here---------------start------------->8--- --- gnus-sum.el 23 Feb 2006 20:30:28 -0000 7.117 +++ gnus-sum.el 27 Feb 2006 18:05:11 -0000 @@ -6626,6 +6626,8 @@ (active (or (gnus-active group) (gnus-activate-group group))) (last (cdr active)) first nlast unread) + (gnus-message 1 "RS: group=%s\nRS: read=%s active=%s last=%s" + group read active last) ;; If none are read, then all are unread. (if (not read) (setq first (car active)) @@ -6648,6 +6650,8 @@ (setq first (1+ (if (atom (car read)) (car read) (cdar read)))) (setq nlast (if (atom (cadr read)) (cadr read) (caadr read))) (setq read (cdr read))))) + ;; FIXME: Make sure that first and last are integers (non-nil). + (gnus-message 1 "RS: first=%s last=%s" first last) ;; And add the last unread articles. (cond ((< first last) (push (cons first last) unread)) --8<---------------cut here---------------end--------------->8--- -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/