[PATCH] cvs 2005-10-29 score-mode.el::defvar gnus-score-edit-done-hook

[PATCH] cvs 2005-10-29 score-mode.el::defvar gnus-score-edit-done-hook

[Jari Aalto]

Here is small fix.
gnus-score.el:2392:    (run-hooks 'gnus-score-edit-done-hook)))

2005-10-29  Jari Aalto  <jari aalto A T cante net>

        * score-mode.el (gnus-score-edit-done-hook): Introduce variable.
        Used in gnus-score.el.

Index: score-mode.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/score-mode.el,v
retrieving revision 7.7
diff -u -IId: -b -w -u -r7.7 score-mode.el
--- score-mode.el       26 Aug 2005 00:05:02 -0000      7.7
+++ score-mode.el       29 Oct 2005 07:21:46 -0000
@@ -31,6 +31,9 @@
 (require 'mm-util)                     ; for mm-universal-coding-system
 (require 'gnus-util)                   ; for gnus-pp, gnus-run-mode-hooks
 
+(defvar gnus-score-edit-done-hook  nil
+  "*Hook run at the end of closing the score buffer.")
+
 (defvar gnus-score-mode-hook nil
   "*Hook run in score mode buffers.")
 

Re: [PATCH] cvs 2005-10-29 score-mode.el::defvar gnus-score-edit-done-hook

[Simon Josefsson]

Jari Aalto <jari.aalto@cante.net> writes:

> 2005-10-29  Jari Aalto  <jari aalto A T cante net>
>
>         * score-mode.el (gnus-score-edit-done-hook): Introduce variable.
>         Used in gnus-score.el.
...
> 2005-10-29 Sat  Jari Aalto  <jari dot aalto A T cante dot net>
>
>         (gnus-article-sort-by-date-reverse): 7.101 New function.
...
> See my previous patch. Here is documentation to go with it.

Thanks, installed!

Re: [PATCH] cvs 2005-10-29 score-mode.el::defvar

[Dan Christensen]

Simon Josefsson <jas@extundo.com> writes:

> Jari Aalto <jari.aalto@cante.net> writes:
>
>> 2005-10-29 Sat  Jari Aalto  <jari dot aalto A T cante dot net>
>>
>>         (gnus-article-sort-by-date-reverse): 7.101 New function.
> ...
>> See my previous patch. Here is documentation to go with it.
>
> Thanks, installed!

Can't one reverse any sort function by using a construct like 
(not gnus-article-sort-by-date) [from memory]?

Dan

Re: [PATCH] cvs 2005-10-29 score-mode.el::defvar

[Jari Aalto]

| >> 2005-10-29 Sat  Jari Aalto  <jari dot aalto A T cante dot net>
| >>
| >>         (gnus-article-sort-by-date-reverse): 7.101 New function.
| > ...
| >> See my previous patch. Here is documentation to go with it.
| >
| > Thanks, installed!
| 
| Can't one reverse any sort function by using a construct like 
| (not gnus-article-sort-by-date) [from memory]?

If you refer to hook, then a lambda would do. But that would be ugly -
and remove-hook couldn't be used. A function is much cleaner.

Jari

Re: [PATCH] cvs 2005-10-29 score-mode.el::defvar

[Dan Christensen]

Jari Aalto <jari.aalto@cante.net> writes:

> Dan Christensen wrote:
> 
> | > 2005-10-29 Sat  Jari Aalto  <jari dot aalto A T cante dot net>
> | >
> | >         (gnus-article-sort-by-date-reverse): 7.101 New function.
> | 
> | Can't one reverse any sort function by using a construct like 
> | (not gnus-article-sort-by-date) [from memory]?
>
> If you refer to hook, then a lambda would do. But that would be ugly -
> and remove-hook couldn't be used. A function is much cleaner.

I don't see how a lambda would be needed.  Here's an example from
the sorting section of the info documentation.  

     (setq gnus-thread-sort-functions
           '(gnus-thread-sort-by-number
             gnus-thread-sort-by-subject
             (not gnus-thread-sort-by-total-score)))

The same construct works for gnus-article-sort-functions too.

Following your reasoning, one should add reversed versions of all the
gnus-article-sort* and gnus-thread-sort* functions, but we don't do
this because we have a general purpose way to specify reversed
sorting.

Or am I misunderstanding what your function would be used for?

Dan

Re: [PATCH] cvs 2005-10-29 score-mode.el::defvar

[Simon Josefsson]

>> If you refer to hook, then a lambda would do. But that would be ugly -
>> and remove-hook couldn't be used. A function is much cleaner.
>
> I don't see how a lambda would be needed.  Here's an example from
> the sorting section of the info documentation.
>
>      (setq gnus-thread-sort-functions
>            '(gnus-thread-sort-by-number
>              gnus-thread-sort-by-subject
>              (not gnus-thread-sort-by-total-score)))
>
> The same construct works for gnus-article-sort-functions too.

I'm inclined to agree, I think we should revert that part of the patch. 
Let's wait if we both misunderstood what the function would be used for.

gnus-article-sort-*-reverse (was: [PATCH] cvs 2005-10-29 score-mode.el::defvar)

[Reiner Steib]

On Wed, Nov 02 2005, Simon Josefsson wrote:

>>      (setq gnus-thread-sort-functions
>>            '(gnus-thread-sort-by-number
>>              gnus-thread-sort-by-subject
>>              (not gnus-thread-sort-by-total-score)))
>>
>> The same construct works for gnus-article-sort-functions too.
>
> I'm inclined to agree, I think we should revert that part of the patch. 
> Let's wait if we both misunderstood what the function would be used for.

I don't see convincing arguments for gnus-article-sort-*-reverse
functions.  I'd vote for removing `gnus-article-sort-by-date-reverse'.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: gnus-article-sort-*-reverse

[Romain Francoise]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> I don't see convincing arguments for gnus-article-sort-*-reverse
> functions.  I'd vote for removing `gnus-article-sort-by-date-reverse'.

I'd vote against removing it: I've had such a function in my local
config for years, and I think it's useful.

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: gnus-article-sort-*-reverse

[Reiner Steib]

On Tue, Nov 08 2005, Romain Francoise wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> I don't see convincing arguments for gnus-article-sort-*-reverse
>> functions.  I'd vote for removing `gnus-article-sort-by-date-reverse'.
>
> I'd vote against removing it: I've had such a function in my local
> config for years, and I think it's useful.

What's wrong with `(not gnus-article-sort-by-date)'
or `C-u C-c C-s C-d' (`C-u M-x gnus-summary-sort-by-date RET')?

*If* gnus-article-sort-*-reverse would make sense, *-reverse should be
*provided for all gnus-article-sort-* functions.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: gnus-article-sort-*-reverse

[Romain Francoise]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> What's wrong with `(not gnus-article-sort-by-date)'
> or `C-u C-c C-s C-d' (`C-u M-x gnus-summary-sort-by-date RET')?

The former doesn't work when you set `gnus-article-sort-functions' via
group parameters.  For some reason.

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Group parameters and `(not gnus-article-sort-by-date)' (was: gnus-article-sort-*-reverse)

[Reiner Steib]

On Tue, Nov 08 2005, Romain Francoise wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> What's wrong with `(not gnus-article-sort-by-date)'
>> or `C-u C-c C-s C-d' (`C-u M-x gnus-summary-sort-by-date RET')?
>
> The former doesn't work when you set `gnus-article-sort-functions' via
> group parameters.  For some reason.

Then this should be fixed.  Hm, I have the following in my setup and
it works fine:

(setq
 gnus-parameters
 '(("local\\.newsletters\\.heise"
    (gnus-show-threads nil)
    (gnus-article-sort-functions '((not gnus-article-sort-by-number))))))

Could you give a precise recipe, please?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Group parameters and `(not gnus-article-sort-by-date)'

[Romain Francoise]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> Could you give a precise recipe, please?

Hmm... now that I try again, it works.  I'm pretty sure it didn't a few
years back.

No objection to remove this function, then.  :-)

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: Group parameters and `(not gnus-article-sort-by-date)'

[Simon Josefsson]

Romain Francoise <romain@orebokech.com> writes:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> Could you give a precise recipe, please?
>
> Hmm... now that I try again, it works.  I'm pretty sure it didn't a few
> years back.
>
> No objection to remove this function, then.  :-)

I removed it.

Re: Group parameters and `(not gnus-article-sort-by-date)'

[Reiner Steib]

On Wed, Nov 09 2005, Simon Josefsson wrote:

[ `gnus-article-sort-by-date-reverse' ]
> I removed it.

Thanks.

It's also mentioned in the patch to gnus.texi:

,----
| @lisp
| (require 'cl)
| (defun my-gnus-summary-mode-hook-group-select ()
|   (flet ((lsetq (x val) ;; Local setq
|                 (set (make-local-variable x) val)))
|     (cond
|      ;;  In Group buffer to make Debian daily news group press: G m
|      ;;  and point it to nntp server news.gmane.org and
|      ;;  group gmane.linux.debian.user.news
|      ((string-match "nntp.*debian.user.news" gnus-newsgroup-name)
|       (lsetq 'gnus-show-threads nil)
|       (lsetq 'gnus-article-sort-functions 'gnus-article-sort-by-date-reverse)
|       (lsetq 'gnus-use-adaptive-scoring nil)
|       (lsetq 'gnus-use-scoring nil))
|      ;;  In Group buffer to read Debian weekly news RSS feed press: G R
|      ;;  and point it to url:
|      ;;  http://packages.debian.org/unstable/newpkg_main.en.rdf
|      ((string-match "nnrss.*debian" gnus-newsgroup-name)
|       (lsetq 'gnus-show-threads nil)
|       (lsetq 'gnus-article-sort-functions 'gnus-article-sort-by-subject)
|       (lsetq 'gnus-use-adaptive-scoring nil)
|       (lsetq 'gnus-use-scoring t)
|       (lsetq 'gnus-score-find-score-files-function 'gnus-score-find-single)
|       (lsetq 'gnus-summary-line-format "%U%R%z%d %I%(%[ %s %]%)\n")))))
| (defun my-gnus-summary-mode-hook  ()
|   (my-gnus-summary-mode-hook-group-select))
| @end lisp
`----

If I understand this code correctly, it could be replaced by an
example in (info "(gnus)Group Parameters"):

  ("nntp.*debian.user.news"
   (gnus-show-threads nil)
   (gnus-article-sort-functions '((not gnus-article-sort-by-date)))
   (gnus-use-adaptive-scoring nil)
   (gnus-use-scoring nil))
  ("nnrss.*debian"
   (gnus-show-threads nil)
   (gnus-article-sort-functions 'gnus-article-sort-by-subject)
   (gnus-use-adaptive-scoring nil)
   (gnus-use-scoring t)
   (gnus-score-find-score-files-function 'gnus-score-find-single)
   (gnus-summary-line-format "%U%R%z%d %I%(%[ %s %]%)\n")

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Group parameters and `(not gnus-article-sort-by-date)'

[Henrik Enberg]

> From:  Reiner Steib <reinersteib+gmane@imap.cc>
> Date:  Wed, 09 Nov 2005 18:17:59 +0100

> It's also mentioned in the patch to gnus.texi:
> 
> |   (flet ((lsetq (x val) ;; Local setq
> |                 (set (make-local-variable x) val)))

Why's it called `lsetq' when it isn't quoted?

Re: Group parameters and `(not gnus-article-sort-by-date)'

[Reiner Steib]

On Wed, Nov 09 2005, Henrik Enberg wrote:

> Why's it called `lsetq' when it isn't quoted?

Don't ask me.  I proposed to remove it.  ;-)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Group parameters and `(not gnus-article-sort-by-date)'

[Simon Josefsson]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Wed, Nov 09 2005, Simon Josefsson wrote:
>
> [ `gnus-article-sort-by-date-reverse' ]
>> I removed it.
>
> Thanks.
>
> It's also mentioned in the patch to gnus.texi:

Could you propose a patch?  Should we simply revert the patch, or
can we improve it somehow.

> ,----
> | @lisp
> | (require 'cl)
> | (defun my-gnus-summary-mode-hook-group-select ()
> |   (flet ((lsetq (x val) ;; Local setq
> |                 (set (make-local-variable x) val)))
> |     (cond
> |      ;;  In Group buffer to make Debian daily news group press: G m
> |      ;;  and point it to nntp server news.gmane.org and
> |      ;;  group gmane.linux.debian.user.news
> |      ((string-match "nntp.*debian.user.news" gnus-newsgroup-name)
> |       (lsetq 'gnus-show-threads nil)
> |       (lsetq 'gnus-article-sort-functions 'gnus-article-sort-by-date-reverse)
> |       (lsetq 'gnus-use-adaptive-scoring nil)
> |       (lsetq 'gnus-use-scoring nil))
> |      ;;  In Group buffer to read Debian weekly news RSS feed press: G R
> |      ;;  and point it to url:
> |      ;;  http://packages.debian.org/unstable/newpkg_main.en.rdf
> |      ((string-match "nnrss.*debian" gnus-newsgroup-name)
> |       (lsetq 'gnus-show-threads nil)
> |       (lsetq 'gnus-article-sort-functions 'gnus-article-sort-by-subject)
> |       (lsetq 'gnus-use-adaptive-scoring nil)
> |       (lsetq 'gnus-use-scoring t)
> |       (lsetq 'gnus-score-find-score-files-function 'gnus-score-find-single)
> |       (lsetq 'gnus-summary-line-format "%U%R%z%d %I%(%[ %s %]%)\n")))))
> | (defun my-gnus-summary-mode-hook  ()
> |   (my-gnus-summary-mode-hook-group-select))
> | @end lisp
> `----
>
> If I understand this code correctly, it could be replaced by an
> example in (info "(gnus)Group Parameters"):
>
>   ("nntp.*debian.user.news"
>    (gnus-show-threads nil)
>    (gnus-article-sort-functions '((not gnus-article-sort-by-date)))
>    (gnus-use-adaptive-scoring nil)
>    (gnus-use-scoring nil))
>   ("nnrss.*debian"
>    (gnus-show-threads nil)
>    (gnus-article-sort-functions 'gnus-article-sort-by-subject)
>    (gnus-use-adaptive-scoring nil)
>    (gnus-use-scoring t)
>    (gnus-score-find-score-files-function 'gnus-score-find-single)
>    (gnus-summary-line-format "%U%R%z%d %I%(%[ %s %]%)\n")
>
> Bye, Reiner.
> -- 
>        ,,,
>       (o o)
> ---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Group parameters and `(not gnus-article-sort-by-date)'

[Reiner Steib]

On Thu, Nov 10 2005, Simon Josefsson wrote:

> Could you propose a patch?  Should we simply revert the patch, or
> can we improve it somehow.

I think of installing the example in (info "(gnus)Group Parameters")
(see previous message) along with a hint (and reference), that special
sorting in some groups can be achieved via group parameters.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Group parameters and `(not gnus-article-sort-by-date)'

[Reiner Steib]

On Thu, Nov 10 2005, Reiner Steib wrote:

> I think of installing the example in (info "(gnus)Group Parameters")
> (see previous message) along with a hint (and reference), that special
> sorting in some groups can be achieved via group parameters.

Committed [1].  Feel free to adjust/improve.

Hm, as the additions don't use new features, I should probably install
it in v5-10 too.

Bye, Reiner.

[1] <E1EaGCa-0005VO-00@quimby.gnus.org>
    http://mid.gmane.org/E1EaGCa-0005VO-00%40quimby.gnus.org
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/