Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de>
Subject: Re: spam.el calls spam registration routines even if no spam marked
Date: Thu, 27 May 2004 13:26:33 +0200	[thread overview]
Message-ID: <v9lljep0uu.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <8765ainwe5.fsf@enki.rimspace.net>

On Thu, May 27 2004, Daniel Pittman wrote:

> One of the things that bemused me when dealing with spam.el was that it
> calls the spam registration routine for the selected group even if there
> are no spam articles in that group.
>
> The attached patch avoids calling down into the underlying registration
> routine unless there is actually something to do.

I have a (probably similar) uncommitted patch here.

Before I install it, I have some questions related to this issue:

- Is it intented that `spam.el' sometimes talks about "messages" and
  sometimes about "articles"?  If not, I think we should use always
  use "articles".

- Should we care for singular/plural?

  "1 spam messages are marked as expired and moved to nil" :-/

  Should we just write "1 spam message(s) marked" or use some
  conditional?

- "and moved to nil"?  This happens in Gmane groups for me.  If groups
  is nil, we should drop this part of the sentence.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/




  reply	other threads:[~2004-05-27 11:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-27  7:48 spam.el calls spam registration routines even if no spam marked articles exist Daniel Pittman
2004-05-27 11:26 ` Reiner Steib [this message]
2004-05-27 14:30   ` spam.el calls spam registration routines even if no spam marked Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v9lljep0uu.fsf@marauder.physik.uni-ulm.de \
    --to=4.uce.03.r.s@nurfuerspam.de \
    --cc=reiner.steib@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).