From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/57748 Path: main.gmane.org!not-for-mail From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de> Newsgroups: gmane.emacs.gnus.general Subject: Re: spam.el calls spam registration routines even if no spam marked Date: Thu, 27 May 2004 13:26:33 +0200 Organization: Dept. of Theoretical Physics, University of Ulm Sender: ding-owner@lists.math.uh.edu Message-ID: References: <8765ainwe5.fsf@enki.rimspace.net> Reply-To: Reiner Steib NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1085657437 796 80.91.224.253 (27 May 2004 11:30:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 27 May 2004 11:30:37 +0000 (UTC) Original-X-From: ding-owner+M6289=ding+2Daccount=gmane.org@lists.math.uh.edu Thu May 27 13:30:25 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BTJ5d-0005gB-00 for ; Thu, 27 May 2004 13:30:25 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1BTJ5c-0002kJ-02 for ding-account@gmane.org; Thu, 27 May 2004 06:30:24 -0500 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1BTJ5R-0002k9-00 for ding@lists.math.uh.edu; Thu, 27 May 2004 06:30:13 -0500 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by util2.math.uh.edu with esmtp (Exim 4.30) id 1BTJ5P-00089c-PO for ding@lists.math.uh.edu; Thu, 27 May 2004 06:30:11 -0500 Original-Received: from main.gmane.org (main.gmane.org [80.91.224.249]) by justine.libertine.org (Postfix) with ESMTP id 8FEC33A003C for ; Thu, 27 May 2004 06:30:10 -0500 (CDT) Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1BTJ5N-0003Q1-00 for ; Thu, 27 May 2004 13:30:09 +0200 Original-Received: from lumberjack.physik.uni-ulm.de ([134.60.10.173]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 27 May 2004 13:30:08 +0200 Original-Received: from reiner.steib by lumberjack.physik.uni-ulm.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 27 May 2004 13:30:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org Original-Lines: 32 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: lumberjack.physik.uni-ulm.de X-Face: P05mdcZT&lL[-s2=mw~RsllZ0zZAb?vdE}.s One of the things that bemused me when dealing with spam.el was that it > calls the spam registration routine for the selected group even if there > are no spam articles in that group. > > The attached patch avoids calling down into the underlying registration > routine unless there is actually something to do. I have a (probably similar) uncommitted patch here. Before I install it, I have some questions related to this issue: - Is it intented that `spam.el' sometimes talks about "messages" and sometimes about "articles"? If not, I think we should use always use "articles". - Should we care for singular/plural? "1 spam messages are marked as expired and moved to nil" :-/ Should we just write "1 spam message(s) marked" or use some conditional? - "and moved to nil"? This happens in Gmane groups for me. If groups is nil, we should drop this part of the sentence. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- PGP key available via WWW http://rsteib.home.pages.de/