Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de>
Subject: gnus-xmas-format in ~/.newsrc.eld
Date: Wed, 23 Apr 2003 15:17:42 +0200	[thread overview]
Message-ID: <v9lly1mjyh.fsf@marauder.physik.uni-ulm.de> (raw)

Hi,

when using Oort with XEmacs, the following gets written to
~/.newsrc.eld:

,----
| (setq
|  gnus-format-specs
|  '((article-mode "Gnus: %g [%w] %S%m"
| 		 (concat (gnus-xmas-format "Gnus: %s [%s] %s%s" ...)))))
`----

When a user wants to switch back to Gnus 5.8.8 (e.g. to see if some
bug has been introduced in Oort), displaying articles fails, because
`gnus-xmas-format' isn't bound.

Couldn't we (defalias 'gnus-xmas-format 'format) in this case?

--8<---------------cut here---------------start------------->8---
--- lisp/gnus-start.el	5 Apr 2003 05:40:29 -0000	6.72
+++ lisp/gnus-start.el	23 Apr 2003 13:19:12 -0000
@@ -460,6 +460,12 @@
 ;; Byte-compiler warning.
 (defvar gnus-group-line-format)
 
+(defvar gnus-newsrc-gnus-compatibility
+  (concat "(unless (fboundp 'gnus-xmas-format)\n"
+	  "  (defalias 'gnus-xmas-format 'format))\n")
+  "String added to `~/.newsrc.eld' for compatibility.
+Must be a valid lisp expression.")
+
 ;; Suggested by Brian Edmonds <edmonds@cs.ubc.ca>.
 (defvar gnus-init-inhibit nil)
 (defun gnus-read-init-file (&optional inhibit-next)
@@ -2641,6 +2647,8 @@
     (princ "(setq gnus-newsrc-file-version ")
     (princ (gnus-prin1-to-string gnus-version))
     (princ ")\n")
+    (when (stringp gnus-newsrc-gnus-compatibility)
+      (insert gnus-newsrc-gnus-compatibility))
     (let* ((print-quoted t)
            (print-readably t)
            (print-escape-multibyte nil)
--8<---------------cut here---------------end--------------->8---

Is there a better name instead of `gnus-newsrc-gnus-compatibility'?

I'm using `defvar' (and not `defcustom') on purpose, because I don't
think it should be customizable.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/




             reply	other threads:[~2003-04-23 13:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-23 13:17 Reiner Steib [this message]
2003-04-23 14:18 ` Simon Josefsson
2003-04-23 18:06   ` Reiner Steib
2003-04-23 20:10     ` Simon Josefsson
2003-04-23 21:05       ` Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v9lly1mjyh.fsf@marauder.physik.uni-ulm.de \
    --to=4.uce.03.r.s@nurfuerspam.de \
    --cc=reiner.steib@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).