Re: Integration of nnmairix.el

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Tue, Jan 08 2008, David wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> Could you please send the current version of `nnmairix.el' to the list
>> for review?  
>
> It's attached to this mail.

Thanks.  I added the version 0.5 from the emacswiki now.  Sorry for
the delay.

>> I didn't look into it in detail, but at least the
>> following items need to be addressed:
>>
>> - Documentation.  Minimally the content from
>>   <http://www.emacswiki.org/cgi-bin/wiki/GnusMairix> should be
>>   converted to texinfo to fit into `texi/gnus.texi'.
>
> OK, I'll do that.

>> - Key bindings:
>>
>>   · Some of the summary mode bindings (`S ...') are already taken
>>     (S t, S f, S m).  Or are these only active in nnmairix groups?
>
> No. Since these are commands which create search commands based on the
> current article they should work in every group. I somehow overlooked
> that these bindings are already taken. 

I don't really like the use of `$ ...' in `nnmairix-summary-mode-hook'.

>>   · The Group mode prefix `G b' is available.  But maybe there's a
>>     better one (I don't know).  Maybe we should arrange that the group
>>     mode bindings are only done if the user wants to use nnmairix?
>
> Yes, I guess that's reasonable since those bindings are useless without
> a working mairix installation, 

We also want to install nnir.el soon.  nnir.el uses `G G' (only a
single binding).  (And there's contrib/gnus-namazu.el which uses `C-c
C-n' when `gnus-namazu-insinuate' is called).  Maybe we should think
about using some two key stroke prefix for mail search facilities (I'm
not sure if it makes sense to use nnir.el and nnmairix.el at the same
time).

For the Group mode, we could use e.g. `G b', `G B' or `G G' as prefix
for (mail) search.  In the Summary mode, we may use the same prefix or
a different one.  I don't have a strong opinion on this.  (`G b' runs
`gnus-summary-best-unread-article', but it is also on `,', so we may
steal this or move it to `G B'.)  Opinions?

> so maybe users should have to explicitly put (require 'nnmairix)
> into their .gnus for activating them.

Loading a package should not perform changes like this.  There should
be an autoloaded initialization function instead.  (If detecting a
working mairix installation is possible, we could install it from
`gnus.el'/`gnus-start.el' depending on the result.)

>> - Doc strings:
>>
>>   Some of the doc strings don't follow the Emacs conventions.  See
>>   `M-x checkdoc RET'.
>>
>> - The defcustoms need a :version tag:
>>   :version "23.0" ;; No Gnus
>
> I fixed that.

Thanks.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/