From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66358 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: Integration of nnmairix.el Date: Tue, 26 Feb 2008 23:20:33 +0100 Message-ID: References: <87ve65usi5.fsf@arcor.de> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1204064528 3146 80.91.229.12 (26 Feb 2008 22:22:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Feb 2008 22:22:08 +0000 (UTC) Cc: ding@gnus.org To: David Original-X-From: ding-owner+M14848@lists.math.uh.edu Tue Feb 26 23:22:33 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1JU8Bl-0008Ss-Db for ding-account@gmane.org; Tue, 26 Feb 2008 23:22:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1JU8Ak-0002Rc-Dw; Tue, 26 Feb 2008 16:21:14 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1JU8Ai-0002RF-RO for ding@lists.math.uh.edu; Tue, 26 Feb 2008 16:21:12 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1JU8Ac-0005rX-01 for ding@lists.math.uh.edu; Tue, 26 Feb 2008 16:21:12 -0600 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1JU8Ah-0002LA-00 for ; Tue, 26 Feb 2008 23:21:11 +0100 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m1QML3B7012428; Tue, 26 Feb 2008 23:21:03 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 08DA112FC0; Tue, 26 Feb 2008 23:21:03 +0100 (CET) X-Face: .*T0'iU(sujq_j9\J>-d4fg;N/1++U#U$_5ii6k.=|"-n'?5O:Hyz&wi'-!I~,}7~GgT=0S /&-R5sbkNy5+Xo1y{Tw2KKxi@Xh"g@]Qc|.U<*]WDd)qvGowFDvfU1F]{EDho:7P0@|oOD=Bc{K4?> WP68K[Mx:}=`ZT'6g4'f+g?;`vri2!)xGy}3:=l'(/Cea0l4lo^H5#@/Z3ev Mail-Followup-To: David , ding@gnus.org In-Reply-To: <87ve65usi5.fsf@arcor.de> (David's message of "Tue, 08 Jan 2008 00:26:42 +0100") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.90 (gnu/linux) X-DCC-URT-Metrics: poseidon 1060; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-MIME-Autoconverted: from 8bit to quoted-printable by mail.uni-ulm.de id m1QML3B7012428 X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66358 Archived-At: On Tue, Jan 08 2008, David wrote: > Reiner Steib writes: >> Could you please send the current version of `nnmairix.el' to the list >> for review? =20 > > It's attached to this mail. Thanks. I added the version 0.5 from the emacswiki now. Sorry for the delay. >> I didn't look into it in detail, but at least the >> following items need to be addressed: >> >> - Documentation. Minimally the content from >> should be >> converted to texinfo to fit into `texi/gnus.texi'. > > OK, I'll do that. >> - Key bindings: >> >> =B7 Some of the summary mode bindings (`S ...') are already taken >> (S t, S f, S m). Or are these only active in nnmairix groups? > > No. Since these are commands which create search commands based on the > current article they should work in every group. I somehow overlooked > that these bindings are already taken.=20 I don't really like the use of `$ ...' in `nnmairix-summary-mode-hook'. >> =B7 The Group mode prefix `G b' is available. But maybe there's a >> better one (I don't know). Maybe we should arrange that the group >> mode bindings are only done if the user wants to use nnmairix? > > Yes, I guess that's reasonable since those bindings are useless without > a working mairix installation,=20 We also want to install nnir.el soon. nnir.el uses `G G' (only a single binding). (And there's contrib/gnus-namazu.el which uses `C-c C-n' when `gnus-namazu-insinuate' is called). Maybe we should think about using some two key stroke prefix for mail search facilities (I'm not sure if it makes sense to use nnir.el and nnmairix.el at the same time). For the Group mode, we could use e.g. `G b', `G B' or `G G' as prefix for (mail) search. In the Summary mode, we may use the same prefix or a different one. I don't have a strong opinion on this. (`G b' runs `gnus-summary-best-unread-article', but it is also on `,', so we may steal this or move it to `G B'.) Opinions? > so maybe users should have to explicitly put (require 'nnmairix) > into their .gnus for activating them. Loading a package should not perform changes like this. There should be an autoloaded initialization function instead. (If detecting a working mairix installation is possible, we could install it from `gnus.el'/`gnus-start.el' depending on the result.) >> - Doc strings: >> >> Some of the doc strings don't follow the Emacs conventions. See >> `M-x checkdoc RET'. >> >> - The defcustoms need a :version tag: >> :version "23.0" ;; No Gnus > > I fixed that. Thanks. Bye, Reiner. --=20 ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/