Improve handling of message/external-body

Improve handling of message/external-body

[Katsumi Yamaoka]

Hi,

I found there are several problems concerned with externalized
MIME parts that I made performing the `C-o' command on ordinary
MIME parts.

1. Each time I type the RET key, displaying of inlinable parts,
   e.g. text/plain parts, isn't toggled.

2. Displaying of inlined images cannot be turned off using the
   RET key.

3. Several MIME part commands, e.g. `i',`o', `|', etc. pass only
   headers of the externalized parts to the destinations (e.g.
   buffer, file, command).

4. When saving a not inlinable part to a file, the default file
   name isn't offered.

Fixed in the trunk and the v5-10 branch.

Re: Improve handling of message/external-body

[Katsumi Yamaoka]

>>>>> In <b4moe05z6z4.fsf@jpl.org> Katsumi Yamaoka wrote:

> I found there are several problems concerned with externalized
> MIME parts that I made performing the `C-o' command on ordinary
> MIME parts.

I've fixed some residual minor bugs concerned with the handling
of message/external-body parts.

In addition, I've merged the changes to rfc2231.el that Kenichi
Handa made in the Emacs CVS.  I've also fixed a bug in which the
first part of a digest message (which is made by performing the
'C-c C-f' command on two or more articles) will be broken if
there's non-ASCII text.

* trunk and v5-10 branch *

rfc2231.el changes (was: Improve handling of message/external-body)

[Reiner Steib]

On Wed, Apr 12 2006, Katsumi Yamaoka wrote:

>>>>>> In <b4moe05z6z4.fsf@jpl.org> Katsumi Yamaoka wrote:
>
>> I found there are several problems concerned with externalized
>> MIME parts that I made performing the `C-o' command on ordinary
>> MIME parts.
>
> I've fixed some residual minor bugs concerned with the handling
> of message/external-body parts.
>
> In addition, I've merged the changes to rfc2231.el that Kenichi
> Handa made in the Emacs CVS.
[...]
> * trunk and v5-10 branch *

I've adjusted the corresponding ChangeLog entries (date, ...) which
were a bit messed up.

The versions of `rfc2231.el' in v5-10 and Emacs are in sync now.
However there are two differences to the trunk version.  vc-annotate
shows that you worked on this code (on 16-Feb-06).  Could you sync the
code if appropriate, please?  Hm, maybe it's because older Emacsen
don't support shy groups correctly?

--8<---------------cut here---------------start------------->8---
--- rfc2231.el	12 Apr 2006 02:00:40 -0000	6.11.2.14
+++ rfc2231.el	12 Apr 2006 02:00:49 -0000	7.15
@@ -81,8 +81,8 @@
 		;; Finally, attempt to extract only type.
 		(if (string-match
 		     (concat "\\`[\t\n ]*\\([^" ietf-drums-tspecials "\t\n ]+"
-			     "\\(/[^" ietf-drums-tspecials
-			     "\t\n ]+\\)?\\)\\([\t\n ;]\\|\\'\\)")
+			     "\\(?:/[^" ietf-drums-tspecials
+			     "\t\n ]+\\)?\\)\\(?:[\t\n ;]\\|\\'\\)")
 		     string)
 		    (match-string 1 string)
 		  ""))))))
@@ -223,10 +223,10 @@
  \"'en-us'This%20is%20%2A%2A%2Afun%2A%2A%2A\",
  \"''This%20is%20%2A%2A%2Afun%2A%2A%2A\", or
  \"This is ***fun***\"."
-  (string-match "\\`\\(\\([^']+\\)?'\\([^']+\\)?'\\)?\\(.+\\)" string)
-  (let ((coding-system (mm-charset-to-coding-system (match-string 2 string)))
-	;;(language (match-string 3 string))
-	(value (match-string 4 string)))
+  (string-match "\\`\\(?:\\([^']+\\)?'\\([^']+\\)?'\\)?\\(.+\\)" string)
+  (let ((coding-system (mm-charset-to-coding-system (match-string 1 string)))
+	;;(language (match-string 2 string))
+	(value (match-string 3 string)))
     (mm-with-unibyte-buffer
       (insert value)
       (goto-char (point-min))
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: rfc2231.el changes

[Katsumi Yamaoka]

>>>>> In <v9u08z6jrm.fsf_-_@marauder.physik.uni-ulm.de> 
>>>>>	Reiner Steib <reinersteib+gmane@imap.cc> wrote:

> On Wed, Apr 12 2006, Katsumi Yamaoka wrote:

>> In addition, I've merged the changes to rfc2231.el that Kenichi
>> Handa made in the Emacs CVS.
> [...]
>> * trunk and v5-10 branch *

> I've adjusted the corresponding ChangeLog entries (date, ...) which
> were a bit messed up.

Thanks.

> The versions of `rfc2231.el' in v5-10 and Emacs are in sync now.
> However there are two differences to the trunk version.  vc-annotate
> shows that you worked on this code (on 16-Feb-06).  Could you sync the
> code if appropriate, please?  Hm, maybe it's because older Emacsen
> don't support shy groups correctly?

> --- rfc2231.el	12 Apr 2006 02:00:40 -0000	6.11.2.14
> +++ rfc2231.el	12 Apr 2006 02:00:49 -0000	7.15
[...]
> -  (string-match "\\`\\(\\([^']+\\)?'\\([^']+\\)?'\\)?\\(.+\\)" string)
> -  (let ((coding-system (mm-charset-to-coding-system (match-string 2 string)))
> -	;;(language (match-string 3 string))
> -	(value (match-string 4 string)))
> +  (string-match "\\`\\(?:\\([^']+\\)?'\\([^']+\\)?'\\)?\\(.+\\)" string)
> +  (let ((coding-system (mm-charset-to-coding-system (match-string 1 string)))
> +	;;(language (match-string 2 string))
> +	(value (match-string 3 string)))
[...]

Yes, Emacs 20 doesn't support shy groups.  Well, should we not
use shy groups in all Gnus modules (even in the trunk)?  Such
differences I made are not only in rfc2231.el but also in the
other modules, e.g., rfc2047.el.  I'm not very much positive to
remove them even if a lowering of performance by not using shy
groups is a little.  If anything, isn't it better to drop Emacs
20?

Re: rfc2231.el changes

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Yes, Emacs 20 doesn't support shy groups.  Well, should we not
> use shy groups in all Gnus modules (even in the trunk)?  Such
> differences I made are not only in rfc2231.el but also in the
> other modules, e.g., rfc2047.el.  I'm not very much positive to
> remove them even if a lowering of performance by not using shy
> groups is a little.  If anything, isn't it better to drop Emacs
> 20?

Yes, I think so.  I think it makes sense to concentrate on Emacs
21/22/(23 :-) and XEmacs 21+ for No Gnus.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Emacs 20.7 compatibility in v5-10 (was: rfc2231.el changes)

[Reiner Steib]

On Thu, Apr 13 2006, Lars Magne Ingebrigtsen wrote:

> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>> Yes, Emacs 20 doesn't support shy groups.  [...]  If anything,
>> isn't it better to drop Emacs 20?
>
> Yes, I think so.  I think it makes sense to concentrate on Emacs
> 21/22/(23 :-) and XEmacs 21+ for No Gnus.

Sure.  We already dropped everything older than Emacs 21 and XEmacs
21.4 for No Gnus.

But actually I was aiming in the opposite direction...

,----[ <news:v9y80ega32.fsf_-_@marauder.physik.uni-ulm.de> ]
| I wouldn't mind to drop Emacs 20.7 (and XEmacs 21.1) for Gnus 5.10.7
| (i.e. use the same requirements as for No Gnus).  If Lars agrees, I'll
| happily update (info "(gnus)Emacsen") accordingly.  :-)
`----

http://thread.gmane.org/gmane.emacs.gnus.general/61845/focus=61975 

I don't think it makes too much sense to claim compatibility to Emacs
20.7 and XEmacs 21.1 if none of the developers actually is willing or
able to test Gnus with these old versions anymore.

,----[ (info "(gnus)Emacsen") ]
| Older versions of Gnus may work on older Emacs versions.
`----

... still applies.  So Emacs 20.7 users can still use Gnus 5.10.8.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Emacs 20.7 compatibility in v5-10

[Lars Magne Ingebrigtsen]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> But actually I was aiming in the opposite direction...

Sure; just drop Emacs 20 support for 5.10 as well.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Emacs 20.7 compatibility in v5-10

[Reiner Steib]

On Thu, Apr 13 2006, Lars Magne Ingebrigtsen wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> But actually I was aiming in the opposite direction...
>
> Sure; just drop Emacs 20 support for 5.10 as well.

Done[1].  Also for XEmacs 21.1 (the XEmacs maintainers have stopped
supporting in some years ago).

Do you suggest to rip out Emacs 20/XEmacs 21.1 stuff systematically
like it was done after the start of No Gnus (mostly by Jesper and
Katsumi [2]) or only drop it on occasion?

Bye, Reiner.

[1]
--8<---------------cut here---------------start------------->8---
--- gnus.texi	11 Apr 2006 16:12:41 +0200	6.603.2.82
+++ gnus.texi	13 Apr 2006 19:29:32 +0200	
@@ -24870,16 +24870,17 @@
 @itemize @bullet
 
 @item
-Emacs 20.7 and up.
+Emacs 21.1 and up.
 
 @item
-XEmacs 21.1 and up.
+XEmacs 21.4 and up.
 
 @end itemize
 
 This Gnus version will absolutely not work on any Emacsen older than
 that.  Not reliably, at least.  Older versions of Gnus may work on older
-Emacs versions.
+Emacs versions.  Particularly, Gnus 5.10.8 should also work on Emacs
+20.7 and XEmacs 21.1.
 
 There are some vague differences between Gnus on the various
 platforms---XEmacs features more graphics (a logo and a toolbar)---but
--8<---------------cut here---------------end--------------->8---

[2]
--8<---------------cut here---------------start------------->8---
7 matches for "Emacs 20\|XEmacs 21.1" in buffer: ChangeLog
   3278:	which Emacs 20 doesn't support.
   7882:	* gnus-util.el (gnus-replace-in-string): Remove Emacs 20 code.
   8098:	* dgnushack.el: Remove some XEmacs 21.1 specific stuff.
   8154:	* gnus-registry.el: Remove Emacs 20 hash table compatibility code.
   8218:	Remove Emacs 20 hash table compatibility code.
   8245:	Remove Emacs 20 stuff:
   8252:	Emacs 20.
--8<---------------cut here---------------end--------------->8---
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Emacs 20.7 compatibility in v5-10

[Lars Magne Ingebrigtsen]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> Do you suggest to rip out Emacs 20/XEmacs 21.1 stuff systematically
> like it was done after the start of No Gnus (mostly by Jesper and
> Katsumi [2]) or only drop it on occasion?

For 5.10, I think it's better to just let it decay instead of removing
it actively.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen