Re: spam.el and IMAP

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

On Fri, Oct 24 2003, Ted Zlatanov wrote:

> On Thu, 23 Oct 2003, 4.uce.03.r.s@nurfuerspam.de wrote:
>
>> BTW, is there a simple way to tell `spam.el' to put ham articles
>> from "Spam/spamblock" to both, "bayes/ham" _and_ "INBOX"?
>> I.e. probably first copy the article to the first group and then
>> move it to the second.
>
> I see no reason why we can't handle multiple groups for
> {spam,ham}-process-destination.  I added the necessary code but it's
> untested - please try it out and let me know how it works.
>
> We used to use gnus-summary-move-article, now it's
> gnus-summary-copy-article followed by gnus-summary-delete-article.
> I assume an error in copy-article will abort the delete as well.

The patch leads to serious problems:

In my spam group, now the function
`spam-mark-spam-as-expired-and-move-routine' tries to *delete* all
spam-marked (`$') articles, rather than leaving them as expirable
(`E').  Luckily I had `gnus-novice-user' set to `t', so that
`gnus-summary-delete-article' asked me before deleting.

The next problem is, that there's something wrong with the new
multiple groups code.  I've customized the group,

,----
| [X] Destination for ham articles at summary exit from a spam
| group: [Value Menu] Move to multiple groups:
|     [INS] [DEL] Destination group: nnimap+urz:test1
|     [INS] [DEL] Destination group: nnimap+urz:test2
|     [INS]
| Where ham articles will go at summary exit from a spam group.
`----

... which lead to the following output in `G p':

,----
| ((ham-process-destination "nnimap+urz:test1" "nnimap+urz:test2")
|  (uidvalidity . "990116726")
|  (timestamp 16281 5192))
`----

BTW: Previously, I got dotted pairs, like...

  (ham-process-destination . "nnimap+urz:bayes/ham")

Is the new custom-type for multiple groups as intended?  BTW: Is `M-:
(gnus-group-find-parameter gnus-newsgroup-name
'ham-process-destination) RET' the correct way to check the parameter
inside the group?  (This returns nil now.)

Now, I marked one article as read (`r') using `d', then on group exit,
I edebugged `spam-ham-copy-or-move-routine' and found that `groups' is
`((nil))' leading to an error "Wrong type argument: stringp, (nil)"
one the last line in the following block of
`spam-ham-copy-or-move-routine':

    ;; now do the actual move
    (dolist (group groups)
      (when todo
	(dolist (article todo)
	  (when spam-mark-ham-unread-before-move-from-spam-group
	    (gnus-summary-mark-article article gnus-unread-mark))
	  (gnus-summary-set-process-mark article))
	(gnus-summary-copy-article nil group)))

> My topic and group parameters are very weird right now (see my
> earlier post about auto-expire) and I was not able to test the
> multiple groups code with group/topic parameters.

Maybe you should revert the change (multiple groups code), unless you
can fix it soon, because it may break existing setups and delete mails
(see above).  (If you can't test it, it might be better to post the
code here and wait for a positive reaction before committing it. ;-))

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/