From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66995 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general,gmane.emacs.xemacs.patches Subject: Re: [PATCH] Support opaque display-table objects on XEmacs Date: Tue, 27 May 2008 22:34:08 +0200 Message-ID: References: <18484.43203.462970.885072@parhasard.net> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1211920524 4397 80.91.229.12 (27 May 2008 20:35:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 May 2008 20:35:24 +0000 (UTC) Cc: ding@gnus.org, xemacs-patches@xemacs.org To: Aidan Kehoe Original-X-From: ding-owner+M15466@lists.math.uh.edu Tue May 27 22:36:04 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1K15tr-0007WR-Ik for ding-account@gmane.org; Tue, 27 May 2008 22:36:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1K15sn-0000cm-I3; Tue, 27 May 2008 15:34:57 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1K15sm-0000cW-3c for ding@lists.math.uh.edu; Tue, 27 May 2008 15:34:56 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1K15sf-0006q9-M9 for ding@lists.math.uh.edu; Tue, 27 May 2008 15:34:55 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1K15sv-0002Uw-00 for ; Tue, 27 May 2008 22:35:05 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m4RKYjxt016494; Tue, 27 May 2008 22:34:45 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 1C4631303F; Tue, 27 May 2008 22:34:45 +0200 (CEST) X-Face: :6KQZ[nyoS_edmB.%gw-=)BYth^|2+Y+^cu%I$FSx!&>-'om>3H7A|M&n(V7fIo3P.;yo.b yq4$p;ZaBtkv)\}biaiBQe"mD}iib1AA@99-fZ7i*bLhNRVC&0Wkxg9)SH?oWc@{ Mail-Followup-To: Aidan Kehoe , ding@gnus.org, xemacs-patches@xemacs.org In-Reply-To: (Miles Bader's message of "Thu, 22 May 2008 12:31:18 +0900") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2.50 (gnu/linux) X-DCC-dcc-servers.net-Metrics: poseidon 102; Body=3 Fuz1=3 Fuz2=3 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66995 gmane.emacs.xemacs.patches:9476 Archived-At: On Thu, May 22 2008, Miles Bader wrote: > Aidan Kehoe writes: >> This patch adds support for the non-sequence display tables of XEmacs 21= .5, >> without any run-time overhead on GNU. A patch that=E2=80=99s equivalent = in >> functionality for that version has been integrated into the XEmacs packa= ge >> repository; this conflicts with that, though--sorry Mike!--and is more >> compatible with GNU.=20 I gather that it should be applied to the stable and development branch. Right? >> I=E2=80=99ve tested this (somewhat superficially) with XEmacs 21.5, 21.4 >> and GNU. (Just call the later "Emacs".) >> Please advise me if this is the wrong list to submit this to.=20 It's the right list. Thanks. >> I have papers on file with the FSF for Gnus and for GNU Emacs as a >> whole, so that shouldn=E2=80=99t be an issue. Confirmed. =20 >> * gnus-util.el (gnus-put-display-table): New. >> (gnus-get-display-table): New.=20 >> Macros that expand to an #'aset call under GNU, and to a runtime choice >> under XEmacs.=20 Is writing =E2=80=9C#'=E2=80=9D a new XEmacsy ChangeLog convention? >> * gnus-sum.el (gnus-summary-set-display-table):=20 >> Use #'gnus-{put,get}-display-table, gnus-set-display-table for the >> display table, instead of #'aset.=20 >> * gnus-xmas.el (gnus-xmas-summary-set-display-table):=20 >> Use #'gnus-{put,get}-display-table, gnus-set-display-table for the >> display table. It's better (e.g. for searching) to spell out the macro names (not using {put,get}). >> @@ -3431,8 +3431,8 @@ >> 256))) >> (while (>=3D (setq i (1- i)) 127) >> ;; Only modify if the entry is nil. >> - (unless (aref table i) >> - (aset table i [??])))) >> + (unless (get-display-table i table) >> + (put-display-table i [??] table)))) >> (setq buffer-display-table table))) > > Should those be `gnus-get-display-table' and `gnus-put-display-table'? Aidan? >> +(defmacro gnus-put-display-table (range value display-table) >> + "Set the value for char RANGE to VALUE in DISPLAY-TABLE. " >> + (if (featurep 'xemacs) >> + (progn Useless `progn'? >> + `(if (fboundp 'put-display-table) >> + (put-display-table ,range ,value ,display-table) >> + (if (sequencep ,display-table) >> + (aset ,display-table ,range ,value) >> + (put-char-table ,range ,value ,display-table)))) `cond' would be more readable than an `if'-cascade, IMHO. >> + `(aset ,display-table ,range ,value))) Bye, Reiner. --=20 ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/