* Re: Change Log [not found] ` <30ba16e8-0ed0-49f8-b92e-e77892a7b2ce@well-done.deisui.org> @ 2006-09-06 8:50 ` Richard Stallman 2006-09-06 13:00 ` Simon Josefsson 2006-09-06 14:14 ` Reiner Steib 0 siblings, 2 replies; 10+ messages in thread From: Richard Stallman @ 2006-09-06 8:50 UTC (permalink / raw) Cc: ding > Can you please show me the change log entries for those two changes > that you reverted? I could not find them, and that is worrisome, > since we are supposed to have change log entries for all changes. 2003-02-08 Simon Josefsson <jas@extundo.com> * pgg-gpg.el (pgg-gpg-process-region): Don't blink. From Satyaki Das <satyaki@chicory.stanford.edu>. 2003-08-07 Jesper Harder <harder@ifa.au.dk> * pgg-gpg.el (pgg-gpg-process-region): Bind default-enable-multibyte-characters to nil. Both of those change log entries were done wrong. Since both changes were contributed by Satyaki Das, both of them should list him as the person who wrote the change: 2003-02-08 Satyaki Das <satyaki@chicory.stanford.edu> * pgg-gpg.el (pgg-gpg-process-region): Don't blink. 2003-08-07 Satyaki Das <satyaki@chicory.stanford.edu> * pgg-gpg.el (pgg-gpg-process-region): Bind default-enable-multibyte-characters to nil. These two don't matter much since the code was removed. But how many other changes, by various people, are mislabeled? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Change Log 2006-09-06 8:50 ` Change Log Richard Stallman @ 2006-09-06 13:00 ` Simon Josefsson 2006-09-06 14:14 ` Reiner Steib 1 sibling, 0 replies; 10+ messages in thread From: Simon Josefsson @ 2006-09-06 13:00 UTC (permalink / raw) Cc: Daiki Ueno, ding Richard Stallman <rms@gnu.org> writes: > > Can you please show me the change log entries for those two changes > > that you reverted? I could not find them, and that is worrisome, > > since we are supposed to have change log entries for all changes. > > 2003-02-08 Simon Josefsson <jas@extundo.com> > > * pgg-gpg.el (pgg-gpg-process-region): Don't blink. From Satyaki > Das <satyaki@chicory.stanford.edu>. > > 2003-08-07 Jesper Harder <harder@ifa.au.dk> > > * pgg-gpg.el (pgg-gpg-process-region): Bind > default-enable-multibyte-characters to nil. > > Both of those change log entries were done wrong. Since both changes > were contributed by Satyaki Das, both of them should list him as > the person who wrote the change: > > > 2003-02-08 Satyaki Das <satyaki@chicory.stanford.edu> > > * pgg-gpg.el (pgg-gpg-process-region): Don't blink. > > 2003-08-07 Satyaki Das <satyaki@chicory.stanford.edu> > > * pgg-gpg.el (pgg-gpg-process-region): Bind > default-enable-multibyte-characters to nil. > > These two don't matter much since the code was removed. > But how many other changes, by various people, are mislabeled? Speaking for me, I used the 'From: X' style to indicate who wrote the patch, and whom I also made sure to get papers for before installing. This was the ChangeLog entry style used in Gnus a few years ago -- those ChangeLog entries were likely later copied into Emacs. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Change Log 2006-09-06 8:50 ` Change Log Richard Stallman 2006-09-06 13:00 ` Simon Josefsson @ 2006-09-06 14:14 ` Reiner Steib 2006-09-06 21:52 ` Jesper Harder 2006-09-07 6:54 ` Richard Stallman 1 sibling, 2 replies; 10+ messages in thread From: Reiner Steib @ 2006-09-06 14:14 UTC (permalink / raw) Cc: ding, Jesper Harder On Wed, Sep 06 2006, Richard Stallman wrote: > 2003-02-08 Simon Josefsson <jas@extundo.com> > > * pgg-gpg.el (pgg-gpg-process-region): Don't blink. From Satyaki > Das <satyaki@chicory.stanford.edu>. After your message (subject: No "From so-and-so" in ChangeLog [1]) on emacs-devel, I have fixed all "From so-and-so" and "tiny change" ChangeLog entries in the _current_ Gnus ChangeLog files [2]. I didn't do this in the ChangeLog.? files (entries older than 2004-01-04) because of lack of time. It would be nice if change-log-mode could highlight the correct syntax better and use `font-lock-warning-face' for "From so-and-so" and other mistakes (e.g. only one space in before the mail address). > 2003-08-07 Jesper Harder <harder@ifa.au.dk> > > * pgg-gpg.el (pgg-gpg-process-region): Bind > default-enable-multibyte-characters to nil. > > Both of those change log entries were done wrong. Since both changes > were contributed by Satyaki Das, both of them should list him as > the person who wrote the change: [...] > 2003-08-07 Satyaki Das <satyaki@chicory.stanford.edu> > > * pgg-gpg.el (pgg-gpg-process-region): Bind > default-enable-multibyte-characters to nil. > > These two don't matter much since the code was removed. > But how many other changes, by various people, are mislabeled? The article [3] with the proposed patch by Satyaki Das was on 2003-02-28. The commit by Jesper Harder was done some months later (2003-08-07). Jesper might have done it independently. Jesper? Bye, Reiner. [1] ,----[ http://thread.gmane.org/E1ClJsv-0001TZ-SS%40fencepost.gnu.org ] | From: Richard Stallman <rms@gnu.org> | Subject: No "From so-and-so" in ChangeLog | To: emacs-devel@gnu.org | Date: Sun, 02 Jan 2005 23:32:01 -0500 | Message-ID: <E1ClJsv-0001TZ-SS@fencepost.gnu.org> `---- [2] See ``Fix "From so-and-so" and "(tiny change)" entries.'' in the cvs history. [3] http://article.gmane.org/gmane.emacs.gnus.general/50457 -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Change Log 2006-09-06 14:14 ` Reiner Steib @ 2006-09-06 21:52 ` Jesper Harder 2006-09-07 21:14 ` Richard Stallman 2006-09-07 6:54 ` Richard Stallman 1 sibling, 1 reply; 10+ messages in thread From: Jesper Harder @ 2006-09-06 21:52 UTC (permalink / raw) Cc: ding Reiner Steib <reinersteib+gmane@imap.cc> writes: > The article [3] with the proposed patch by Satyaki Das was on > 2003-02-28. The commit by Jesper Harder was done some months later > (2003-08-07). Jesper might have done it independently. Jesper? Yes, it was done independently. See the thread containing <m31xw2pbjo.fsf@defun.localdomain> on the Gnus bugs list. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Change Log 2006-09-06 21:52 ` Jesper Harder @ 2006-09-07 21:14 ` Richard Stallman 2006-09-07 21:29 ` Jesper Harder 2006-09-07 22:28 ` Reiner Steib 0 siblings, 2 replies; 10+ messages in thread From: Richard Stallman @ 2006-09-07 21:14 UTC (permalink / raw) Cc: ding Yes, it was done independently. See the thread containing <m31xw2pbjo.fsf@defun.localdomain> on the Gnus bugs list. But...how come the entry in ChangeLog.2 says "From Satyaki Das"? Or am I looking at the wrong entry? Which entry is the one you are talking about? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Change Log 2006-09-07 21:14 ` Richard Stallman @ 2006-09-07 21:29 ` Jesper Harder 2006-09-08 15:11 ` Richard Stallman 2006-09-07 22:28 ` Reiner Steib 1 sibling, 1 reply; 10+ messages in thread From: Jesper Harder @ 2006-09-07 21:29 UTC (permalink / raw) Cc: ding On 07/09/06, Richard Stallman <rms@gnu.org> wrote: > Yes, it was done independently. See the thread containing > <m31xw2pbjo.fsf@defun.localdomain> on the Gnus bugs list. > > But...how come the entry in ChangeLog.2 says "From Satyaki Das"? > Or am I looking at the wrong entry? Which entry is the one you > are talking about? I'm talking about this entry: 2003-08-07 Jesper Harder <harder@ifa.au.dk> * pgg-gpg.el (pgg-gpg-process-region): Bind default-enable-multibyte-characters to nil. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Change Log 2006-09-07 21:29 ` Jesper Harder @ 2006-09-08 15:11 ` Richard Stallman 0 siblings, 0 replies; 10+ messages in thread From: Richard Stallman @ 2006-09-08 15:11 UTC (permalink / raw) Cc: ding Ok, it's clear now. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Change Log 2006-09-07 21:14 ` Richard Stallman 2006-09-07 21:29 ` Jesper Harder @ 2006-09-07 22:28 ` Reiner Steib 1 sibling, 0 replies; 10+ messages in thread From: Reiner Steib @ 2006-09-07 22:28 UTC (permalink / raw) Cc: Jesper Harder, ding On Thu, Sep 07 2006, Richard Stallman wrote: > Yes, it was done independently. See the thread containing > <m31xw2pbjo.fsf@defun.localdomain> on the Gnus bugs list. > > But...how come the entry in ChangeLog.2 says "From Satyaki Das"? > Or am I looking at the wrong entry? Yes. The one with "From Satyaki Das" was: ,---- | 2003-02-08 Simon Josefsson <jas@extundo.com> | | [...] | | * pgg-gpg.el (pgg-gpg-process-region): Don't blink. From Satyaki | Das <satyaki@chicory.stanford.edu>. `---- > Which entry is the one you are talking about? This one: ,---- | 2003-08-07 Jesper Harder <harder@ifa.au.dk> | | * pgg-gpg.el (pgg-gpg-process-region): Bind | default-enable-multibyte-characters to nil. `---- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Change Log 2006-09-06 14:14 ` Reiner Steib 2006-09-06 21:52 ` Jesper Harder @ 2006-09-07 6:54 ` Richard Stallman 2006-10-08 11:43 ` Reiner Steib 1 sibling, 1 reply; 10+ messages in thread From: Richard Stallman @ 2006-09-07 6:54 UTC (permalink / raw) Cc: ding, harder I didn't do this in the ChangeLog.? files (entries older than 2004-01-04) because of lack of time. Would you please fix the old ones too? We need to make sure our clerk is not confused. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Change Log 2006-09-07 6:54 ` Richard Stallman @ 2006-10-08 11:43 ` Reiner Steib 0 siblings, 0 replies; 10+ messages in thread From: Reiner Steib @ 2006-10-08 11:43 UTC (permalink / raw) Cc: ding On Thu, Sep 07 2006, Richard Stallman wrote: [ Fix "From so-and-so" in ChangeLog files ] > I didn't > do this in the ChangeLog.? files (entries older than 2004-01-04) > because of lack of time. > > Would you please fix the old ones too? We need to make sure > our clerk is not confused. Done (in Gnus CVS; the changes will propagate to Emacs CVS with Miles' next sync). Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2006-10-08 11:43 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <E1GKI5U-00009I-9O@fencepost.gnu.org> [not found] ` <30ba16e8-0ed0-49f8-b92e-e77892a7b2ce@well-done.deisui.org> 2006-09-06 8:50 ` Change Log Richard Stallman 2006-09-06 13:00 ` Simon Josefsson 2006-09-06 14:14 ` Reiner Steib 2006-09-06 21:52 ` Jesper Harder 2006-09-07 21:14 ` Richard Stallman 2006-09-07 21:29 ` Jesper Harder 2006-09-08 15:11 ` Richard Stallman 2006-09-07 22:28 ` Reiner Steib 2006-09-07 6:54 ` Richard Stallman 2006-10-08 11:43 ` Reiner Steib
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).