Re: A lot of questions concerning `gnus-score-edit-file-at-point'

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

On Sun, Dec 28 2003, Karl Pflästerer wrote:

> (a) Does anyone really use `gnus-score-edit-file-at-point' outside a
>     *Score Trace* buffer?  If not the function could be written simpler.

I don't think it's necessary that it works outside *Score Trace*
buffers.  So we could use option [d].

> (b) At the moment `ffap-string-at-point' gets used in that function.
>     But that's the sole usage of that function in gnus-score.el (the
>     sole usage in Gnus at all).

Since `ffap' is available in all supported (X)Emacs versions, it's
okay to use it.  If we can do the same with `buffer-substring' it's
fine.

> (c) Furthermore there would no longer be a need to define it
>     interactive.  To bind it to a key the function could get called by a
>     lambda form.  That would help to clean the interactive namespace a
>     bit (one function less :-) ).  So that leads to[d]  
>
> So what do you say?

Unlike the old code, your function always goes to the rule.  So we
should change the manual.

,----[ (info "(gnus)Summary Score Commands") ]
| `V t'
|      Display all score rules that have been used on the current article
|      (`gnus-score-find-trace').  In the `*Score Trace*' buffer, you can
|      use `q' to quit.  `e' edits the corresponding score file.  When
|      point is on a string within the match element, `e' will try to
|      bring you to this string in the score file.
`----

> [d] 
>
> (defun gnus-score-edit-file-at-point ()
[...]
> 	(file (save-excursion
> 		;; only works in a Score Trace buffer
> 		(beginning-of-line)
> 		(re-search-forward "-> +" nil t)

Fails in this example:

("foo -> bar" 1 nil s)  ->  /some/score/file

Maybe search for a more strict expression, such as ")  ->  ".
Example:

("^[^)]+" 2 nil r)  ->  /some/score/file

Or is there a function to jump to the matching parenthesis, even when
there is one inside the score entry?  If not, using `end-of-line' and
`re-search-backward' should be more robust.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/