From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/55335
Path: main.gmane.org!not-for-mail
From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: A lot of questions concerning `gnus-score-edit-file-at-point'
Date: Mon, 29 Dec 2003 18:15:03 +0100
Organization: Dept. of Theoretical Physics, University of Ulm
Sender: ding-owner@lists.math.uh.edu
Message-ID: <v9oetrbl60.fsf@marauder.physik.uni-ulm.de>
References: <m34qvkc2g1.fsf@hamster.pflaesterer.de>
Reply-To: reiner.steib@gmx.de
NNTP-Posting-Host: deer.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Trace: sea.gmane.org 1072718713 32662 80.91.224.253 (29 Dec 2003 17:25:13 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 29 Dec 2003 17:25:13 +0000 (UTC)
Original-X-From: ding-owner+M3875@lists.math.uh.edu Mon Dec 29 18:25:08 2003
Return-path: <ding-owner+M3875@lists.math.uh.edu>
Original-Received: from malifon.math.uh.edu ([129.7.128.13])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1Ab18d-0002dl-00
	for <ding-account@gmane.org>; Mon, 29 Dec 2003 18:25:07 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu)
	by malifon.math.uh.edu with smtp (Exim 3.20 #1)
	id 1Ab18Q-0001YA-00; Mon, 29 Dec 2003 11:24:54 -0600
Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix)
	by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
	id 1Ab18I-0001Y2-00
	for ding@lists.math.uh.edu; Mon, 29 Dec 2003 11:24:46 -0600
Original-Received: from main.gmane.org (main.gmane.org [80.91.224.249])
	by justine.libertine.org (Postfix) with ESMTP id 680533A00F8
	for <ding@gnus.org>; Mon, 29 Dec 2003 11:24:45 -0600 (CST)
Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1Ab18G-0000RK-00
	for <ding@gnus.org>; Mon, 29 Dec 2003 18:24:44 +0100
Mail-Followup-To: ding@gnus.org
X-Injected-Via-Gmane: http://gmane.org/
Original-To: ding@gnus.org
Original-Received: from sea.gmane.org ([80.91.224.252])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1Ab18E-0000RB-00
	for <gmane-emacs-gnus-general@m.gmane.org>; Mon, 29 Dec 2003 18:24:42 +0100
Original-Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1Ab18E-0008T9-00
	for <gmane-emacs-gnus-general@m.gmane.org>; Mon, 29 Dec 2003 18:24:42 +0100
Original-Lines: 62
Original-X-Complaints-To: usenet@sea.gmane.org
X-Face: 3Phac&+dw=IZHjhua]bp}LH<*p{qzj8u+<OV~fQY=S61n*cJ|<hmq6\]&vOTQs+z`}WHHM/
 E?ZYqI^aM0-^*)pWU&1tb.Tw}GDqeE.+(!jEP8@b&IcxNU1QQz%1d1;aeOzyizTPc;q(88/ar*bN|S
 IU"]xqU`R)i%Jp-lu3<!7QjP@,9xqE@*G{3ESw3x#1N1?,(r0&q(1LKm)hS@d89lfo+'=Y$#7"g<&v
 hNp|fgfb<eK="G5fxvZ3FyyWQNI9JL+C<g
Mail-Copies-To: nobody
User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3 (gnu/linux)
Cancel-Lock: sha1:gV7upI7Azs7HdH23jquj3SxcWrs=
Precedence: bulk
Xref: main.gmane.org gmane.emacs.gnus.general:55335
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:55335

On Sun, Dec 28 2003, Karl Pfl=E4sterer wrote:

> (a) Does anyone really use `gnus-score-edit-file-at-point' outside a
>     *Score Trace* buffer?  If not the function could be written simpler.

I don't think it's necessary that it works outside *Score Trace*
buffers.  So we could use option [d].

> (b) At the moment `ffap-string-at-point' gets used in that function.
>     But that's the sole usage of that function in gnus-score.el (the
>     sole usage in Gnus at all).

Since `ffap' is available in all supported (X)Emacs versions, it's
okay to use it.  If we can do the same with `buffer-substring' it's
fine.

> (c) Furthermore there would no longer be a need to define it
>     interactive.  To bind it to a key the function could get called by a
>     lambda form.  That would help to clean the interactive namespace a
>     bit (one function less :-) ).  So that leads to[d]=20=20
>
> So what do you say?

Unlike the old code, your function always goes to the rule.  So we
should change the manual.

,----[ (info "(gnus)Summary Score Commands") ]
| `V t'
|      Display all score rules that have been used on the current article
|      (`gnus-score-find-trace').  In the `*Score Trace*' buffer, you can
|      use `q' to quit.  `e' edits the corresponding score file.  When
|      point is on a string within the match element, `e' will try to
|      bring you to this string in the score file.
`----

> [d]=20
>
> (defun gnus-score-edit-file-at-point ()
[...]
> 	(file (save-excursion
> 		;; only works in a Score Trace buffer
> 		(beginning-of-line)
> 		(re-search-forward "-> +" nil t)

Fails in this example:

("foo -> bar" 1 nil s)  ->  /some/score/file

Maybe search for a more strict expression, such as ")  ->  ".
Example:

("^[^)]+" 2 nil r)  ->  /some/score/file

Or is there a function to jump to the matching parenthesis, even when
there is one inside the score entry?  If not, using `end-of-line' and
`re-search-backward' should be more robust.

Bye, Reiner.
--=20
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/