Bogus definition of replace-in-string in color-theme.el (was: Error)

Bogus definition of replace-in-string in color-theme.el (was: Error)

[Reiner Steib]

On Wed, May 14 2008, Ashish Shukla आशीष शुक्ल wrote:

> While going through some of the messages in Maildir, I got the
> following error:
>
> ggogle in #emacs concluded that it is due to wrong number of arguments
> passed in 'mm-replace-in-string' function (which is actually an alias ro
> 'replace-in-string' function in color-theme.el) call, which expects 3,
> but actually 4 arguments are passed.
>
> ---->8---->8----
> Debugger entered--Lisp error: (wrong-number-of-arguments #[(target old new)
[...]
> Hope to see it fixed soon.

This is a bug in `color-theme.el' which causes problems with Gnus,
emacs-jabber, muse etc.  I already pointed out the bug to it's
maintainer.  Alas, without any response upto now.

,----
| From: Reiner Steib
| Subject: Bogus definition of replace-in-string in color-theme.el (was: Fwd: Re: Error viewing PGP/mime signed messages)
| To: Xavier Maillard <xma // gnu.org>
| Cc: Katsumi Yamaoka <yamaoka@jpl.org>
| Date: Wed, 19 Mar 2008 13:39:51 +0100
| Message-ID: <v9d4pqj39g.fsf@marauder.physik.uni-ulm.de>
| 
| Hi Xavier,
|
| please fix the use of `replace-in-string' in color-theme.el ASAP (see
| the problem described below and in <https://gna.org/bugs/?9494>).
| 
| No package should ever define functions and variables out of it's own
| name space:
| 
| ,----[ (info "(elisp)Coding Conventions") ]
| |    * If a package needs to define an alias or a new function for
| |      compatibility with some other version of Emacs, name it with the
| |      package prefix, not with the raw name with which it occurs in the
| |      other version.  Here is an example from Gnus, which provides many
| |      examples of such compatibility issues.
| | 
| |           (defalias 'gnus-point-at-bol
| |             (if (fboundp 'point-at-bol)
| |                 'point-at-bol
| |               'line-beginning-position))
| `----
| [ Forwarded articles from
|   <http://thread.gmane.org/gmane.emacs.gnus.general/66521/focus=66522>
|   stripped. ]
`----

See <http://thread.gmane.org/gmane.emacs.gnus.general/66521/focus=66522>
or article <b4my78gr3rs.fsf@jpl.org> for a patch to `color-theme.el'.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Bogus definition of replace-in-string in color-theme.el

[Ashish Shukla आशीष शुक्ल]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

>>>>> Reiner Steib writes:
    Reiner> On Wed, May 14 2008, Ashish Shukla आशीष शुक्ल wrote:

    >> While going through some of the messages in Maildir, I got the
    >> following error:
    >> 
    >> ggogle in #emacs concluded that it is due to wrong number of arguments
    >> passed in 'mm-replace-in-string' function (which is actually an alias ro
    >> 'replace-in-string' function in color-theme.el) call, which expects 3,
    >> but actually 4 arguments are passed.

[snip]

    Reiner> See <http://thread.gmane.org/gmane.emacs.gnus.general/66521/focus=66522>
    Reiner> or article <b4my78gr3rs.fsf@jpl.org> for a patch to `color-theme.el'.

Thanks, above patch works fine.
-- 
Ashish Shukla आशीष शुक्ल                      http://wahjava.wordpress.com/
·-- ·- ···· ·--- ·- ···- ·- ·--·-· --· -- ·- ·· ·-·· ·-·-·- -·-· --- --

[-- Attachment #2: Type: application/pgp-signature, Size: 196 bytes --]

Re: Bogus definition of replace-in-string in color-theme.el

[Reiner Steib]

[ The following message is a courtesy copy of an article that has
  been posted to news:gmane.emacs.gnus.general as well. ]

On Wed, May 14 2008, Ashish Shukla आशीष शुक्ल wrote:

>>>>>> Reiner Steib writes:
>     Reiner> See <http://thread.gmane.org/gmane.emacs.gnus.general/66521/focus=66522>
>     Reiner> or article <b4my78gr3rs.fsf@jpl.org> for a patch to `color-theme.el'.
>
> Thanks, above patch works fine.

Please report it to the maintainer of `color-theme.el'.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/