* emacs->gnus merge questions @ 2007-12-08 3:24 Miles Bader 2007-12-08 19:38 ` Reiner Steib 0 siblings, 1 reply; 21+ messages in thread From: Miles Bader @ 2007-12-08 3:24 UTC (permalink / raw) To: ding I'm doing the back-merge from the Emacs trunk to the Gnus trunk. There are some changes which may or may not be appropriate for Gnus: (1) deleted: encrypt.el (2) deleted: assistant.el (3) rename: password.el => password-cache.el I'm inclined to include all these changes (the fewer differences between Gnus and Gnus-in-Emacs, the better); does anyone have a comment? In addition, uses of `declare-function' have been added to various files. I assume a Gnus maintainer will want to replace this with a gnus-specific macro for backwards compatibility. -Miles -- ((lambda (x) (list x x)) (lambda (x) (list x x))) ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: emacs->gnus merge questions 2007-12-08 3:24 emacs->gnus merge questions Miles Bader @ 2007-12-08 19:38 ` Reiner Steib 2007-12-08 21:19 ` Miles Bader ` (3 more replies) 0 siblings, 4 replies; 21+ messages in thread From: Reiner Steib @ 2007-12-08 19:38 UTC (permalink / raw) To: ding On Sat, Dec 08 2007, Miles Bader wrote: > I'm doing the back-merge from the Emacs trunk to the Gnus trunk. > > There are some changes which may or may not be appropriate for Gnus: > > (1) deleted: encrypt.el I'm not sure about this one. Ted? > (2) deleted: assistant.el Please don't delete assistant.el. I hope that someone will continue developing it. (In Emacs, *.ast need to be removed as well.) > (3) rename: password.el => password-cache.el Yes, please do. Could you also sync the relevant changes from Emacs? E.g. use... (or (require 'password-cache nil t) (require 'password)) > I'm inclined to include all these changes (the fewer differences between > Gnus and Gnus-in-Emacs, the better); does anyone have a comment? > > In addition, uses of `declare-function' have been added to various > files. I assume a Gnus maintainer will want to replace this with a > gnus-specific macro for backwards compatibility. Yes, there is a discussion about this: <http://thread.gmane.org/gmane.emacs.devel/84386/focus=65888> I hope Richard won't object to keep the files the same in both CVSes (e.g. imap.el) even if we add compatibility code like... (eval-and-compile (unless (fboundp 'declare-function) (defmacro declare-function (&rest r)))) BTW, sometimes it would be nice to know which changes have already be synced from/to Emacs CVS and or compare. What do you think about adding tags to Gnus CVS: merge_to_emacs_trunk merge_from_emacs_trunk merge_to_emacs_22 merge_from_emacs_22 After you have done the merge, (re)tag the repositories. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: emacs->gnus merge questions 2007-12-08 19:38 ` Reiner Steib @ 2007-12-08 21:19 ` Miles Bader 2007-12-08 21:29 ` Reiner Steib 2007-12-08 23:32 ` Miles Bader ` (2 subsequent siblings) 3 siblings, 1 reply; 21+ messages in thread From: Miles Bader @ 2007-12-08 21:19 UTC (permalink / raw) To: ding Reiner Steib <reinersteib+gmane@imap.cc> writes: > (eval-and-compile > (unless (fboundp 'declare-function) (defmacro declare-function (&rest r)))) Defining standard functions is a very bad idea in general. Better to use the standard Gnus approach of a special `gnus-declare-function' or whatever (yeah it's ugly, but...). > What do you think about adding tags to Gnus CVS: > > merge_to_emacs_trunk > merge_from_emacs_trunk > merge_to_emacs_22 > merge_from_emacs_22 Ok. -Miles -- `Suppose Korea goes to the World Cup final against Japan and wins,' Moon said. `All the past could be forgiven.' [NYT] ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: emacs->gnus merge questions 2007-12-08 21:19 ` Miles Bader @ 2007-12-08 21:29 ` Reiner Steib 0 siblings, 0 replies; 21+ messages in thread From: Reiner Steib @ 2007-12-08 21:29 UTC (permalink / raw) To: ding On Sat, Dec 08 2007, Miles Bader wrote: > Reiner Steib <reinersteib+gmane@imap.cc> writes: >> (eval-and-compile >> (unless (fboundp 'declare-function) (defmacro declare-function (&rest r)))) > > Defining standard functions is a very bad idea in general. Better to > use the standard Gnus approach of a special `gnus-declare-function' or > whatever (yeah it's ugly, but...). That was my first reaction too, but Richard and other Emacs developers say it is okay in this case: <http://thread.gmane.org/gmane.emacs.devel/84621> >> merge_to_emacs_trunk >> merge_from_emacs_trunk >> merge_to_emacs_22 >> merge_from_emacs_22 > > Ok. Thanks. (Feel free to suggest better names.) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: emacs->gnus merge questions 2007-12-08 19:38 ` Reiner Steib 2007-12-08 21:19 ` Miles Bader @ 2007-12-08 23:32 ` Miles Bader 2007-12-08 23:45 ` Miles Bader 2007-12-11 16:22 ` emacs->gnus merge questions Ted Zlatanov 3 siblings, 0 replies; 21+ messages in thread From: Miles Bader @ 2007-12-08 23:32 UTC (permalink / raw) To: ding -- Do not taunt Happy Fun Ball. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: emacs->gnus merge questions 2007-12-08 19:38 ` Reiner Steib 2007-12-08 21:19 ` Miles Bader 2007-12-08 23:32 ` Miles Bader @ 2007-12-08 23:45 ` Miles Bader 2008-02-16 13:24 ` encrypt.el (was: emacs->gnus merge questions) Reiner Steib 2008-02-16 13:26 ` assistant.el " Reiner Steib 2007-12-11 16:22 ` emacs->gnus merge questions Ted Zlatanov 3 siblings, 2 replies; 21+ messages in thread From: Miles Bader @ 2007-12-08 23:45 UTC (permalink / raw) To: ding Reiner Steib <reinersteib+gmane@imap.cc> writes: >> (1) deleted: encrypt.el > I'm not sure about this one. Ted? >> (2) deleted: assistant.el > Please don't delete assistant.el. Ok, I will leave both in for the time being. Maybe encrypt.el should be removed later though. As best I can figure from the discussion on emacs-devel (the threads seem all over the place): * There's some interest in assistant.el, but it hasn't been developed enough yet. It's the sort of feature Gnus could really use (because of the complexity of configuring Gnus), but nobody is actually doing anything about it... * It seems unlikely encrypt.el is going to go into Emacs. The merge from Emacs changes netrc.el to not use encrypt.el, so leaving it in Gnus seems a bit pointless (the changes to netrc.el could be reverted in Gnus, but I'd rather avoid diverging sources when possible). -Miles -- It wasn't the Exxon Valdez captain's driving that caused the Alaskan oil spill. It was yours. [Greenpeace advertisement, New York Times, 25 February 1990] ^ permalink raw reply [flat|nested] 21+ messages in thread
* encrypt.el (was: emacs->gnus merge questions) 2007-12-08 23:45 ` Miles Bader @ 2008-02-16 13:24 ` Reiner Steib 2008-02-16 13:26 ` assistant.el " Reiner Steib 1 sibling, 0 replies; 21+ messages in thread From: Reiner Steib @ 2008-02-16 13:24 UTC (permalink / raw) To: Miles Bader; +Cc: ding [ Sorry for the long delay. I'm trying to go through my ticked articles...] On Sun, Dec 09 2007, Miles Bader wrote: > Reiner Steib <reinersteib+gmane@imap.cc> writes: >>> (1) deleted: encrypt.el >> I'm not sure about this one. Ted? [...] > Ok, I will leave both in for the time being. Maybe encrypt.el should be > removed later though. I just suggested to move in <news:v9r6fd11vp.fsf_-_@marauder.physik.uni-ulm.de>. > As best I can figure from the discussion on emacs-devel (the threads > seem all over the place): > [...] > * It seems unlikely encrypt.el is going to go into Emacs. That's my conclusion as well. Now that EasyPG is included in Emacs 23, users could probably use the `auto-compression-mode'-like feature (under discussion/development?) for ~/.authinfo, too. > The merge from Emacs changes netrc.el to not use encrypt.el, so > leaving it in Gnus seems a bit pointless (the changes to netrc.el > could be reverted in Gnus, but I'd rather avoid diverging sources > when possible). ACK, diverging sources should be avoided. As i understand, encrypt.el can now be used optionally in netrc.el so both versions (Emacs trunk and Gnus trunk) should be identical. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* assistant.el (was: emacs->gnus merge questions) 2007-12-08 23:45 ` Miles Bader 2008-02-16 13:24 ` encrypt.el (was: emacs->gnus merge questions) Reiner Steib @ 2008-02-16 13:26 ` Reiner Steib 1 sibling, 0 replies; 21+ messages in thread From: Reiner Steib @ 2008-02-16 13:26 UTC (permalink / raw) To: Miles Bader; +Cc: ding On Sun, Dec 09 2007, Miles Bader wrote: > Reiner Steib <reinersteib+gmane@imap.cc> writes: >>> (2) deleted: assistant.el >> Please don't delete assistant.el. > > Ok, I will leave both in for the time being. [...] > > As best I can figure from the discussion on emacs-devel (the threads > seem all over the place): > > * There's some interest in assistant.el, but it hasn't been developed > enough yet. Correct. > It's the sort of feature Gnus could really use (because of the > complexity of configuring Gnus), but nobody is actually doing > anything about it... It would probably be useful for other parts of Emacs as well. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: emacs->gnus merge questions 2007-12-08 19:38 ` Reiner Steib ` (2 preceding siblings ...) 2007-12-08 23:45 ` Miles Bader @ 2007-12-11 16:22 ` Ted Zlatanov 2007-12-17 23:02 ` Ted Zlatanov 3 siblings, 1 reply; 21+ messages in thread From: Ted Zlatanov @ 2007-12-11 16:22 UTC (permalink / raw) To: ding On Sat, 08 Dec 2007 20:38:29 +0100 Reiner Steib <reinersteib+gmane@imap.cc> wrote: RS> On Sat, Dec 08 2007, Miles Bader wrote: >> I'm doing the back-merge from the Emacs trunk to the Gnus trunk. >> >> There are some changes which may or may not be appropriate for Gnus: >> >> (1) deleted: encrypt.el RS> I'm not sure about this one. Ted? It would be great if it could stay somewhere, maybe under contrib/ because I know at least 2 people use it. Also, can we have a conditional use in netrc.el if it's loaded? I don't want to redefine netrc functionality as well for everyone that wants to use it. If it can stay, I'll need to change its library requirements from password to password-cache as previously discussed. Ted ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: emacs->gnus merge questions 2007-12-11 16:22 ` emacs->gnus merge questions Ted Zlatanov @ 2007-12-17 23:02 ` Ted Zlatanov 2007-12-17 23:03 ` Ted Zlatanov ` (2 more replies) 0 siblings, 3 replies; 21+ messages in thread From: Ted Zlatanov @ 2007-12-17 23:02 UTC (permalink / raw) To: ding On Tue, 11 Dec 2007 10:22:50 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: TZ> On Sat, 08 Dec 2007 20:38:29 +0100 Reiner Steib <reinersteib+gmane@imap.cc> wrote: RS> On Sat, Dec 08 2007, Miles Bader wrote: >>> I'm doing the back-merge from the Emacs trunk to the Gnus trunk. >>> >>> There are some changes which may or may not be appropriate for Gnus: >>> >>> (1) deleted: encrypt.el RS> I'm not sure about this one. Ted? TZ> It would be great if it could stay somewhere, maybe under contrib/ TZ> because I know at least 2 people use it. Also, can we have a TZ> conditional use in netrc.el if it's loaded? I don't want to redefine TZ> netrc functionality as well for everyone that wants to use it. TZ> If it can stay, I'll need to change its library requirements from TZ> password to password-cache as previously discussed. I am including a patch (not comitted yet) which changes encrypt.el docs to specifically say a (require) call is needed, and uses the (load-library) idea Glen Morris posted earlier to pick between password.el and password-cache.el. I like its brevity :) The patch also changes netrc.el to work with or without encrypt.el; when encrypt.el is loaded and encrypt-file-alist is not nil (using the (bound-and-true-p) macro from bindings.el) the netrc.el code behaves as before; otherwise it will just insert the netrc file contents normally. Will this work in XEmacs? Please review the patch and let me know if encrypt.el is staying in gnus/contrib or if I should host it separately. Either way, the patch should be applied if everyone agrees it will work OK. Thanks Ted ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: emacs->gnus merge questions 2007-12-17 23:02 ` Ted Zlatanov @ 2007-12-17 23:03 ` Ted Zlatanov 2007-12-18 20:25 ` Ted Zlatanov 2008-02-16 13:12 ` encrypt.el " Reiner Steib 2 siblings, 0 replies; 21+ messages in thread From: Ted Zlatanov @ 2007-12-17 23:03 UTC (permalink / raw) To: ding [-- Attachment #1: Type: text/plain, Size: 159 bytes --] On Mon, 17 Dec 2007 17:02:35 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: TZ> I am including a patch (not comitted yet) ... I didn't, but I am now :) Ted [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: netrc+encrypt.patch --] [-- Type: text/x-diff, Size: 2207 bytes --] ? netrc+encrypt.patch Index: encrypt.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/encrypt.el,v retrieving revision 7.11 diff -u -r7.11 encrypt.el --- encrypt.el 1 Nov 2007 15:01:11 -0000 7.11 +++ encrypt.el 17 Dec 2007 22:55:28 -0000 @@ -29,11 +29,12 @@ ;;; particular aspect. ;;; Use in Gnus like this: +;;; (require 'encrypt) ;;; (setq ;;; nnimap-authinfo-file "~/.authinfo.enc" ;;; nntp-authinfo-file "~/.authinfo.enc" ;;; smtpmail-auth-credentials "~/.authinfo.enc" -;;; ;; using the AES256 cipher, feel free to use your own favorite +;;; ;; GnuPG using the AES256 cipher, feel free to use your own favorite ;;; encrypt-file-alist (quote (("~/.authinfo.enc" (gpg "AES256")))) ;;; password-cache-expiry 600) @@ -53,7 +54,9 @@ ;; autoload password (eval-and-compile - (autoload 'password-read "password")) + (if (locate-library "password-cache") + (require 'password-cache) + (require 'password))) (defgroup encrypt '((password-cache custom-variable) (password-cache-expiry custom-variable)) Index: netrc.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/netrc.el,v retrieving revision 7.17 diff -u -r7.17 netrc.el --- netrc.el 9 Dec 2007 00:04:21 -0000 7.17 +++ netrc.el 17 Dec 2007 22:55:28 -0000 @@ -34,6 +34,10 @@ ;;; .netrc and .authinfo rc parsing ;;; +;; use encrypt if loaded (but netrc-use-encrypt also has to be on) +(eval-and-compile + (autoload 'encrypt-find-model "encrypt") + (autoload 'encrypt-insert-file-contents "encrypt")) (defalias 'netrc-point-at-eol (if (fboundp 'point-at-eol) 'point-at-eol @@ -54,8 +58,12 @@ (let ((tokens '("machine" "default" "login" "password" "account" "macdef" "force" "port")) + (encryption-model (when (bound-and-true-p encrypt-file-alist) + (encrypt-find-model file))) alist elem result pair) - (insert-file-contents file) + (if encryption-model + (encrypt-insert-file-contents file encryption-model) + (insert-file-contents file)) (goto-char (point-min)) ;; Go through the file, line by line. (while (not (eobp)) ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: emacs->gnus merge questions 2007-12-17 23:02 ` Ted Zlatanov 2007-12-17 23:03 ` Ted Zlatanov @ 2007-12-18 20:25 ` Ted Zlatanov 2007-12-18 22:52 ` encrypt.el glue to PGG library added (was: emacs->gnus merge questions) Ted Zlatanov 2008-02-16 13:12 ` encrypt.el " Reiner Steib 2 siblings, 1 reply; 21+ messages in thread From: Ted Zlatanov @ 2007-12-18 20:25 UTC (permalink / raw) To: ding On Mon, 17 Dec 2007 17:02:35 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: TZ> On Tue, 11 Dec 2007 10:22:50 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: TZ> On Sat, 08 Dec 2007 20:38:29 +0100 Reiner Steib <reinersteib+gmane@imap.cc> wrote: RS> On Sat, Dec 08 2007, Miles Bader wrote: >>>> I'm doing the back-merge from the Emacs trunk to the Gnus trunk. >>>> >>>> There are some changes which may or may not be appropriate for Gnus: >>>> >>>> (1) deleted: encrypt.el RS> I'm not sure about this one. Ted? TZ> It would be great if it could stay somewhere, maybe under contrib/ TZ> because I know at least 2 people use it. Also, can we have a TZ> conditional use in netrc.el if it's loaded? I don't want to redefine TZ> netrc functionality as well for everyone that wants to use it. TZ> If it can stay, I'll need to change its library requirements from TZ> password to password-cache as previously discussed. TZ> I am including a patch (not comitted yet) which changes encrypt.el docs TZ> to specifically say a (require) call is needed, and uses the TZ> (load-library) idea Glen Morris posted earlier to pick between TZ> password.el and password-cache.el. I like its brevity :) TZ> The patch also changes netrc.el to work with or without encrypt.el; when TZ> encrypt.el is loaded and encrypt-file-alist is not nil (using the TZ> (bound-and-true-p) macro from bindings.el) the netrc.el code behaves as TZ> before; otherwise it will just insert the netrc file contents normally. TZ> Will this work in XEmacs? TZ> Please review the patch and let me know if encrypt.el is staying in TZ> gnus/contrib or if I should host it separately. Either way, the patch TZ> should be applied if everyone agrees it will work OK. I am comitting this patch, assuming encrypt.el will remain within Gnus. Ted ^ permalink raw reply [flat|nested] 21+ messages in thread
* encrypt.el glue to PGG library added (was: emacs->gnus merge questions) 2007-12-18 20:25 ` Ted Zlatanov @ 2007-12-18 22:52 ` Ted Zlatanov 0 siblings, 0 replies; 21+ messages in thread From: Ted Zlatanov @ 2007-12-18 22:52 UTC (permalink / raw) To: ding I added an encrypt.el option (for encrypt-file-alist) to use PGG as the encode/decode option. It currently only uses the symmetric functionality and lets PGG do all the cipher and passphrase management. If you want me to add more PGG glue, let me know. I also reworked the encrypt.el API to be a bit nicer, using more temporary buffers in a few places. Please let me know if you need anything in the encrypt.el library. I currently use it to keep my NNTP, SMTP, IMAP, POP, etc. passwords encrypted in a single place with netrc.el. If you can think of any other places in Gnus where encryption would make sense, let me know. Thanks Ted ^ permalink raw reply [flat|nested] 21+ messages in thread
* encrypt.el (was: emacs->gnus merge questions) 2007-12-17 23:02 ` Ted Zlatanov 2007-12-17 23:03 ` Ted Zlatanov 2007-12-18 20:25 ` Ted Zlatanov @ 2008-02-16 13:12 ` Reiner Steib 2008-02-28 14:55 ` encrypt.el Ted Zlatanov 2 siblings, 1 reply; 21+ messages in thread From: Reiner Steib @ 2008-02-16 13:12 UTC (permalink / raw) To: ding [ Sorry for the long delay. I'm trying to go through my ticked articles...] On Tue, Dec 18 2007, Ted Zlatanov wrote: > Please review the patch and let me know if encrypt.el is staying in > gnus/contrib or if I should host it separately. If you don't have a strong preference, I'd suggest to move encrypt.el to contrib/ to make it more clear that it is not part of Gnus bundled with Emacs. Please also add an entry to contrib/README. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: encrypt.el 2008-02-16 13:12 ` encrypt.el " Reiner Steib @ 2008-02-28 14:55 ` Ted Zlatanov 2008-02-28 20:28 ` encrypt.el Reiner Steib 0 siblings, 1 reply; 21+ messages in thread From: Ted Zlatanov @ 2008-02-28 14:55 UTC (permalink / raw) To: ding On Sat, 16 Feb 2008 14:12:26 +0100 Reiner Steib <reinersteib+gmane@imap.cc> wrote: RS> [ Sorry for the long delay. I'm trying to go through my ticked RS> articles...] RS> On Tue, Dec 18 2007, Ted Zlatanov wrote: >> Please review the patch and let me know if encrypt.el is staying in >> gnus/contrib or if I should host it separately. RS> If you don't have a strong preference, I'd suggest to move encrypt.el RS> to contrib/ to make it more clear that it is not part of Gnus bundled RS> with Emacs. Please also add an entry to contrib/README. I'd rather remove it in favor of EasyPG. I'll adjust the netrc.el code so it doesn't reference encrypt.el anymore, and uses EasyPG to load the same files. The only downside is that uses must install EasyPG to get those features, until it's part of Emacs (I don't know when that will happen, maybe after the next release?) Ted ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: encrypt.el 2008-02-28 14:55 ` encrypt.el Ted Zlatanov @ 2008-02-28 20:28 ` Reiner Steib 2008-03-10 15:06 ` encrypt.el Ted Zlatanov 0 siblings, 1 reply; 21+ messages in thread From: Reiner Steib @ 2008-02-28 20:28 UTC (permalink / raw) To: ding On Thu, Feb 28 2008, Ted Zlatanov wrote: > On Sat, 16 Feb 2008 14:12:26 +0100 Reiner Steib <reinersteib+gmane@imap.cc> wrote: > RS> On Tue, Dec 18 2007, Ted Zlatanov wrote: >>> [...] let me know if encrypt.el is staying in gnus/contrib or if I >>> should host it separately. > > RS> If you don't have a strong preference, I'd suggest to move encrypt.el > RS> to contrib/ to make it more clear that it is not part of Gnus bundled > RS> with Emacs. Please also add an entry to contrib/README. > > I'd rather remove it in favor of EasyPG. That's up to you. > I'll adjust the netrc.el code so it doesn't reference encrypt.el > anymore, and uses EasyPG to load the same files. > > The only downside is that uses must install EasyPG to get those > features, until it's part of Emacs (I don't know when that will happen, > maybe after the next release?) It is already in Emacs CVS. But it won't appear in Emacs 22.*. I don't know about XEmacs. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: encrypt.el 2008-02-28 20:28 ` encrypt.el Reiner Steib @ 2008-03-10 15:06 ` Ted Zlatanov 0 siblings, 0 replies; 21+ messages in thread From: Ted Zlatanov @ 2008-03-10 15:06 UTC (permalink / raw) To: ding On Thu, 28 Feb 2008 21:28:38 +0100 Reiner Steib <reinersteib+gmane@imap.cc> wrote: RS> On Thu, Feb 28 2008, Ted Zlatanov wrote: >> I'll adjust the netrc.el code so it doesn't reference encrypt.el >> anymore, and uses EasyPG to load the same files. >> >> The only downside is that uses must install EasyPG to get those >> features, until it's part of Emacs (I don't know when that will happen, >> maybe after the next release?) RS> It is already in Emacs CVS. But it won't appear in Emacs 22.*. I RS> don't know about XEmacs. Hm, I wonder if I should leave encrypt.el hooks in netrc.el or remove them. If I remove them, Emacs 22 users will have to get EasyPG and enable epa-file-mode on their own to encrypt their authinfo/netrc files. I could put up a warning if I detect encrypt-* variables after encrypt.el is remove, but that's annoying and about as much work as keeping encrypt.el around. I was hoping to remove encrypt.el altogether but am not sure after thinking about it. Does anyone have an opinion? Ted ^ permalink raw reply [flat|nested] 21+ messages in thread
* pop3.el itegration with netrc.el @ 2004-10-13 15:44 Ted Zlatanov 2004-10-14 18:21 ` Simon Josefsson 0 siblings, 1 reply; 21+ messages in thread From: Ted Zlatanov @ 2004-10-13 15:44 UTC (permalink / raw) pop3.el seems to be separate from the rest of Gnus, so I'm not sure if I should add netrc.el (authinfo) support to it - then pop3.el would also depend on gnus-encrypt.el. Please advise. Thanks Ted ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: pop3.el itegration with netrc.el 2004-10-13 15:44 pop3.el itegration with netrc.el Ted Zlatanov @ 2004-10-14 18:21 ` Simon Josefsson 2004-10-14 18:49 ` Reiner Steib 0 siblings, 1 reply; 21+ messages in thread From: Simon Josefsson @ 2004-10-14 18:21 UTC (permalink / raw) "Ted Zlatanov" <tzz@lifelogs.com> writes: > pop3.el seems to be separate from the rest of Gnus, so I'm not sure if > I should add netrc.el (authinfo) support to it - then pop3.el would > also depend on gnus-encrypt.el. Please advise. There are many incompatible forks of pop3.el, the copy in Gnus CVS used to be one of them. I see now that the copies in Gnus CVS and Emacs CVS are in sync. I'm not sure how that happened, but it is a good thing. So perhaps we can make this one the canonical copy, and add new features to it. I'd say go ahead. Btw, is it difficult to modularize gnus-encrypt.el into, say, encrypt.el, that doesn't use a lot of Gnus functions? I recall some discussions about that, though. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: pop3.el itegration with netrc.el 2004-10-14 18:21 ` Simon Josefsson @ 2004-10-14 18:49 ` Reiner Steib 2004-10-14 19:01 ` Simon Josefsson 0 siblings, 1 reply; 21+ messages in thread From: Reiner Steib @ 2004-10-14 18:49 UTC (permalink / raw) [-- Attachment #1: Type: text/plain, Size: 1649 bytes --] On Thu, Oct 14 2004, Simon Josefsson wrote: > "Ted Zlatanov" <tzz@lifelogs.com> writes: > >> pop3.el seems to be separate from the rest of Gnus, so I'm not sure if >> I should add netrc.el (authinfo) support to it - then pop3.el would >> also depend on gnus-encrypt.el. Please advise. > > There are many incompatible forks of pop3.el, the copy in Gnus CVS > used to be one of them. I see now that the copies in Gnus CVS and > Emacs CVS are in sync. I'm not sure how that happened, but it is a > good thing. I've merged the changes from Emacs to Gnus initially and Miles keeps them in sync now. The most important thing was `pop3-leave-mail-on-server'. I'm not sure if this feature (introduced in Emacs) was a good idea in the first place (and I don't know if it works reliably [1]). But if upgrading from Gnus 5.9 to 5.11 would suddenly delete the mails on the server after pop (when `pop3-leave-mail-on-server' is ignored as in Gnus 5.10.6), people won't be happy ("Gnus deleted all my mail!!!1"). > So perhaps we can make this one the canonical copy, and add new > features to it. I'd say go ahead. Dave Love pointed out that `pop3.el' could be used outside Gnus and suggested to remove the nn-whatever dependencies. If we think that this is a valuable goal, we should avoid adding further dependencies. ,----[ http://thread.gmane.org/gmane.emacs.pretest.bugs/3974 ] | pop3.el shouldn't use nnheader-accept-process-output, so it can be | used outside Gnus. `---- Bye, Reiner. [1] I think I'll add a warning, see the attached patch. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: rs-pop-leave.patch --] [-- Type: text/x-patch, Size: 2058 bytes --] Index: lisp/pop3.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/pop3.el,v retrieving revision 6.23.2.2 diff -u -r6.23.2.2 pop3.el --- lisp/pop3.el 22 Aug 2004 21:48:11 -0000 6.23.2.2 +++ lisp/pop3.el 30 Aug 2004 16:43:52 -0000 @@ -55,7 +55,14 @@ values are 'apop.") (defvar pop3-leave-mail-on-server nil - "*Non-nil if the mail is to be left on the POP server after fetching.") + "*Non-nil if the mail is to be left on the POP server after fetching. + +If the `pop3-leave-mail-on-server' is non-`nil' the mail is to be +left on the POP server after fetching. Note that POP servers +maintain no state information between sessions, so what the +client believes is there and what is actually there may not match +up. If they do not, then the whole thing can fall apart and +leave you with a corrupt mailbox.") (defvar pop3-timestamp nil "Timestamp returned when initially connected to the POP server. Index: texi/gnus.texi =================================================================== RCS file: /usr/local/cvsroot/gnus/texi/gnus.texi,v retrieving revision 6.603.2.4 diff -u -r6.603.2.4 gnus.texi --- texi/gnus.texi 26 Aug 2004 09:59:57 -0000 6.603.2.4 +++ texi/gnus.texi 30 Aug 2004 16:43:53 -0000 @@ -13528,10 +13528,16 @@ @end table +@vindex pop3-movemail +@vindex pop3-leave-mail-on-server If the @code{:program} and @code{:function} keywords aren't specified, @code{pop3-movemail} will be used. If the @code{pop3-leave-mail-on-server} is non-@code{nil} the mail is to be -left on the POP server after fetching. +left on the @acronym{POP} server after fetching when using +@code{pop3-movemail}. Note that POP servers maintain no state +information between sessions, so what the client believes is there and +what is actually there may not match up. If they do not, then the whole +thing can fall apart and leave you with a corrupt mailbox. Here are some examples. Fetch from the default @acronym{POP} server, using the default user name, and default fetcher: ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: pop3.el itegration with netrc.el 2004-10-14 18:49 ` Reiner Steib @ 2004-10-14 19:01 ` Simon Josefsson 2004-10-14 19:52 ` Reiner Steib 0 siblings, 1 reply; 21+ messages in thread From: Simon Josefsson @ 2004-10-14 19:01 UTC (permalink / raw) Reiner Steib <reinersteib+gmane@imap.cc> writes: >> So perhaps we can make this one the canonical copy, and add new >> features to it. I'd say go ahead. > > Dave Love pointed out that `pop3.el' could be used outside Gnus and > suggested to remove the nn-whatever dependencies. If we think that > this is a valuable goal, we should avoid adding further dependencies. > > ,----[ http://thread.gmane.org/gmane.emacs.pretest.bugs/3974 ] > | pop3.el shouldn't use nnheader-accept-process-output, so it can be > | used outside Gnus. > `---- I agree, but I wouldn't consider netrc.el, password.el nor encrypt.el as something part of Gnus, even though they technically are. They are (or will be) small standalone libraries. But the nn* dependency is bad, using nn* will lead to loading parts of Gnus. Can't we write a pop3-accept-process-output, and drop the nnheader dependency? Seems simple. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: pop3.el itegration with netrc.el 2004-10-14 19:01 ` Simon Josefsson @ 2004-10-14 19:52 ` Reiner Steib 2004-10-14 22:39 ` Simon Josefsson 0 siblings, 1 reply; 21+ messages in thread From: Reiner Steib @ 2004-10-14 19:52 UTC (permalink / raw) On Thu, Oct 14 2004, Simon Josefsson wrote: > I agree, but I wouldn't consider netrc.el, password.el nor encrypt.el > as something part of Gnus, even though they technically are. They are > (or will be) small standalone libraries. Ah, sorry. I didn't know that `[gnus-]encrypt.el' (Ted wrote "pop3.el would also depend on gnus-encrypt.el") has no real Gnus dependencies. > But the nn* dependency is bad, using nn* will lead to loading parts of > Gnus. Can't we write a pop3-accept-process-output, and drop the > nnheader dependency? Seems simple. I didn't look at it in detail. We'd probably have to duplicate `nnheader-accept-process-output' and the strange `nnheader-read-timeout' thingie. I would be glad if you could fix this. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: pop3.el itegration with netrc.el 2004-10-14 19:52 ` Reiner Steib @ 2004-10-14 22:39 ` Simon Josefsson 2004-10-15 17:08 ` Ted Zlatanov 0 siblings, 1 reply; 21+ messages in thread From: Simon Josefsson @ 2004-10-14 22:39 UTC (permalink / raw) Reiner Steib <reinersteib+gmane@imap.cc> writes: >> But the nn* dependency is bad, using nn* will lead to loading parts of >> Gnus. Can't we write a pop3-accept-process-output, and drop the >> nnheader dependency? Seems simple. > > I didn't look at it in detail. We'd probably have to duplicate > `nnheader-accept-process-output' and the strange > `nnheader-read-timeout' thingie. I would be glad if you could fix > this. Done. I hope it will be merged automatically to Emacs CVS (that gateway is quite neat, btw!). Perhaps emacs/lisp/gnus/pop3.el should be moved to emacs/lisp/net/? People seem to be afraid of using files from gnus/. And now pop3.el is standalone. What do you think? ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: pop3.el itegration with netrc.el 2004-10-14 22:39 ` Simon Josefsson @ 2004-10-15 17:08 ` Ted Zlatanov 2004-10-15 18:07 ` Reiner Steib 0 siblings, 1 reply; 21+ messages in thread From: Ted Zlatanov @ 2004-10-15 17:08 UTC (permalink / raw) Cc: ding [-- Attachment #1: Type: text/plain, Size: 516 bytes --] I'm attaching the new encrypt.el (mostly gnus-encrypt.el minus cruft and with a search&replace done) and the related netrc.el (just search&replace of gnus-encrypt with encrypt). Let me know if it looks OK before I put it into Gnus. gnus-encrypt.el will become a shallow wrapper with no options for now if this conversion happens. If password.el, netrc.el, encrypt.el, and pop3.el move to Emacs, that's OK but I don't have CVS access to Emacs source code so it will be harder for me to maintain those files. Ted [-- Attachment #2: netrc.el --] [-- Type: application/emacs-lisp, Size: 6523 bytes --] [-- Attachment #3: encrypt.el --] [-- Type: application/emacs-lisp, Size: 9201 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: pop3.el itegration with netrc.el 2004-10-15 17:08 ` Ted Zlatanov @ 2004-10-15 18:07 ` Reiner Steib 2004-10-15 19:14 ` encrypt.el (was: pop3.el itegration with netrc.el) Ted Zlatanov 0 siblings, 1 reply; 21+ messages in thread From: Reiner Steib @ 2004-10-15 18:07 UTC (permalink / raw) On Fri, Oct 15 2004, Ted Zlatanov wrote: > If password.el, netrc.el, encrypt.el, and pop3.el move to Emacs, > that's OK but I don't have CVS access to Emacs source code so it will > be harder for me to maintain those files. netrc.el has already been "moved to Emacs" a long time ago. This doesn't mean that you cannot maintain the files anymore. Changes in v5-10/lisp/netrc.el should still be merged into Emacs (follow the URL for more): ,----[ http://thread.gmane.org/20041010225828.GA31829@fencepost ] | From: Miles Bader <miles@lsi.nec.co.jp> | Subject: Re: [rmail-mbox-branch]: mail-utils | Date: Tue, 12 Oct 2004 11:09:11 +0900 | Message-ID: <buoy8ick7qw.fsf@mctpc71.ucom.lsi.nec.co.jp> | | Richard Stallman <rms@gnu.org> writes: | > Do you mean that a patch from a gnus maintainer would have to be | > posted to the mailing list to be put into emacs (unlike Gnus | > changes)? | > | > I mean they should treat these files the same way they treat all the | > other Lisp files that are not part of Gnus. That does not mean ALL | > changes have to be discussed. They can install local uncontroversial | > bug fixes without discussion, just as any of us would. However, | > beyond that, they ought to post on this list. | | Ok, that sounds reasonable, and workable in practice for my Gnus-syncing. `---- password.el and encrypt.el (tla, ...) are new in No Gnus. So these files will not be considered now, I think. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* encrypt.el (was: pop3.el itegration with netrc.el) 2004-10-15 18:07 ` Reiner Steib @ 2004-10-15 19:14 ` Ted Zlatanov [not found] ` <iluwtxrvkfb.fsf@latte.josefsson.org> 0 siblings, 1 reply; 21+ messages in thread From: Ted Zlatanov @ 2004-10-15 19:14 UTC (permalink / raw) Cc: emacs-devel [-- Attachment #1: Type: text/plain, Size: 675 bytes --] On Fri, 15 Oct 2004, reinersteib+gmane@imap.cc wrote: > password.el and encrypt.el (tla, ...) are new in No Gnus. So these > files will not be considered now, I think. encrypt.el should be general-purpose enough that it can be outside Gnus itself. I would like it to be part of Emacs, not just Gnus, because encryption is important to users and Emacs doesn't come with much built-in for handling encryption. I'm attaching a copy, the same (as of now) as the one in the Gnus CVS HEAD. Can anyone comment on the likelihood of inclusion in Emacs? The current list of encryption methods is minimal but can be easily expanded. The API is IMHO more important. Thanks Ted [-- Attachment #2: encrypt.el --] [-- Type: application/emacs-lisp, Size: 9233 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
[parent not found: <iluwtxrvkfb.fsf@latte.josefsson.org>]
[parent not found: <E1CIozF-00034v-V7@fencepost.gnu.org>]
[parent not found: <4n4qkrvrwu.fsf@lifelogs.com>]
[parent not found: <E1CJx6h-0000Ns-QW@fencepost.gnu.org>]
[parent not found: <4nsm87vrgk.fsf@lifelogs.com>]
[parent not found: <4nr7m9j1ah.fsf@lifelogs.com>]
* Re: encrypt.el [not found] ` <4nr7m9j1ah.fsf@lifelogs.com> @ 2004-12-01 22:12 ` Reiner Steib 2004-12-02 16:36 ` encrypt.el Ted Zlatanov 0 siblings, 1 reply; 21+ messages in thread From: Reiner Steib @ 2004-12-01 22:12 UTC (permalink / raw) Cc: ding On Wed, Dec 01 2004, Ted Zlatanov wrote: > I need to clarify, however, how encrypt.el will coexist with the > Gnus version. Should I remove encrypt.el from Gnus, or leave it in > as a duplicate of the Emacs tree version? [I think you mean Gnus repository here, right?] No Gnus is supposed to run on Emacs 21.1 (and up) and XEmacs 21.4 (and up). Wouldn't removing encrypt.el break running Gnus on versions before Emacs 21.4? Bye, Reiner. [ Cc-ing Ding, trimming xemacs-beta ] -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: encrypt.el 2004-12-01 22:12 ` encrypt.el Reiner Steib @ 2004-12-02 16:36 ` Ted Zlatanov 2004-12-02 20:56 ` encrypt.el Reiner Steib 2004-12-07 17:50 ` encrypt.el Ted Zlatanov 0 siblings, 2 replies; 21+ messages in thread From: Ted Zlatanov @ 2004-12-02 16:36 UTC (permalink / raw) Cc: ding On Wed, 01 Dec 2004, reinersteib+gmane@imap.cc wrote: On Wed, Dec 01 2004, Ted Zlatanov wrote: > >> I need to clarify, however, how encrypt.el will coexist with the >> Gnus version. Should I remove encrypt.el from Gnus, or leave it in >> as a duplicate of the Emacs tree version? > > [I think you mean Gnus repository here, right?] Gnus CVS is synchronized with Emacs these days, so it would be both. > No Gnus is supposed to run on Emacs 21.1 (and up) and XEmacs 21.4 (and > up). Wouldn't removing encrypt.el break running Gnus on versions > before Emacs 21.4? Yes, and I'll leave it in on yours and Simon Josefsson's advice. So I will only add encrypt.el to the Emacs lisp/ tree without removing it from anywhere else. I do wish that CVS supported symlinks :) Ted ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: encrypt.el 2004-12-02 16:36 ` encrypt.el Ted Zlatanov @ 2004-12-02 20:56 ` Reiner Steib 2004-12-07 17:50 ` encrypt.el Ted Zlatanov 1 sibling, 0 replies; 21+ messages in thread From: Reiner Steib @ 2004-12-02 20:56 UTC (permalink / raw) Cc: ding On Thu, Dec 02 2004, Ted Zlatanov wrote: > On Wed, 01 Dec 2004, reinersteib+gmane@imap.cc wrote: [...] >> [I think you mean Gnus repository here, right?] > > Gnus CVS is synchronized with Emacs these days, so it would be both. I think that Miles can do the syncing independent of the location, e.g. [v5-10]gnus/lisp/netrc.el <--> emacs/lisp/net/net/netrc.el BTW, should `encrypt.el' go in the stable branch (v5-10), too? Maybe we already discussed this, but I forgot. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: encrypt.el 2004-12-02 16:36 ` encrypt.el Ted Zlatanov 2004-12-02 20:56 ` encrypt.el Reiner Steib @ 2004-12-07 17:50 ` Ted Zlatanov 1 sibling, 0 replies; 21+ messages in thread From: Ted Zlatanov @ 2004-12-07 17:50 UTC (permalink / raw) Cc: ding I'll hold off on the encrypt.el migration until after the next Emacs release, as requested. Thanks for all the help Ted ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2008-03-10 15:06 UTC | newest] Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2007-12-08 3:24 emacs->gnus merge questions Miles Bader 2007-12-08 19:38 ` Reiner Steib 2007-12-08 21:19 ` Miles Bader 2007-12-08 21:29 ` Reiner Steib 2007-12-08 23:32 ` Miles Bader 2007-12-08 23:45 ` Miles Bader 2008-02-16 13:24 ` encrypt.el (was: emacs->gnus merge questions) Reiner Steib 2008-02-16 13:26 ` assistant.el " Reiner Steib 2007-12-11 16:22 ` emacs->gnus merge questions Ted Zlatanov 2007-12-17 23:02 ` Ted Zlatanov 2007-12-17 23:03 ` Ted Zlatanov 2007-12-18 20:25 ` Ted Zlatanov 2007-12-18 22:52 ` encrypt.el glue to PGG library added (was: emacs->gnus merge questions) Ted Zlatanov 2008-02-16 13:12 ` encrypt.el " Reiner Steib 2008-02-28 14:55 ` encrypt.el Ted Zlatanov 2008-02-28 20:28 ` encrypt.el Reiner Steib 2008-03-10 15:06 ` encrypt.el Ted Zlatanov -- strict thread matches above, loose matches on Subject: below -- 2004-10-13 15:44 pop3.el itegration with netrc.el Ted Zlatanov 2004-10-14 18:21 ` Simon Josefsson 2004-10-14 18:49 ` Reiner Steib 2004-10-14 19:01 ` Simon Josefsson 2004-10-14 19:52 ` Reiner Steib 2004-10-14 22:39 ` Simon Josefsson 2004-10-15 17:08 ` Ted Zlatanov 2004-10-15 18:07 ` Reiner Steib 2004-10-15 19:14 ` encrypt.el (was: pop3.el itegration with netrc.el) Ted Zlatanov [not found] ` <iluwtxrvkfb.fsf@latte.josefsson.org> [not found] ` <E1CIozF-00034v-V7@fencepost.gnu.org> [not found] ` <4n4qkrvrwu.fsf@lifelogs.com> [not found] ` <E1CJx6h-0000Ns-QW@fencepost.gnu.org> [not found] ` <4nsm87vrgk.fsf@lifelogs.com> [not found] ` <4nr7m9j1ah.fsf@lifelogs.com> 2004-12-01 22:12 ` encrypt.el Reiner Steib 2004-12-02 16:36 ` encrypt.el Ted Zlatanov 2004-12-02 20:56 ` encrypt.el Reiner Steib 2004-12-07 17:50 ` encrypt.el Ted Zlatanov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).