Re: Emacs unicode merge changes to Gnus

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Wed, Feb 06 2008, Miles Bader wrote:

> I've appended a patch file below; let me know if you see anything
> suspicious.

See below.

> [I eliminated some changes to contrib/ (unicode branch changes to
> sendmail.el, deletion of ucs-tables.el), because as I understand it
> those files are intended for people with old versions of emacs, so
> changes specific to new versions of Emacs should not be applied to
> them.]

Correct.  These are not for Emacs 22 and up.

> 2008-02-01  Zhang Wei  <id.brep@gmail.com>
>
> 	* rfc2047.el (rfc2047-charset-encoding-alist): Add gbk and GB18030.

This doesn't do any harm, AFAICS.

,----[ <f1> v rfc2047-charset-encoding-alist RET ]
| Documentation:
| Alist of MIME charsets to RFC2047 encodings.
| Valid encodings are nil, `Q' and `B'.  These indicate binary (no) encoding,
| quoted-printable and base64 respectively.
`----

> 	* mm-util.el (mm-mime-mule-charset-alist): Add gbk and GB18030.

Similar here.

> 2008-02-01  Miles Bader  <miles@gnu.org>
>
> 	* mml.el (mml-parse-1): Remove apparently vestigial use of
> 	`mm-hack-charsets'.
> 	* mm-bodies.el (mm-encode-body): Likewise.
[...]
> 2008-02-01  Dave Love  <fx@gnu.org>
[...]
> 	* mm-util.el (mm-hack-charsets, mm-iso-8859-15-compatible)
> 	(mm-iso-8859-x-to-15-table, mm-iso-8859-x-to-15-region): Deleted.
> 	(mm-find-mime-charset-region): Remove hack-charsets stuff.

I think this changes should be reverted.  AFAIK, `mm-hack-charsets' is
used for Emacs 21.[12] (w/o ucs-tables.el) and maybe XEmacs.  Does
anyone see any problem in keeping `mm-hack-charsets' in Emacs 23?

> 2008-02-01  Kenichi Handa  <handa@m17n.org>
>
> 	* rfc2104.el (rfc2104-hexstring-to-byte-list): Renamed from
> 	rfc2104-hexstring-to-bitstring and changed to return a byte list.
> 	(rfc2104-hash): Convert the result of concat to unibyte string.

`rfc2104.el' is only used in mail/smtpmail.el and net/imap.el, AFAICS.
Maybe Simon can comment on this.

> 2008-02-01  Dave Love  <fx@gnu.org>
>
> 	* gnus-start.el (gnus-read-newsrc-el-file): Don't bind
> 	coding-system-for-read.
> 	(gnus-gnus-to-quick-newsrc-format): Insert coding cookie.

--8<---------------cut here---------------start------------->8---
--- gnus-start.el	8 Jan 2008 20:45:12 -0000	1.59
+++ gnus-start.el	1 Feb 2008 16:01:20 -0000	1.60
@@ -463,6 +463,8 @@
 
 ;;; Internal variables
 
+;; Fixme: deal with old emacs-mule when mm-universal-coding-system is
+;; utf-8-emacs.
 (defvar gnus-ding-file-coding-system mm-universal-coding-system
   "Coding system for ding file.")
 
@@ -2404,8 +2406,7 @@
       ;; We always, always read the .eld file.
       (gnus-message 5 "Reading %s..." ding-file)
       (let (gnus-newsrc-assoc)
-	(let ((coding-system-for-read gnus-ding-file-coding-system))
-	  (gnus-load ding-file))
+	(gnus-load ding-file)
 	;; Older versions of `gnus-format-specs' are no longer valid
 	;; in Oort Gnus 0.01.
 	(let ((version
@@ -2837,7 +2838,8 @@
 
 (defun gnus-gnus-to-quick-newsrc-format (&optional minimal name &rest specific-variables)
   "Print Gnus variables such as `gnus-newsrc-alist' in Lisp format."
-    (princ ";; -*- emacs-lisp -*-\n")
+    (princ (format ";; -*- mode:emacs-lisp; coding: %s; -*-\n"
+		   gnus-ding-file-coding-system))
--8<---------------cut here---------------end--------------->8---

This could cause problems for people switching (from Emacs 23) to
Emacs <= 22 (or XEmacs).  AFAICS, Emacs 21 and 22 simply ignore the
cookie if the coding is unknown.  I'd expect problems for people using
e.g. non-ASCII group names.  Any ideas how to fix this problem?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/