Re: The return of starttls doesn't work in smtpmail

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Fri, Aug 17 2007, Wolfram Fenske wrote:

> According to
> <http://quimby.gnus.org/cgi-bin/cvsweb.cgi/gnus/contrib/smtpmail.el>,
> smptmail.el still isn't fixed.  

,----[ contrib/README ]
| sendmail.el
| smtpmail.el
| 
| 	Copies of the corresponding files from the Emacs lisp/mail/
| 	directory, to provide features (occasionally) needed by Gnus which
| 	may not be provided by the versions of these files in older Emacs
| 	distributions.  XEmacs users should NOT use this, since it doesn't
| 	work.  See the XEmacs mail-lib module instead.
`----

In contrib/smtpmail.el we even have:

;; This version of `smtpmail.el' should only be used with Emacs 21.
(if (featurep 'xemacs)
    (error "Please use `smtpmail.el' from the mail-lib package.")
  (when (>= emacs-major-version 22)
    (error "Please use `smtpmail.el' bundled with Emacs.")))

So it should be fixed in XEmacs or the smtpmail.el file in XEmacs
mail-lib package.

> ;;; XEmacs and older Emacs might not have `with-no-warnings'
> (unless (fboundp 'with-no-warnings)
>   ;; Taken from Emacs' byte-run.el
>   (defun with-no-warnings (&rest body)
>     "Like `progn', but prevents compiler warnings in the body."
>     ;; The implementation for the interpreter is basically trivial.
>     (car (last body))))

This is a bad idea.

,----[ (info "(elisp)Coding Conventions") ]
|    * If a package needs to define an alias or a new function for
|      compatibility with some other version of Emacs, name it with the
|      package prefix, not with the raw name with which it occurs in the
|      other version.  Here is an example from Gnus, which provides many
|      examples of such compatibility issues.
| 
|           (defalias 'gnus-point-at-bol
|             (if (fboundp 'point-at-bol)
|                 'point-at-bol
|               'line-beginning-position))
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/