From: Reiner Steib <reinersteib+gmane@imap.cc>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Gtk+ stock tool bar icons
Date: Sun, 30 Sep 2007 13:25:15 +0200 [thread overview]
Message-ID: <v9r6kg1jl0.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <46FF6F03.1080509@swipnet.se> ("Jan =?iso-8859-1?Q?Dj=E4rv=22?= =?iso-8859-1?Q?'s?= message of "Sun, 30 Sep 2007 11:40:19 +0200")
On Sun, Sep 30 2007, Jan Djärv wrote:
> Reiner Steib skrev:
>> On a second thought: Maybe `icon-map-list' seems more suitable to
>> disable it. How about making it `icon-map-list' customizable and
>> improving the custom type of `x-gtk-stock-map' as follows?
>
> Ok with me.
I have committed the following changes (only in the trunk yet):
* term/x-win.el (x-gtk-stock-map): Add Gnus and MH-E icons.
Improve custom type.
(icon-map-list): Make it customizable. Document how to disable
stock icons.
Please take a look if and correct if necessary. Thanks.
>>>> - Is my patch [3] correct?
>>> No, the files should be "images/mail/...".
>>
>> Are you saying without "etc/"? I did it exactly like the present
>> elements:
>
> Yes I know. But the document string says "file names without extension and
> with two directory components".
Ah, it's only in the doc string of `icon-map-list' and not
`x-gtk-stock-map'. To avoid duplication of the description, shouldn't
we describe the format in detail only in the doc string of
`icon-map-list' and refer to it in the doc string of
`x-gtk-stock-map'?
FWIW, removing "etc/" doesn't improve the Gnus tool bars for me.
> The reason for this is to avoid having to search the image path
> first and then do the translation. Also, two is enough to
> distinguish the default setup.
So it's more or less an implementation detail? For a user variable,
it would be nicer to make it consistent with
`tool-bar-add-item-from-menu' etc., I think.
>> BTW, wouldn't it be better to strip "etc/images/" in the icon names
>> for consistency with the specification of the icons e.g. in
>> `tool-bar-add-item-from-menu' (cf. `image-load-path')?
>
> I guess that would work also. I'll fix that.
Thanks.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next prev parent reply other threads:[~2007-09-30 11:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 13:45 Reiner Steib
2007-09-29 16:29 ` Jan Djärv
2007-09-29 19:55 ` Reiner Steib
2007-09-30 9:40 ` Jan Djärv
2007-09-30 11:25 ` Reiner Steib [this message]
2007-09-30 3:04 ` Richard Stallman
2007-09-30 9:41 ` Jan Djärv
2007-09-30 10:48 ` Reiner Steib
2007-10-01 1:36 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9r6kg1jl0.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).