From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65299 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Gtk+ stock tool bar icons Date: Sun, 30 Sep 2007 13:25:15 +0200 Message-ID: References: <46FE7D84.4000503@swipnet.se> <46FF6F03.1080509@swipnet.se> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1191151544 30790 80.91.229.12 (30 Sep 2007 11:25:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 30 Sep 2007 11:25:44 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: Jan =?iso-8859-1?Q?Dj=E4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 30 13:25:40 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IbwvW-0003fH-9D for ged-emacs-devel@m.gmane.org; Sun, 30 Sep 2007 13:25:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbwvS-0001Fg-GD for ged-emacs-devel@m.gmane.org; Sun, 30 Sep 2007 07:25:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IbwvO-0001FK-Pk for emacs-devel@gnu.org; Sun, 30 Sep 2007 07:25:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IbwvN-0001Es-IN for emacs-devel@gnu.org; Sun, 30 Sep 2007 07:25:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbwvN-0001Ep-CW for emacs-devel@gnu.org; Sun, 30 Sep 2007 07:25:25 -0400 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IbwvM-0007kv-L9 for emacs-devel@gnu.org; Sun, 30 Sep 2007 07:25:24 -0400 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.1/8.14.1) with ESMTP id l8UBPM22015162; Sun, 30 Sep 2007 13:25:22 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 1CAFB12C67; Sun, 30 Sep 2007 13:25:22 +0200 (CEST) X-Face: 3Phac&+dw=IZHjhua]bp}LH<*p{qzj8u+ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80051 gmane.emacs.gnus.general:65299 Archived-At: On Sun, Sep 30 2007, Jan Dj=E4rv wrote: > Reiner Steib skrev: >> On a second thought: Maybe `icon-map-list' seems more suitable to >> disable it. How about making it `icon-map-list' customizable and >> improving the custom type of `x-gtk-stock-map' as follows? > > Ok with me. I have committed the following changes (only in the trunk yet): * term/x-win.el (x-gtk-stock-map): Add Gnus and MH-E icons. Improve custom type. (icon-map-list): Make it customizable. Document how to disable stock icons. Please take a look if and correct if necessary. Thanks. >>>> - Is my patch [3] correct? >>> No, the files should be "images/mail/...". >> >> Are you saying without "etc/"? I did it exactly like the present >> elements: > > Yes I know. But the document string says "file names without extension= and > with two directory components". =20 Ah, it's only in the doc string of `icon-map-list' and not `x-gtk-stock-map'. To avoid duplication of the description, shouldn't we describe the format in detail only in the doc string of `icon-map-list' and refer to it in the doc string of `x-gtk-stock-map'? FWIW, removing "etc/" doesn't improve the Gnus tool bars for me. > The reason for this is to avoid having to search the image path > first and then do the translation. Also, two is enough to > distinguish the default setup. So it's more or less an implementation detail? For a user variable, it would be nicer to make it consistent with `tool-bar-add-item-from-menu' etc., I think. >> BTW, wouldn't it be better to strip "etc/images/" in the icon names >> for consistency with the specification of the icons e.g. in >> `tool-bar-add-item-from-menu' (cf. `image-load-path')? > > I guess that would work also. I'll fix that. Thanks. Bye, Reiner. --=20 ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/