Re: [PATCH] XEmacs compatiblity.

Re: [PATCH] XEmacs compatiblity.

[Reiner Steib]

[ Directing this to ding@gnus to reach more developers. ]

On Fri, Jul 07 2006, Andrey Slusar wrote:

> In xemacs 21.4 is not found `default-process-coding-system', in xemacs
> 21.5 found and nil value is not valid - it's different when in gnu
> emacs. I propose for change `default-process-coding-system' to
> `coding-system-for-read/write'. 

I don't understand why your patch also changes the behavior in Emacs
(which is correct AFAIK).

Is...

  (let ((coding-system-for-read 'binary)
        (coding-system-for-write 'binary))
    (do-some-thing))

... the same as...

  (let (default-process-coding-system)
    (do-some-thing))

... in Emacs 21, Emacs 22 and XEmacs 21.5?

A quick glance at (info "(elisp)Default Coding Systems") and (info
"(elisp)Specifying Coding Systems") didn't make it clear to me.


BTW, there are already two "tiny" changes from you in Gnus.  I'm
afraid that your accumulated changes are more than the `tiny change'
limit (10-15 lines) and we cannot install further changes by you.

[ Probably you know the following, but just in case, I repeat it here: ]
Gnus is a part of Emacs and since Emacs is a core GNU project, the
Free Software Foundation (FSF) requires an assignment of copyright for
contributions, so that it is able to defend Emacs' legal status
without doubts, should the need arise.  You can either sign papers
only for Gnus or for Emacs (which covers Gnus, too).  If you agree, I
can send you the necessary form.

> See patch:
>
> --- lisp/gnus/binhex.el	Sun Feb  5 15:56:44 2006
> +++ lisp/gnus/binhex.el	Thu Apr 13 12:15:52 2006
> @@ -289,7 +289,9 @@
>      (save-excursion
>        (goto-char start)
>        (when (re-search-forward binhex-begin-line nil t)
> -	(let ((cdir default-directory) default-process-coding-system)
> +	(let ((cdir default-directory)
> +	      (coding-system-for-read 'binary)
> +	      (coding-system-for-write 'binary))
>  	  (unwind-protect
>  	      (progn
>  		(set-buffer (setq work-buffer
> --- lisp/gnus/uudecode.el	Tue Jul  4 16:41:44 2006
> +++ lisp/gnus/uudecode.el	Thu Apr 13 12:15:58 2006
> @@ -100,11 +100,8 @@
>  			      (make-temp-name "uu")
>  			      uudecode-temporary-file-directory))))
>  	(let ((cdir default-directory)
> -	      (default-process-coding-system
> -		(if (featurep 'xemacs)
> -		    ;; In XEmacs, `nil' is not a valid coding system.
> -		    '(binary . binary)
> -		  nil)))
> +	      (coding-system-for-read 'binary)
> +	      (coding-system-for-write 'binary))
>  	  (unwind-protect
>  	      (with-temp-buffer
>  		(insert "begin 600 " (file-name-nondirectory tempfile) "\n")

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/