Re: Larger smilies

[Reiner Steib <reinersteib+gmane@imap.cc>]

[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]

On Wed, Mar 08 2006, Adam Sjøgren wrote:

> I have now updated my set of garish AOL-smilies so they match the full
> set found in etc/images/smilies/ in Gnus CVS.
>
> I have also created a set of dull smilies that are grey and without
> borders. They can do with a lot of improvement though.
>
>  <http://www.koldfront.dk/text/larger-smilies.html>

Apply the attached patch, put Adam's smilies into a /medium and
/grayscale ("dull-*.tar.gz") subdirectory of etc/images/smilies, do
`M-: (push "/path/to/No_Gnus/lisp/" load-path) RET', and customize
`smiley-style'.  WDYT?

For my font size (14) your 16 pixel smilies are too large (causing
increased "linespread").  Maybe you could remove the empty lines from
your "dull" variants?

Bye, Reiner.

Test text with all kinds of smilies follows:

  Lorem ipsum dolor ^:-) sit amet, consectetuer ^:) adipiscing
  elit. Aenean ;-) tincidunt ultrices ;) nisl. Nullam fermentum turpis
  eu ante. Nunc magna :-] augue, rutrum ut, suscipit non, mollis
  vitae, erat. Vivamus ullamcorper ligula 8-) ut nisi. Donec ultrices
  massa sed metus semper :-| congue. Vivamus dignissim, neque non
  placerat :-/ pharetra, mauris sapien mattis justo, a nonummy :-\ dui
  nulla ac dolor. Suspendisse purus eros, :-( sagittis vel, mollis
  non, adipiscing a, justo. Vivamus ultricies, >:-) ipsum quis
  placerat consectetuer, leo lorem eleifend odio, id tincidunt neque
  mi ac mauris. X-) Pellentesque vehicula orci ut nisl. Suspendisse
  potenti. Phasellus ornare, elit a hendrerit :-D vulputate, ipsum
  libero viverra dui, ac imperdiet lectus mi eget metus.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rs-smiley-larger.patch --]
[-- Type: text/x-patch, Size: 4287 bytes --]

--- smiley.el	08 Feb 2006 13:32:51 +0100	7.8
+++ smiley.el	09 Mar 2006 20:16:36 +0100	
@@ -31,8 +31,21 @@
 ;; I'm not sure we need that degree of rococoness and defaults like a
 ;; yellow background.  Also, using PBM means we can display the images
 ;; more generally.  -- fx
+;; `smiley.el' was replaced by `smiley-ems.el' on 2002-01-26 (after fx'
+;; comment).
 
-;;; Test smileys:  :-) :-\ :-( :-/
+;; Test smileys:
+;; smile             ^:-) ^:)
+;; blink             ;-)  ;)
+;; forced            :-]
+;; braindamaged      8-)
+;; indifferent       :-|
+;; wry               :-/  :-\
+;; sad               :-(
+;; evil              >:-)
+;; cry               ;-(
+;; dead              X-)
+;; grin              :-D
 
 ;;; Code:
 
@@ -45,25 +58,59 @@
   :group 'gnus-visual)
 
 ;; Maybe this should go.
-(defcustom smiley-data-directory (nnheader-find-etc-directory "images/smilies")
+(defcustom smiley-style 'low-color
+  "Smiley style."
+  :type '(choice (const :tag "small, 3 colors" low-color)
+		 (const :tag "medium, ~10 colors" medium)
+		 (const :tag "dull, grayscale" grayscale))
+  :set (lambda (symbol value)
+	 (set-default symbol value)
+	 (setq smiley-data-directory (smiley-directory))
+	 (smiley-update-cache))
+  :initialize 'custom-initialize-default
+  :group 'smiley)
+
+;; For compatibility, honor the variable `smiley-data-directory' if the user
+;; has set it.
+
+(defun smiley-directory (&optional style)
+  "Return a the location of the smiley faces files.
+STYLE specifies which style to use, see `smiley-style'.  If STYLE
+is nil, use `smiley-style'."
+  (unless style (setq style smiley-style))
+  (nnheader-find-etc-directory
+   (concat "images/smilies"
+	   (cond ((eq smiley-style 'low-color) "")
+		 ((eq smiley-style 'medium) "/medium")
+		 ((eq smiley-style 'grayscale) "/grayscale")))))
+
+(defcustom smiley-data-directory (smiley-directory)
   "*Location of the smiley faces files."
+  :set (lambda (symbol value)
+	 (set-default symbol value)
+	 (smiley-update-cache))
+  :initialize 'custom-initialize-default
   :type 'directory
   :group 'smiley)
 
 ;; The XEmacs version has a baroque, if not rococo, set of these.
 (defcustom smiley-regexp-alist
-  '(("\\(:-?)\\)\\W" 1 "smile")
+  '(("\\(\\^:-?)\\)\\W" 1 "smile")
     ("\\(;-?)\\)\\W" 1 "blink")
     ("\\(:-]\\)\\W" 1 "forced")
     ("\\(8-)\\)\\W" 1 "braindamaged")
     ("\\(:-|\\)\\W" 1 "indifferent")
     ("\\(:-[/\\]\\)\\W" 1 "wry")
     ("\\(:-(\\)\\W" 1 "sad")
-    ("\\(:-{\\)\\W" 1 "frown"))
+    ("\\(:-{\\)\\W" 1 "frown")
+    ("\\(>:-)\\)\\W" 1 "evil")
+    ("\\(;-(\\)\\W" 1 "cry")
+    ("\\(X-)\\)\\W" 1 "dead")
+    ("\\(:-D\\)\\W" 1 "grin"))
   "*A list of regexps to map smilies to images.
-The elements are (REGEXP MATCH FILE), where MATCH is the submatch in
-regexp to replace with IMAGE.  IMAGE is the name of a PBM file in
-`smiley-data-directory'."
+The elements are (REGEXP MATCH IMAGE), where MATCH is the submatch
+in regexp to replace with IMAGE.  IMAGE is the name of an image
+file in `smiley-data-directory'."
   :type '(repeat (list regexp
 		       (integer :tag "Regexp match number")
 		       (string :tag "Image name")))
@@ -78,7 +125,7 @@
     (when (gnus-image-type-available-p 'xpm)
       (push "xpm" types))
     types)
-  "*List of suffixes on picon file names to try."
+  "*List of suffixes on smiley file names to try."
   :version "22.1"
   :type '(repeat string)
   :group 'smiley)
@@ -86,6 +133,7 @@
 (defvar smiley-cached-regexp-alist nil)
 
 (defun smiley-update-cache ()
+  (setq smiley-cached-regexp-alist nil)
   (dolist (elt (if (symbolp smiley-regexp-alist)
 		   (symbol-value smiley-regexp-alist)
 		 smiley-regexp-alist))
@@ -104,12 +152,13 @@
 	    (push (list (car elt) (cadr elt) image)
 		  smiley-cached-regexp-alist)))))))
 
-(defvar smiley-mouse-map
-  (let ((map (make-sparse-keymap)))
-    (define-key map [down-mouse-2] 'ignore) ; override widget
-    (define-key map [mouse-2]
-      'smiley-mouse-toggle-buffer)
-    map))
+;; Not implemented:
+;; (defvar smiley-mouse-map
+;;   (let ((map (make-sparse-keymap)))
+;;     (define-key map [down-mouse-2] 'ignore) ; override widget
+;;     (define-key map [mouse-2]
+;;       'smiley-mouse-toggle-buffer)
+;;     map))
 
 ;;;###autoload
 (defun smiley-region (start end)