From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/59840
Path: main.gmane.org!not-for-mail
From: Reiner Steib <reinersteib+gmane@imap.cc>
Newsgroups: gmane.emacs.gnus.general
Subject: gnus-parse-news-url fails if port number is given
Date: Fri, 18 Feb 2005 15:14:42 +0100
Organization: Dept. of Theoretical Physics, University of Ulm
Message-ID: <v9r7je7y5p.fsf@marauder.physik.uni-ulm.de>
Reply-To: Reiner Steib <Reiner.Steib@gmx.de>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Trace: sea.gmane.org 1108737562 28212 80.91.229.2 (18 Feb 2005 14:39:22 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Fri, 18 Feb 2005 14:39:22 +0000 (UTC)
Original-X-From: ding-owner+M8380@lists.math.uh.edu Fri Feb 18 15:39:22 2005
Original-Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail)
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1D29FS-0006m1-Bp
	for ding-account@gmane.org; Fri, 18 Feb 2005 15:37:13 +0100
Original-Received: from localhost
	([127.0.0.1] helo=lists.math.uh.edu ident=lists)
	by malifon.math.uh.edu with smtp (Exim 3.20 #1)
	id 1D29HF-0005nm-00; Fri, 18 Feb 2005 08:38:41 -0600
Original-Received: from util2.math.uh.edu ([129.7.128.23])
	by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
	id 1D28xH-0005me-00
	for ding@lists.math.uh.edu; Fri, 18 Feb 2005 08:18:03 -0600
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by util2.math.uh.edu with esmtp (Exim 4.30)
	id 1D28xE-0006xn-BW
	for ding@lists.math.uh.edu; Fri, 18 Feb 2005 08:18:00 -0600
Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org)
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1D28xD-0004bT-00
	for <ding@gnus.org>; Fri, 18 Feb 2005 15:17:59 +0100
Original-Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1D28uG-0002na-Nq
	for ding@gnus.org; Fri, 18 Feb 2005 15:14:56 +0100
Original-Received: from bridgekeeper.physik.uni-ulm.de ([134.60.10.123])
        by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <ding@gnus.org>; Fri, 18 Feb 2005 15:14:56 +0100
Original-Received: from Reiner.Steib by bridgekeeper.physik.uni-ulm.de with local (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <ding@gnus.org>; Fri, 18 Feb 2005 15:14:56 +0100
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: ding@gnus.org
Original-To: ding@gnus.org
Original-Lines: 78
Original-X-Complaints-To: usenet@sea.gmane.org
X-Gmane-NNTP-Posting-Host: bridgekeeper.physik.uni-ulm.de
X-Face: P05mdcZT&lL[-s2=mw~RsllZ0zZAb?vdE}.s<l:C!'y=7MhVA[J6}92Ma:vvdy](YbA+AS!
 n"JLX4vFh8fL,.+XSC(B%i/V9e]L$EiVH,QI;j+ffz9#AW~w)n
Mail-Copies-To: nobody
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
Cancel-Lock: sha1:xcQ7BfiFZQ+JzCEHThPipK/W6p8=
X-Spam-Score: -4.9 (----)
Precedence: bulk
Original-Sender: ding-owner@lists.math.uh.edu
X-MailScanner-From: ding-owner+m8380@lists.math.uh.edu
X-MailScanner-To: ding-account@gmane.org
Xref: main.gmane.org gmane.emacs.gnus.general:59840
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:59840

--=-=-=

Hi,

Gnus doesn't parse news URLs correctly if a port number is specified:

news://newsarchiv.arcor.de:119/4213714c$0$24925$9b4e6d93@newsread2.arcor-online.net

Without the port number, it works:

news://newsarchiv.arcor.de/4213714c$0$24925$9b4e6d93@newsread2.arcor-online.net

Is the following patch the right way to fix this?  Especially, I'm
unsure if the let binding of `nntp-port-number' is the right way.
Other suggestions?


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline; filename=rs-news-url-port.patch

--- gnus-art.el	14 Feb 2005 16:56:04 +0100	6.381.2.22
+++ gnus-art.el	18 Feb 2005 14:41:43 +0100	
@@ -6648,15 +6648,18 @@
 		      (cons fun args)))))))
 
 (defun gnus-parse-news-url (url)
-  (let (scheme server group message-id articles)
+  (let (scheme server port group message-id articles)
     (with-temp-buffer
       (insert url)
       (goto-char (point-min))
       (when (looking-at "\\([A-Za-z]+\\):")
 	(setq scheme (match-string 1))
 	(goto-char (match-end 0)))
-      (when (looking-at "//\\([^/]+\\)/")
+      (when (looking-at "//\\([^:/]+\\)\\(:?\\)\\([0-9]+\\)?/")
 	(setq server (match-string 1))
+	(setq port (if (stringp (match-string 3))
+		       (string-to-number (match-string 3))
+		     (match-string 3)))
 	(goto-char (match-end 0)))
 
       (cond
@@ -6669,18 +6672,19 @@
 	(setq group (match-string 1)))
        (t
 	(error "Unknown news URL syntax"))))
-    (list scheme server group message-id articles)))
+    (list scheme server port group message-id articles)))
 
 (defun gnus-button-handle-news (url)
   "Fetch a news URL."
-  (destructuring-bind (scheme server group message-id articles)
+  (destructuring-bind (scheme server port group message-id articles)
       (gnus-parse-news-url url)
     (cond
      (message-id
       (save-excursion
 	(set-buffer gnus-summary-buffer)
 	(if server
-	    (let ((gnus-refer-article-method (list (list 'nntp server))))
+	    (let ((gnus-refer-article-method (list (list 'nntp server)))
+		  (nntp-port-number (or port "nntp")))
 	      (gnus-summary-refer-article message-id))
 	  (gnus-summary-refer-article message-id))))
      (group

--=-=-=


Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

--=-=-=--