From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/50174 Path: main.gmane.org!not-for-mail From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de> Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Better handling for Microsoft citations (resend) Date: Wed, 19 Feb 2003 19:00:07 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: References: <87el6d74x6.fsf@mulligatwani.msrl.com> <84adh0zabw.fsf@lucy.is.informatik.uni-duisburg.de> Reply-To: reiner.steib@gmx.de NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: main.gmane.org 1045677818 31818 80.91.224.249 (19 Feb 2003 18:03:38 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 19 Feb 2003 18:03:38 +0000 (UTC) Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18lYZC-0008Gl-00 for ; Wed, 19 Feb 2003 19:03:34 +0100 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 18lYWE-0002I4-00; Wed, 19 Feb 2003 12:00:30 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 19 Feb 2003 12:01:28 -0600 (CST) Original-Received: from sclp3.sclp.com (sclp3.sclp.com [66.230.238.2]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id MAA20668 for ; Wed, 19 Feb 2003 12:01:14 -0600 (CST) Original-Received: (qmail 55136 invoked by alias); 19 Feb 2003 18:00:10 -0000 Original-Received: (qmail 55130 invoked from network); 19 Feb 2003 18:00:10 -0000 Original-Received: from theotp5.physik.uni-ulm.de (134.60.10.145) by 66.230.238.6 with SMTP; 19 Feb 2003 18:00:10 -0000 Original-Received: (from ste@localhost) by theotp5.physik.uni-ulm.de (8.11.2/8.11.2) id h1JI07s18622; Wed, 19 Feb 2003 19:00:07 +0100 X-Authentication-Warning: theotp5.physik.uni-ulm.de: ste set sender to 4.uce.03.r.s@nurfuerspam.de using -f Original-To: ding@gnus.org X-Face: 3Phac&+dw=IZHjhua]bp}LH<*p{qzj8u+ Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes: > >> On Wed, Feb 12 2003, Michael Shields wrote: >> >>> +(defcustom gnus-unsightly-citation-regexp >>> + "^-----Original Message-----\nFrom: \\(.+\n\\)+\n" >>> + "Regexp matching Microsoft-type rest-of-message citations." [...] >> Wouldn't it be better to use a name starting with `gnus-cite-' for >> consistency? > > I agree. Michael, what do you think? No response or objection from Michael? I propose to rename it and apply the attached patch (patch to ChangeLog files is also included): --8<---------------cut here---------------start------------->8--- 2003-02-19 Reiner Steib * GNUS-NEWS: Renamed `gnus-unsightly-citation-regexp' to `gnus-cite-unsightly-citation-regexp'. 2003-02-19 Reiner Steib * gnus-cite.el (gnus-cite-unsightly-citation-regexp) (gnus-cite-parse): Renamed `gnus-unsightly-citation-regexp' to `gnus-cite-unsightly-citation-regexp'. --8<---------------cut here---------------end--------------->8--- --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=gnus-cite.unsightly.patch Content-Description: gnus-cite.unsightly.patch Index: GNUS-NEWS =================================================================== RCS file: /usr/local/cvsroot/gnus/GNUS-NEWS,v retrieving revision 6.43 diff -u -r6.43 GNUS-NEWS --- GNUS-NEWS 18 Feb 2003 20:42:51 -0000 6.43 +++ GNUS-NEWS 19 Feb 2003 18:06:58 -0000 @@ -10,10 +10,11 @@ ** Better handling of Microsoft citation styles -Gnus now tries to recognize the mangled header block that some -Microsoft mailers use to indicate that the rest of the message is a -citation, even though it is not quoted in any way. The variable -`gnus-unsightly-citation-regexp' matches the start of these citations. +Gnus now tries to recognize the mangled header block that some Microsoft +mailers use to indicate that the rest of the message is a citation, even +though it is not quoted in any way. The variable +`gnus-cite-unsightly-citation-regexp' matches the start of these +citations. ** gnus-article-skip-boring Index: ChangeLog =================================================================== RCS file: /usr/local/cvsroot/gnus/ChangeLog,v retrieving revision 6.44 diff -u -r6.44 ChangeLog --- ChangeLog 18 Feb 2003 20:43:17 -0000 6.44 +++ ChangeLog 19 Feb 2003 18:06:58 -0000 @@ -1,3 +1,8 @@ +2003-02-19 Reiner Steib + + * GNUS-NEWS: Renamed `gnus-unsightly-citation-regexp' to + `gnus-cite-unsightly-citation-regexp'. + 2003-02-18 Simon Josefsson * GNUS-NEWS: Talk about canlock more. Index: lisp/gnus-cite.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-cite.el,v retrieving revision 6.22 diff -u -r6.22 gnus-cite.el --- lisp/gnus-cite.el 12 Feb 2003 20:36:45 -0000 6.22 +++ lisp/gnus-cite.el 19 Feb 2003 18:06:58 -0000 @@ -120,7 +120,7 @@ :group 'gnus-cite :type 'regexp) -(defcustom gnus-unsightly-citation-regexp +(defcustom gnus-cite-unsightly-citation-regexp "^-----Original Message-----\nFrom: \\(.+\n\\)+\n" "Regexp matching Microsoft-type rest-of-message citations." :group 'gnus-cite @@ -749,7 +749,7 @@ (setq line (1+ line))) ;; Horrible special case for some Microsoft mailers. (goto-char (point-min)) - (when (re-search-forward gnus-unsightly-citation-regexp max t) + (when (re-search-forward gnus-cite-unsightly-citation-regexp max t) (setq begin (count-lines (point-min) (point))) (setq end (count-lines (point-min) max)) (setq entry nil) Index: lisp/ChangeLog =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v retrieving revision 6.2014 diff -u -r6.2014 ChangeLog --- lisp/ChangeLog 19 Feb 2003 06:55:27 -0000 6.2014 +++ lisp/ChangeLog 19 Feb 2003 18:06:59 -0000 @@ -1,3 +1,9 @@ +2003-02-19 Reiner Steib + + * gnus-cite.el (gnus-cite-unsightly-citation-regexp) + (gnus-cite-parse): Renamed `gnus-unsightly-citation-regexp' to + `gnus-cite-unsightly-citation-regexp'. + 2003-02-19 Katsumi Yamaoka * gnus-msg.el (gnus-copy-article-buffer): Copy an article header --=-=-= Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- PGP key available via WWW http://rsteib.home.pages.de/ --=-=-=--