From: Reiner Steib <reinersteib+gmane@imap.cc>
To: ding@gnus.org
Subject: Re: The type of gnus-ignored-from-addresses
Date: Thu, 26 Apr 2007 22:39:25 +0200 [thread overview]
Message-ID: <v9slamzx8i.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <muxy7kg2a33.fsf@uzeb.lrde.epita.fr>
On Wed, Apr 25 2007, Didier Verna wrote:
> Sorry, I don't understand this paragraph. Are you suggesting
> that I put an autoload cookie on gnus-orify-regexp instead of requiring
> gnus-util ? That would only merely delay the time of loading gnus-util.
Many of the autoloaded gnus-* functions in `message.el' are only
called when the user actually uses Gnus, not otherwise.
> Point is, I don't want to introduce redundancy for something needed both
> in Gnus and in Message.
Please put it in `gmm-utils.el' with a `gmm-' prefix.
Some remarks...
I had to read the source to figure out what "orify" could mean. Maybe
we could find a more clear name.
The defsubst `gnus-ignored-from-addresses' should have a doc string.
I don't want to start another discussion about conventions, but...
,----
| 2007-04-24 Didier Verna <didier@xemacs.org>
|
| * gnus-util.el (gnus-orify-regexp): New function.
|
| * message.el (gnus-util): Require it.
| (message-dont-reply-to-names): Use gnus-orify-regexp.
|
| * gnus-sum.el (gnus-ignored-from-addresses): Allow a list of regexps.
| (gnus-ignored-from-addresses): New function.
|
| * gnus-sum.el (gnus-summary-from-or-to-or-newsgroups): Use it.
|
| * gnus-sum.el, gnus-utils.el: Fix some trailing whitespaces.
`----
... is preferable to...
,----
| 2007-04-24 Didier Verna <didier@xemacs.org>
|
| Improve the type of gnus-ignored-from-addresses.
| * gnus-util.el (gnus-orify-regexp): New function.
| * message.el (gnus-util): Require it.
| * message.el (message-dont-reply-to-names): Use gnus-orify-regexp.
| * gnus-sum.el (gnus-ignored-from-addresses): New function.
| * gnus-sum.el (gnus-summary-from-or-to-or-newsgroups): Use it.
|
| 2007-04-24 Didier Verna <didier@xemacs.org>
|
| * gnus-sum.el:
| * gnus-utils.el: Fix some trailing whitespaces.
`----
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next prev parent reply other threads:[~2007-04-26 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 13:50 Didier Verna
2007-04-24 23:49 ` Katsumi Yamaoka
2007-04-25 7:21 ` Didier Verna
2007-04-25 8:03 ` Katsumi Yamaoka
2007-04-25 10:04 ` Didier Verna
2007-04-25 11:10 ` Katsumi Yamaoka
2007-04-26 20:39 ` Reiner Steib [this message]
2007-04-27 4:00 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9slamzx8i.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).