From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64493 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Top posting related changes in the cvs Date: Wed, 04 Apr 2007 00:05:29 +0200 Message-ID: References: <873b3hm942.fsf@ambire.localdomain> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1175638315 23114 80.91.229.12 (3 Apr 2007 22:11:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 3 Apr 2007 22:11:55 +0000 (UTC) Cc: "Gabor Z. Papp" , ding@gnus.org, emacs-devel@gnu.org To: Thien-Thi Nguyen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 04 00:11:52 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HYrEC-0000Ba-LD for ged-emacs-devel@m.gmane.org; Wed, 04 Apr 2007 00:11:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HYrHO-0008C3-0B for ged-emacs-devel@m.gmane.org; Tue, 03 Apr 2007 18:15:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HYrHK-00089R-Nm for emacs-devel@gnu.org; Tue, 03 Apr 2007 18:15:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HYrHJ-00087C-Cm for emacs-devel@gnu.org; Tue, 03 Apr 2007 18:15:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HYrHJ-000879-5F for emacs-devel@gnu.org; Tue, 03 Apr 2007 18:15:01 -0400 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HYrE6-0006Sy-LZ for emacs-devel@gnu.org; Tue, 03 Apr 2007 18:11:43 -0400 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.8/8.13.8) with ESMTP id l33MBdFw014697; Wed, 4 Apr 2007 00:11:39 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 15FE01236D; Wed, 4 Apr 2007 00:11:39 +0200 (CEST) X-Face: 3Phac&+dw=IZHjhua]bp}LH<*p{qzj8u+, ding@gnus.org, emacs-devel@gnu.org In-Reply-To: <873b3hm942.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Tue\, 03 Apr 2007 23\:38\:37 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.96 (gnu/linux) X-DCC-INFN-TO-Metrics: arktur 1233; Body=4 Fuz1=4 Fuz2=4 X-detected-kernel: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69027 gmane.emacs.gnus.general:64493 Archived-At: On Tue, Apr 03 2007, Thien-Thi Nguyen wrote: > before the fix, yanking would leave the cursor after the yanked > messages, contrary to the docstring. the fix, to regain concordance w/ > the docstring, involves conditionalizing a previously unconditional call > to exchange-point-and-mark. i believe the original unconditional call > was correct (necessary) prior to another change: > > 2005-08-01 Katsumi Yamaoka > > * gnus-uu.el (gnus-uu-save-article): Use insert-buffer-substring > instead of insert-buffer. > > * message.el (message-yank-original): Ditto; set the mark at the > end of the yanked message. > > insert-buffer-substring inserts before point, while insert-buffer > inserts after point. my analysis is that the exchange-point-and-mark > relied on insert-buffer's behavior, and thus became incorrect after the > 2005-08-01 change, since point and mark were already in the correct > order. > > my fix (to conditionalize the call) removes the direct dependency so > that the desired ending position of point will be as documented for > whatever function is used (now or in the future) to do the insert, as > long as the inserted text is bracketed by point and mark. > > an alternative fix that is less robust against future changes is to rely > on the behavior of insert-buffer-substring and simply remove the call to > exchange-point-and-mark. then we can chase this bug again later for > hours of fun... [...] > i think the behavior, leaving point between the citation and the yanked > text, is nice. i was happy to read about it in the docstring. it seems > whoever wrote the original (concording) code+docstring was thoughtful. I gather that you refer to an interactive call of `message-yank-original' (C-c C-y) after doing a reply/followup without citing the original (using `r'/`f'). However, when using `R'/`F', I don't get this behavior anymore: Point is _below_ the quote, which is wrong. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/