Re: Attachments in forwarded messages garbled

Re: Attachments in forwarded messages garbled

[Reiner Steib]

[ Redirecting this bug report to ding.
  See http://thread.gmane.org/87psbyed2i.fsf%40pereiro.luannocracy.com
  or http://thread.gmane.org/gmane.emacs.gnus.user/8168/focus=8176
  for the complete thread. ]

On Fri, Nov 10 2006, David Abrahams wrote in gnu.emacs.gnus:

> David Abrahams <dave@boost-consulting.com> writes:
>> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>>> On Wed, Nov 08 2006, David Abrahams wrote:
>>>> Ever since I made the switch to Linux for my main machine, I've been
>>>> having the problem that when I forward (gnus-summary-mail-forward) a
>>>> message that contains an attachment, the recipent gets a garbled
>>>> version of the original attachment.
>>>
>>> Without *any* kind of information what is kind of problem the
>>> "garbled" message/attachment has, it's next to impossible to help you.
>>> You might send such a message to gmane.test or send us a gzipped mbox
>>> of the received message.  Be sure not to include private stuff.
>>
>> I will arrange such a test in a follow-up message.
>
> Was there insufficient information?  Is there anything else I
> should do?

Thanks, the information should be sufficient now.  I can confirm that
the two base64 encoded parts...

$ ll boost?.base64
[...] 8523 [...] boost1.base64
[...] 8515 [...] boost2.base64

... and the resulting images differ:

$ ll boost?.png
[...] 6308 [...] boost1.png
[...] 6302 [...] boost2.png

Saving in Thunderbird gives the same PNG files (also checked with
cmp):

$ ll boost?.TB.png
[...] 6308 [...] boost1.TB.png
[...] 6302 [...] boost2.TB.png

Could someone look into this problem, please?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Attachments in forwarded messages garbled

[Katsumi Yamaoka]

>>>>> In <v98xijod6d.fsf@marauder.physik.uni-ulm.de>
>>>>>	Reiner Steib wrote:

> [ Redirecting this bug report to ding.
>   See http://thread.gmane.org/87psbyed2i.fsf%40pereiro.luannocracy.com
>   or http://thread.gmane.org/gmane.emacs.gnus.user/8168/focus=8176
>   for the complete thread. ]

[...]

> Could someone look into this problem, please?

The problem occurs with only Emacs 23, in which `string-as-multibyte'
and `mm-with-unibyte-current-buffer' destroy binary data.  I've fixed
them in the Gnus trunk and the v5-10 branch.  There will still be
similar things and we will have to fix them one by one.  Here's a diff:

--8<---------------cut here---------------start------------->8---
--- mm-decode.el~	2006-05-11 09:02:07 +0000
+++ mm-decode.el	2006-11-14 11:07:55 +0000
@@ -1135,7 +1135,7 @@
 	    (with-current-buffer (mm-handle-buffer handle)
 	      (buffer-string)))
 	   ((mm-multibyte-p)
-	    (mm-string-as-multibyte (mm-get-part handle no-cache)))
+	    (mm-string-to-multibyte (mm-get-part handle no-cache)))
 	   (t
 	    (mm-get-part handle no-cache))))))
 
--- mml.el~	2006-04-26 16:07:37 +0000
+++ mml.el	2006-11-14 11:34:45 +0000
@@ -501,9 +501,9 @@
 	    (mm-with-unibyte-buffer
 	      (cond
 	       ((cdr (assq 'buffer cont))
-		(insert (with-current-buffer (cdr (assq 'buffer cont))
-			  (mm-with-unibyte-current-buffer
-			    (buffer-string)))))
+		(insert (mm-string-as-unibyte
+			 (with-current-buffer (cdr (assq 'buffer cont))
+			   (buffer-string)))))
 	       ((and filename
 		     (not (equal (cdr (assq 'nofile cont)) "yes")))
 		(let ((coding-system-for-read mm-binary-coding-system))
--8<---------------cut here---------------end--------------->8---

Re: Attachments in forwarded messages garbled

[Reiner Steib]

On Tue, Nov 14 2006, Katsumi Yamaoka wrote:

> The problem occurs with only Emacs 23,

FWIW, David Abrahams wrote that the problem also exists in Emacs 22:

,----[ http://thread.gmane.org/gmane.emacs.gnus.user/8168/focus=8175 ]
| > In this article, you used Emacs 23 (CVS unicode branch; experimental).
| > Please try to reproduce the problem with Emacs 22 (CVS trunk or
| > pretest tarball).
| 
| I did it already with the HEAD of the CVS trunk and the result is the
| same.
`----

> in which `string-as-multibyte' and `mm-with-unibyte-current-buffer'
> destroy binary data.  I've fixed them in the Gnus trunk and the
> v5-10 branch.  

Thanks.

> There will still be similar things and we will have to fix them one
> by one.

ACK.  Once emacs-unicode is merge into the trunk (after the release of
Emacs 22) we will get more testing and more bug reports.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/