Re: ietf-drums-parse-address, gnus-extract-address-components, mail-extract-address-components

[Reiner Steib <reinersteib+gmane@imap.cc>]

[ Resent.  The first try
  (<news:v9ejsq16u9.fsf@marauder.physik.uni-ulm.de> posted via Gmane)
  didn't appear on gnus.org nor gmane.org yet. ]

On Mon, Oct 30 2006, Katsumi Yamaoka wrote:

>>>>>> In <v93b98oi3m.fsf@marauder.physik.uni-ulm.de>
>
>> Here's a suggestion for such a fix.  Does anyone see a problem with
>> it?
>
> It doesn't strip brackets and whitespace:
>
> (gnus-extract-address-components "\"foo@bar\" <bar@baz>")
>  => (nil " <bar@baz>")

Oops.  Thanks for checking.

> In addition, "foo@bar" might be a valid (nick)name of the sender.
> How about the following?

Beside the comment (see [1]), it looks fine.  I'd suggest to install it in
trunk and v5-10 if nobody finds a problem with it.

With this change to `gnus-extract-address-components', can we revert spam.el
to revision 7.82 or do we need to include parts of the changes from revision
7.82 to 7.85?  If so, we probably also need to backport these to v5-10.

Bye, Reiner.

[1] This comment...

> +    (cond (;; Special case: "foo@bar" <foo@bar>, i.e. one @ in the comment
> +	   ;; and one in the address.

... doesn't match the code:

> +	   (string-match "<\\([^@ \t<>]+[!@][^@ \t<>]+\\)>" from)
> +	   (setq address (substring from (match-beginning 1) (match-end 1))))
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/