Improved gnus-mime-save-part-and-strip to v5-10

Improved gnus-mime-save-part-and-strip to v5-10

[Reiner Steib]

Hi,

I found that the version of `gnus-mime-save-part-and-strip' (`C-o') in
the trunk works much better that the one in the v5-10 branch.

Even for a simple MIME structure like...

,----[ C-d ]
| <* mixed> ...
| <1 text>
| <2 pjpeg> "100_0385.JPG"
| <3 pjpeg> "100_0386.JPG"
| [...]
`----

... I got:

,----
| Debugger entered--Lisp error: (invalid-function (macro . #[(&rest
|   forms) "[...]" [forms let ((default-enable-multibyte-characters t))]
|   3
|   ("/import/xtra/emacs/HEAD/share/emacs/21.3.50/lisp/gnus/mm-util.elc"
|   . 17775)])) 
|   mm-with-multibyte("~/some/directory/")
|   mm-save-part((#<buffer  *mm*<3>> ("image/pjpeg" (name .
|   "100_0385.JPG")) base64 nil ("attachment" (filename .
|   "100_0385.JPG")) nil nil nil))
|   gnus-mime-save-part-and-strip()
|   call-interactively(gnus-mime-save-part-and-strip)
`----

The I tried the trunk and it worked.  Is it save to install the
relevant changes in v5-10?  

Are these the only relevant changes?

--8<---------------cut here---------------start------------->8---
2004-03-09  Katsumi Yamaoka  <yamaoka@jpl.org>

	* gnus-art.el (gnus-article-edit-part): New function.
	(gnus-mime-save-part-and-strip): Use it; do query instead of
	signaling an error; don't use mm-multiple-handles.
	(gnus-mime-delete-part): Ditto.

[...]

2004-03-10  Katsumi Yamaoka  <yamaoka@jpl.org>

	* mm-decode.el (mm-complicated-handles): New function reviving
	former definition of mm-multiple-handles.

	* gnus-art.el (gnus-mime-save-part-and-strip): Use it.
	(gnus-mime-delete-part): Use it.
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Improved gnus-mime-save-part-and-strip to v5-10

[Katsumi Yamaoka]

>>>>> In <v93c0mpjru.fsf@marauder.physik.uni-ulm.de> 
>>>>>	Reiner Steib <reinersteib+gmane@imap.cc> wrote:

> | Debugger entered--Lisp error: (invalid-function (macro . #[(&rest
> |   forms) "[...]" [forms let ((default-enable-multibyte-characters t))]
> |   3
> |   ("/import/xtra/emacs/HEAD/share/emacs/21.3.50/lisp/gnus/mm-util.elc"
> |   . 17775)])) 
> |   mm-with-multibyte("~/some/directory/")
> |   mm-save-part((#<buffer  *mm*<3>> ("image/pjpeg" (name .
> |   "100_0385.JPG")) base64 nil ("attachment" (filename .
> |   "100_0385.JPG")) nil nil nil))
> |   gnus-mime-save-part-and-strip()
> |   call-interactively(gnus-mime-save-part-and-strip)

Hm, you encountered another error, didn't you?  It seems to be
the case where mm-decode.elc has been compiled without loading
mm-util.elc.

Re: Improved gnus-mime-save-part-and-strip to v5-10

[Reiner Steib]

On Mon, Oct 11 2004, Katsumi Yamaoka wrote:

>>>>>>	Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>
>> | Debugger entered--Lisp error: (invalid-function (macro . #[(&rest
>> |   forms) "[...]" [forms let ((default-enable-multibyte-characters t))]
>> |   3
>> |   ("/import/xtra/emacs/HEAD/share/emacs/21.3.50/lisp/gnus/mm-util.elc"
>> |   . 17775)])) 
>> |   mm-with-multibyte("~/some/directory/")
>> |   mm-save-part((#<buffer  *mm*<3>> ("image/pjpeg" (name .
>> |   "100_0385.JPG")) base64 nil ("attachment" (filename .
>> |   "100_0385.JPG")) nil nil nil))
>> |   gnus-mime-save-part-and-strip()
>> |   call-interactively(gnus-mime-save-part-and-strip)
>
> Hm, you encountered another error, didn't you?

Maybe.  I simply started No Gnus and it worked fine.  

> It seems to be the case where mm-decode.elc has been compiled
> without loading mm-util.elc.

But adding (require 'mm-util) to `mm-decode.el' (and recompiling) in
v5-10 [1] doesn't fix the problem:

,----
| ELISP> (featurep 'mm-decode)
| t
| ELISP> (featurep 'mm-util)
| t
| ELISP> (fboundp 'mm-with-multibyte)
| t
`----

I still get a (the same?) backtrace:

,----
| Debugger entered--Lisp error: (invalid-function (macro . #[(&rest
|   forms) "[BYTE CODE]" [forms let ((default-enable-multibyte-characters t))] 3
|   ("/import/xtra/emacs/HEAD/share/emacs/21.3.50/lisp/gnus/mm-util.elc"
|   . 17775)]))
|   mm-with-multibyte("/tmp/ste/100_0385.JPG")
|   mm-save-part((#<buffer  *mm*<3>> ("image/pjpeg" (name .
|   "100_0385.JPG")) base64 nil ("attachment" (filename .
|   "100_0385.JPG")) nil nil nil))
|   gnus-mime-save-part-and-strip()
|   call-interactively(gnus-mime-save-part-and-strip)
`----

After loading the *.el (not *.elc) files (mm-decode.el, mm-util.el) it
worked.  (I had to hit `C-c C-c' to finish editing, which is no longer
needed in the trunk.)

Bye, Reiner.

[1] Well, it was not in v5-10 but in the Emacs files, but this
    shouldn't matter as there are no changes pending in this area.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Improved gnus-mime-save-part-and-strip to v5-10

[Reiner Steib]

On Mon, Oct 11 2004, Reiner Steib wrote:

> After loading the *.el (not *.elc) files (mm-decode.el, mm-util.el)
> it worked.

`gnus-mime-save-part' suffers from the same problem (in v5-10) when
`mm-decode.elc' (not `mm-decode.el') is loaded:

,----
| mm-save-part: Invalid function: (macro lambda (&rest forms) "Eval the
| FORMS with the default value of `enable-multibyte-characters' t." (\`
| (let ((default-enable-multibyte-characters t)) (\,@ forms))))
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Improved gnus-mime-save-part-and-strip to v5-10

[Katsumi Yamaoka]

>>>>> In <v9655hfm86.fsf@marauder.physik.uni-ulm.de> 
>>>>>	Reiner Steib <reinersteib+gmane@imap.cc> wrote:

>> After loading the *.el (not *.elc) files (mm-decode.el, mm-util.el)
>> it worked.

> `gnus-mime-save-part' suffers from the same problem (in v5-10) when
> `mm-decode.elc' (not `mm-decode.el') is loaded:

> ,----
> | mm-save-part: Invalid function: (macro lambda (&rest forms) "Eval the
> | FORMS with the default value of `enable-multibyte-characters' t." (\`
> | (let ((default-enable-multibyte-characters t)) (\,@ forms))))
> `----

I cannot guess the cause besides the case where mm-util.elc doesn't
provide the mm-with-multibyte macro when compiling mm-decode.elc.
Isn't there old mm-util.elc made before 2004-08-26, somewhere in
your system?  Otherwise, does using `make lick' (which deletes all
*.elc files in advance) help?

Re: Improved gnus-mime-save-part-and-strip to v5-10

[Reiner Steib]

On Mon, Oct 11 2004, Katsumi Yamaoka wrote:

>>>>>> In <v9655hfm86.fsf@marauder.physik.uni-ulm.de> 
>>>>>>	Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>
>>> After loading the *.el (not *.elc) files (mm-decode.el, mm-util.el)
>>> it worked.
>
>> `gnus-mime-save-part' suffers from the same problem (in v5-10) when
>> `mm-decode.elc' (not `mm-decode.el') is loaded:
>
>> ,----
>> | mm-save-part: Invalid function: (macro lambda (&rest forms) "Eval the
>> | FORMS with the default value of `enable-multibyte-characters' t." (\`
>> | (let ((default-enable-multibyte-characters t)) (\,@ forms))))
>> `----
>
> I cannot guess the cause besides the case where mm-util.elc doesn't
> provide the mm-with-multibyte macro when compiling mm-decode.elc.
> Isn't there old mm-util.elc made before 2004-08-26, somewhere in
> your system?

`M-x list-load-path-shadows RET' shows no match for mm- or other Gnus
related files.

> Otherwise, does using `make lick' (which deletes all *.elc files in
> advance) help?

I'm using the Emacs-bundled Gnus (CVS Emacs, Gnus 5.11).  I have
updated (and even bootstrapped) Emacs CVS today at 11:50 CEST.
mm-util.el* and mm-decode.el* files in the installation directory are
installed correctly.  After `M-: (load "mm-decode.el") RET' it works
correctly.

*time passes*... I added (require 'mm-util) in mm-decode.el.  After
"rm lisp/gnus/*.elc", "make recompile" and install, I cannot reproduce
the problem anymore.  (Though I'm quite sure that I did rm
mm-decode.elc, recompile, install, restart the last time.)

But I still think, that beside adding (require 'mm-util), we should
also install the improved gnus-mime-save-part-and-strip (and
gnus-mime-delete-part?) in v5-10.  WDYT?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Improved gnus-mime-save-part-and-strip to v5-10

[Katsumi Yamaoka]

>>>>> In <v9wtxxti7a.fsf@marauder.physik.uni-ulm.de> Reiner Steib wrote:

> But I still think, that beside adding (require 'mm-util), we should
> also install the improved gnus-mime-save-part-and-strip (and
> gnus-mime-delete-part?) in v5-10.  WDYT?

I agree with you and I'm not stingy with doing that.  Furthermore,
I want to merge other improvements in No Gnus to the Emacs trunk.
For instance, it is rfc2047.el.  However, doesn't it mean changing
Emacs' Gnus to No Gnus?