Re: [PATCH] Support opaque display-table objects on XEmacs (revised)

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Mon, Jun 09 2008, Aidan Kehoe wrote:

> This supersedes the patch in 18492.30425.377545.700503@parhasard.net, taking
> on board Reiner’s input. Tested with XEmacs 21.5; the other
> incompatibilities there are independent of this.

Which "other incompatibilities"?  Related to Gnus?

> 	* gnus-util.el (gnus-put-display-table): New.
> 	(gnus-get-display-table): New. 
> 	Macros that expand to an `aset' call under GNU, and to a runtime choice
> 	under XEmacs. 
> 	* gnus-sum.el (gnus-summary-set-display-table): 
> 	Use `gnus-put-display-table', `gnus-get-display-table', 
> 	`gnus-set-display-table' for the display table, instead of `aset';
> 	* gnus-xmas.el (gnus-xmas-summary-set-display-table): 
> 	Use `gnus-put-display-table', `gnus-get-display-table', 
> 	`gnus-set-display-table' for the display table.

Committed to the trunk, with a slightly modified ChangeLog entry and
the fix mentioned below (please confirm that is it correct).

I'll install it on v5-10 as well if nobody finds a problem within a
couple of days.

> +(defmacro gnus-get-display-table (character display-table)
> +  "Find value for CHARACTER in DISPLAY-TABLE.  "
> +  (if (featurep 'xemacs)
> +      `(if (fboundp 'get-display-table)
> +          (get-display-table ,character ,display-table)
> +          (if (sequencep ,display-table)
> +              (aref ,display-table ,character)
> +            (get-char-table ,character ,display-table)))
> +    `(aref ,display-table ,char-table)))

I suppose this should read...

       `(aref ,display-table ,character)))

,----
| In gnus-get-display-table:
| gnus-util.el:1823:28:Warning: reference to free variable `char-table'
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/