From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67056 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general,gmane.emacs.xemacs.patches Subject: Re: [PATCH] Support opaque display-table objects on XEmacs (revised) Date: Sat, 14 Jun 2008 17:48:45 +0200 Message-ID: References: <18484.43203.462970.885072@parhasard.net> <18492.30425.377545.700503@parhasard.net> <18509.35990.374622.216796@parhasard.net> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1213458681 4454 80.91.229.12 (14 Jun 2008 15:51:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Jun 2008 15:51:21 +0000 (UTC) Cc: ding@gnus.org, xemacs-patches@xemacs.org To: Aidan Kehoe Original-X-From: ding-owner+M15523@lists.math.uh.edu Sat Jun 14 17:52:05 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1K7Y2n-0008P4-LP for ding-account@gmane.org; Sat, 14 Jun 2008 17:51:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1K7Y1Q-0003FK-VY; Sat, 14 Jun 2008 10:50:33 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1K7Y1P-0003F0-Dg for ding@lists.math.uh.edu; Sat, 14 Jun 2008 10:50:31 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1K7Y1G-0000X2-Ul for ding@lists.math.uh.edu; Sat, 14 Jun 2008 10:50:31 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1K7Y1Y-00010i-00 for ; Sat, 14 Jun 2008 17:50:40 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m5EFoHxE006612; Sat, 14 Jun 2008 17:50:18 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id C629F1C711; Sat, 14 Jun 2008 17:50:17 +0200 (CEST) X-Face: :6KQZ[nyoS_edmB.%gw-=)BYth^|2+Y+^cu%I$FSx!&>-'om>3H7A|M&n(V7fIo3P.;yo.b yq4$p;ZaBtkv)\}biaiBQe"mD}iib1AA@99-fZ7i*bLhNRVC&0Wkxg9)SH?oWc@{ Mail-Followup-To: Aidan Kehoe , ding@gnus.org, xemacs-patches@xemacs.org In-Reply-To: <18509.35990.374622.216796@parhasard.net> (Aidan Kehoe's message of "Mon, 9 Jun 2008 22:03:34 +0200") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2.50 (gnu/linux) X-DCC-dcc.uncw.edu-Metrics: poseidon 1201; Body=3 Fuz1=3 Fuz2=3 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67056 gmane.emacs.xemacs.patches:9496 Archived-At: On Mon, Jun 09 2008, Aidan Kehoe wrote: > This supersedes the patch in 18492.30425.377545.700503@parhasard.net, tak= ing > on board Reiner=E2=80=99s input. Tested with XEmacs 21.5; the other > incompatibilities there are independent of this. Which "other incompatibilities"? Related to Gnus? > * gnus-util.el (gnus-put-display-table): New. > (gnus-get-display-table): New.=20 > Macros that expand to an `aset' call under GNU, and to a runtime choice > under XEmacs.=20 > * gnus-sum.el (gnus-summary-set-display-table):=20 > Use `gnus-put-display-table', `gnus-get-display-table',=20 > `gnus-set-display-table' for the display table, instead of `aset'; > * gnus-xmas.el (gnus-xmas-summary-set-display-table):=20 > Use `gnus-put-display-table', `gnus-get-display-table',=20 > `gnus-set-display-table' for the display table. Committed to the trunk, with a slightly modified ChangeLog entry and the fix mentioned below (please confirm that is it correct). I'll install it on v5-10 as well if nobody finds a problem within a couple of days. > +(defmacro gnus-get-display-table (character display-table) > + "Find value for CHARACTER in DISPLAY-TABLE. " > + (if (featurep 'xemacs) > + `(if (fboundp 'get-display-table) > + (get-display-table ,character ,display-table) > + (if (sequencep ,display-table) > + (aref ,display-table ,character) > + (get-char-table ,character ,display-table))) > + `(aref ,display-table ,char-table))) I suppose this should read... `(aref ,display-table ,character))) ,---- | In gnus-get-display-table: | gnus-util.el:1823:28:Warning: reference to free variable `char-table' `---- Bye, Reiner. --=20 ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/