Re: nnir.el cleanup

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Sun, Apr 20 2008, Justus@piater.name wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> wrote on Sat, 19 Apr 2008:
>> Additionally, `substitute' is a function from the `cl' package.  While
>> it is okay to use cl macros at compile time[1], using cl at runtime.
>
> This is not my code; I just moved it around during restructuring. 

Sorry, I didn't notice.

> But how about the attached patch and the following change-log entry?

Thanks.  Unless someone points out a problem, I'll install it.

>> I'd suggest not to distribute Gnus files on your Web server.  
>
> (Of course, this was never intended to be a "distribution", 

Sure.  But people tend to pick up files outdated files from random
places which often leads to problems and strange bug reports.

> just to lower the barrier for testers.)

It raises the barrier for committers, though, unless you provide a
diff as well.  ;-)

Could someone look into the compiler warnings, please?  I don't
understand what the warnings about the arguments are about.

,----[ M-x emacs-lisp-byte-compile RET ]
| Compiling file [...]/contrib/nnir.el at Sun Apr 20 12:04:10 2008
| 
| In nnir-request-group:
| nnir.el:730:9:Warning: function nnir-request-group used to take 0+ arguments,
|     now takes 1-3
| 
| In nnir-retrieve-headers:
| nnir.el:760:9:Warning: function nnir-retrieve-headers used to take 0+
|     arguments, now takes 1-4
| 
| In nnir-request-article:
| nnir.el:828:9:Warning: function nnir-request-article used to take 0+
|     arguments, now takes 1-4
| 
| In nnir-compose-result:
| nnir.el:886:35:Warning: assignment to free variable `group'
| nnir.el:890:18:Warning: reference to free variable `group'
| 
| In nnir-run-swish++:
| nnir.el:1231:45:Warning: assignment to free variable `filenam'
| nnir.el:1232:43:Warning: reference to free variable `filenam'
| 
| In nnir-run-namazu:
| nnir.el:1489:28:Warning: reference to free variable `dirnam'
| nnir.el:1489:28:Warning: reference to free variable `artno'
`----

(Line numbers may differ due to local modifications.)

Bye, Reiner
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/