From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65834 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: declare-function in files from Gnus (hashcash.el, imap.el) Date: Sat, 01 Dec 2007 19:35:52 +0100 Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1196534211 30496 80.91.229.12 (1 Dec 2007 18:36:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Dec 2007 18:36:51 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 01 19:36:58 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IyXCz-0003FC-B6 for ged-emacs-devel@m.gmane.org; Sat, 01 Dec 2007 19:36:57 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IyXCj-00043m-BY for ged-emacs-devel@m.gmane.org; Sat, 01 Dec 2007 13:36:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IyXCg-00043h-Be for emacs-devel@gnu.org; Sat, 01 Dec 2007 13:36:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IyXCf-00043M-K3 for emacs-devel@gnu.org; Sat, 01 Dec 2007 13:36:37 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IyXCf-00043G-H2 for emacs-devel@gnu.org; Sat, 01 Dec 2007 13:36:37 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IyXCa-00038G-E2; Sat, 01 Dec 2007 13:36:32 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.1/8.14.1) with ESMTP id lB1IaUjx000700; Sat, 1 Dec 2007 19:36:30 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 723B21C4A4; Sat, 1 Dec 2007 19:36:30 +0100 (CET) X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T; w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv, vbL^XF1nIp\:F=$Ei2o&mEe:%N~, :3]vtQ~s9u$9izmX$IF@VgGl7/, ^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Followup-To: Glenn Morris , ding@gnus.org, emacs-devel@gnu.org In-Reply-To: (Glenn Morris's message of "Fri, 30 Nov 2007 18:27:17 -0500") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) X-DCC-INFN-TO-Metrics: poseidon 1233; Body=3 Fuz1=3 Fuz2=3 X-Virus-Scanned: by amavisd-new X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84434 gmane.emacs.gnus.general:65834 Archived-At: On Sat, Dec 01 2007, Glenn Morris wrote: > Reiner Steib wrote: > >> Maybe we could add (defalias 'declare-function 'ignore ...) (like in >> Emacs 22.2) to `gnus/lisp/dgnushack.el' (in Gnus). > > I think that's the best idea. I'm not so sure. Several problems come to my mind: - `dgnushack.el' itself is considered harmful by some people. Instead of compiling all lisp files at once, the make procedure should maybe call "emacs ... -f batch-byte-compile FILE.el" for each file as the Makefile in Emacs does. - When compiling with Emacs 22.1 (or Emacs 21) even with `ignore', I get additional bogus warnings: /usr/bin/emacs-22.1 -Q -batch --eval \ "(unless (fboundp 'declare-function) (defalias 'declare-function 'ignore))" \ -f batch-byte-compile emacs/lisp/net/imap.el In toplevel form: imap.el:969:19:Warning: reference to free variable `sasl-find-mechanism' imap.el:970:19:Warning: reference to free variable `sasl-mechanism-name' imap.el:971:19:Warning: reference to free variable `sasl-make-client' imap.el:971:57:Warning: reference to free variable `name' imap.el:971:62:Warning: reference to free variable `service' imap.el:971:70:Warning: reference to free variable `server' imap.el:972:19:Warning: reference to free variable `sasl-next-step' imap.el:972:54:Warning: reference to free variable `step' imap.el:973:19:Warning: reference to free variable `sasl-step-data' imap.el:974:19:Warning: reference to free variable `sasl-step-set-data' imap.el:974:52:Warning: reference to free variable `data' In end of data: imap.el:2969:1:Warning: the following functions are not known to be defined: mechanism, client, step, sasl-mechanism-name, sasl-make-client, sasl-next-step, sasl-step-data, sasl-step-set-data Wrote [...]/emacs/lisp/net/imap.elc - When loading `*.el' or evaluating the buffer (sometimes necessary to get a better backtrace or for testing), you get: eval-buffer: Symbol's function definition is void: declare-function - Doesn't it work for XEmacs? When building an XEmacs package, `dgnushack.el' isn't used, I'd guess. > This would let us add similar statements to files in gnus/. Please don't do this yet. Let's wait until we come to a good solution in this thread and until Miles has synched the current declare-function changes to Gnus and we see which (other) problems it may cause for the stand-alone Gnus. > (I just posted to ding suggesting this; may as well use this thread > to discuss it rather than that one.) Yes. I hadn't seen your message when writing/sending mine. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/