From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65532 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Rewriting gnus-group-highlight-line (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Date: Sun, 28 Oct 2007 02:05:57 +0200 Message-ID: References: <200710200643.l9K6h9gk021348@oogie-boogie.ics.uci.edu> <200710222007.l9MK7fRZ022140@oogie-boogie.ics.uci.edu> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194027432 26501 80.91.229.12 (2 Nov 2007 18:17:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 Nov 2007 18:17:12 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M14026@lists.math.uh.edu Fri Nov 02 19:17:14 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1Io14w-0000KG-TE for ding-account@gmane.org; Fri, 02 Nov 2007 19:17:11 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Io12y-0003Nh-PI; Fri, 02 Nov 2007 13:15:08 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Ilvfo-00059C-PQ for ding@lists.math.uh.edu; Sat, 27 Oct 2007 19:06:36 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1Ilvfi-0008VE-N8 for ding@lists.math.uh.edu; Sat, 27 Oct 2007 19:06:36 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ilvfc-000280-00 for ; Sun, 28 Oct 2007 02:06:24 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.1/8.14.1) with ESMTP id l9S06T8o005592 for ; Sun, 28 Oct 2007 02:06:29 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id D523A12C8E for ; Sun, 28 Oct 2007 02:06:28 +0200 (CEST) In-Reply-To: (Richard Stallman's message of "Tue, 23 Oct 2007 06:39:11 -0400") X-Face: .*T0'iU(sujq_j9\J>-d4fg;N/1++U#U$_5ii6k.=|"-n'?5O:Hyz&wi'-!I~,}7~GgT=0S /&-R5sbkNy5+Xo1y{Tw2KKxi@Xh"g@]Qc|.U<*]WDd)qvGowFDvfU1F]{EDho:7P0@|oOD=Bc{K4?> WP68K[Mx:}=`ZT'6g4'f+g?;`vri2!)xGy}3:=l'(/Cea0l4lo^H5#@/Z3ev Mail-Followup-To: Richard Stallman , ding@gnus.org Mail-Followup-To: Richard Stallman , ding@gnus.org User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-DCC-CTc-dcc1-Metrics: poseidon 1030; Body=1 Fuz1=1 Fuz2=1 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:65532 Archived-At: On Tue, Oct 23 2007, Richard Stallman wrote: > > > (defun gnus-group-highlight-line () > > > "Highlight the current line according to `gnus-group-highlight'." > [...] > > It seems that `mailp' is not used in that function. > > `mailp' is used implicitly through the variable `gnus-group-highlight' > which is let-bound to `list'. `list' is used in the body of the > let-form. > > That code is a terrible crock. Would you please rewrite it to make it > clearer? I'm not sure if I understand what exactly should be rewritten in this function: The use of `mailp' through `gnus-group-highlight', the accessing `gnus-group-highlight' through `list', both, or something else. Bye, Reiner. P.S.: Resent to ding. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/