Re: smtpmail.el: set-buffer-file-coding-system takes too many args

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Sat, Jan 06 2007, Simon Josefsson wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> IIRC, smtpmail.el is also included with XEmacs.  Simon, is
>> `smtpmail.el' (from Emacs CVS) supposed to work with XEmacs without
>> modifications?
>
> No.  There are several modifications between XEmacs and Emacs
> smtpmail.el, alas.
>
>> If so `smtpmail.el' should probably not use the NOMODIFY argument or
>> provide some compatibility code.
>
> XEmacs users should use the smtpmail.el from mail-lib, there should be
> no reason to use the Emacs CVS stuff (if there is, a bug report would
> be most welcome!).

What do you suggest for contrib/smtpmail.el?  As `contrib/smtpmail.el'
should only be used with Emacs 21, we probably can simply remove the
NOMODIFY argument (and add a comment to explain it).

Suggestion (similar for the second location):

--8<---------------cut here---------------start------------->8---
--- smtpmail.el	04 Dec 2006 23:32:00 +0100	7.5
+++ smtpmail.el	06 Jan 2007 20:58:24 +0100	
@@ -248,7 +248,11 @@
 	  ;; buffer, otherwise any write-region invocations (e.g., in
 	  ;; mail-do-fcc below) will annoy with asking for a suitable
 	  ;; encoding.
-	  (set-buffer-file-coding-system smtpmail-code-conv-from nil t)
+	  ;; (set-buffer-file-coding-system smtpmail-code-conv-from nil t)
+	  (set-buffer-file-coding-system smtpmail-code-conv-from nil)
+	  ;; This file (`gnus/contrib/smtpmail.el') is only useful for Emacs
+	  ;; which doesn't support the thried argument (NOMODIFY) of
+	  ;; `set-buffer-file-coding-system'.
 	  (insert-buffer-substring mailbuf)
 	  (goto-char (point-max))
 	  ;; require one newline at the end.
--8<---------------cut here---------------end--------------->8---

BTW: Is NOMODIFY really useful here?  In both cases,
`set-buffer-file-coding-system' is followed by
`insert-buffer-substring' which will mark the buffer modified anyhow.
What am I missing?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/